ArthurGuy / BBMembershipSystem

app/Entities/Equipment.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
     /**
      * Add a photo name to the photos array
      *
-     * @param $fileName
+     * @param string $fileName
      */
     public function addPhoto($fileName)
     {

app/Entities/KeyFob.php

Doc Comments +3 added lines

@@ -58,6 +58,9 @@
         return $record;
     }
 
+    /**
+     * @param string $fobId
+     */
     public static function lookupPartialTag($fobId)
     {
         $record = self::where('key_id', 'LIKE', '%' . strtoupper($fobId) . '%')->active()->first();

app/Entities/Role.php

Doc Comments +3 added lines

@@ -18,6 +18,9 @@
         return $this->belongsToMany('\BB\Entities\User')->withTimestamps();
     }
 
+    /**
+     * @param string $name
+     */
     public static function findByName($name) {
         $role = self::where('name', $name)->first();
         if ($role) {

app/Http/Controllers/ACS/ActivityController.php

Doc Comments +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Record the start of a new session
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Post(
      *     path="/acs/activity",
@@ -80,7 +80,7 @@ 
     /**
      * Update an ongoing activity
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Put(
      *     path="/acs/activity/{activityId}",
@@ -103,7 +103,7 @@ 
     /**
      * Show the form for creating a new resource.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Delete(
      *     path="/acs/activity/{activityId}",

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 
 
         return response()->json([
-            'activityId' => isset($activityId)? $activityId: null,
+            'activityId' => isset($activityId) ? $activityId : null,
             'user'       => [
                 'id'              => $keyFob->user->id,
                 'name'            => $keyFob->user->name,

app/Http/Controllers/ExpensesController.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Store a newly created resource in storage.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      * @throws ImageFailedException
      * @throws \BB\Exceptions\FormValidationException
      */

Spacing +2 added lines, -2 removed lines

@@ -83,13 +83,13 @@
                 $ext = \Input::file('file')->guessClientExtension();
                 $mimeType = \Input::file('file')->getMimeType();
 
-                $newFilename = \App::environment().'/expenses/' . str_random() . '.' . $ext;
+                $newFilename = \App::environment() . '/expenses/' . str_random() . '.' . $ext;
 
                 Storage::put($newFilename, file_get_contents($filePath), 'public');
 
                 $data['file'] = $newFilename;
 
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 \Log::error($e);
                 throw new ImageFailedException($e->getMessage());
             }

app/Repo/EquipmentLogRepository.php

Doc Comments +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
      * Locate a users active session
      * @param integer $userId
      * @param string $deviceKey
-     * @return integer|false
+     * @return integer
      */
     public function findActiveUserSession($userId, $deviceKey)
     {
@@ -76,8 +76,8 @@ 
 
     /**
      * Return an existing active session for the device, if any
-     * @param $deviceKey
-     * @return integer|false
+     * @param string $deviceKey
+     * @return integer
      */
     public function findActiveDeviceSession($deviceKey)
     {
@@ -132,7 +132,7 @@ 
 
     /**
      * Return records that have been checked over
-     * @param $deviceKey
+     * @param string $deviceKey
      * @return mixed
      */
     public function getFinishedForEquipment($deviceKey)
@@ -143,7 +143,7 @@ 
     /**
      * @param string $deviceKey
      * @param bool   $billedTime
-     * @param null   $reason
+     * @param string   $reason
      * @return int
      */
     public function getTotalTime($deviceKey, $billedTime = null, $reason = null)

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
             }
         });
 
-        return (int) ($totalTime / 60);
+        return (int)($totalTime / 60);
     }
 
     /**

app/Console/Kernel.php

Spacing +8 added lines, -8 removed lines

@@ -33,28 +33,28 @@
     {
 
         $schedule->command('bb:calculate-proposal-votes')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
 
         $schedule->command('bb:check-memberships')->dailyAt('06:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
 
         $schedule->command('bb:fix-equipment-log')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
 
         $schedule->command('bb:calculate-equipment-fees')->dailyAt('02:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
 
         $schedule->command('bb:update-balances')->dailyAt('03:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
 
         $schedule->command('bb:create-todays-sub-charges')->dailyAt('01:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
 
         $schedule->command('bb:bill-members')->dailyAt('01:30')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
 
         $schedule->command('device:check-online')->everyTenMinutes()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
     }
 
     protected function pingIfProduction($url)

app/Entities/ACSNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     public function heartbeatWarning()
     {
         //If the last heartbeat was more than an hour ago there is an issue
-        if ( $this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
+        if ($this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
             return true;
         }
 

app/Exceptions/Handler.php

Spacing +5 added lines, -5 removed lines

@@ -20,7 +20,7 @@ 
         ModelNotFoundException::class,
         MethodNotAllowedHttpException::class,
         FormValidationException::class,
-        AuthenticationException::class,         //These are logged separately below
+        AuthenticationException::class, //These are logged separately below
 	];
 
 	/**
@@ -63,7 +63,7 @@ 
         }
 
         if ($e instanceof NotImplementedException) {
-            \Notification::error("NotImplementedException: ".$e->getMessage());
+            \Notification::error("NotImplementedException: " . $e->getMessage());
             \Log::warning($e);
             return redirect()->back()->withInput();
         }
@@ -72,8 +72,8 @@ 
             if ($request->wantsJson()) {
                 return \Response::json(['error' => $e->getMessage()], 403);
             }
-            $userString = \Auth::guest() ? "A guest": \Auth::user()->name;
-            \Log::warning($userString." tried to access something they weren't supposed to.");
+            $userString = \Auth::guest() ? "A guest" : \Auth::user()->name;
+            \Log::warning($userString . " tried to access something they weren't supposed to.");
 
             return \Response::view('errors.403', [], 403);
         }
@@ -82,7 +82,7 @@ 
             $e = new HttpException(404, $e->getMessage());
         }
 
-        if (config('app.debug') && $this->shouldReport($e) && !$request->wantsJson())
+        if (config('app.debug') && $this->shouldReport($e) && ! $request->wantsJson())
         {
             return $this->renderExceptionWithWhoops($e);
         }