ArthurGuy / BBMembershipSystem

app/Repo/EquipmentLogRepository.php

Doc Comments +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
      * Locate a users active session
      * @param integer $userId
      * @param string $deviceKey
-     * @return integer|false
+     * @return integer
      */
     public function findActiveUserSession($userId, $deviceKey)
     {
@@ -76,8 +76,8 @@ 
 
     /**
      * Return an existing active session for the device, if any
-     * @param $deviceKey
-     * @return integer|false
+     * @param string $deviceKey
+     * @return integer
      */
     public function findActiveDeviceSession($deviceKey)
     {
@@ -132,7 +132,7 @@ 
 
     /**
      * Return records that have been checked over
-     * @param $deviceKey
+     * @param string $deviceKey
      * @return mixed
      */
     public function getFinishedForEquipment($deviceKey)
@@ -143,7 +143,7 @@ 
     /**
      * @param string $deviceKey
      * @param bool   $billedTime
-     * @param null   $reason
+     * @param string   $reason
      * @return int
      */
     public function getTotalTime($deviceKey, $billedTime = null, $reason = null)

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\EquipmentLog;
 use BB\Exceptions\DeviceException;
-use BB\Exceptions\ValidationException;
 use Carbon\Carbon;
 
 class EquipmentLogRepository extends DBRepository

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
             }
         });
 
-        return (int) ($totalTime / 60);
+        return (int)($totalTime / 60);
     }
 
     /**

app/Services/Credit.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\User;
 use BB\Exceptions\InvalidDataException;
-use BB\Exceptions\NotImplementedException;
 use BB\Repo\PaymentRepository;
 use BB\Repo\UserRepository;
 

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     public function recalculate()
     {
-        if (! $this->user instanceof User) {
+        if ( ! $this->user instanceof User) {
             throw new InvalidDataException("User not set");
         }
         $runningTotal = 0;
@@ -96,7 +96,7 @@ 
      */
     public function getBalanceSign()
     {
-        return ( (int) $this->getBalance() >= 0 ? 'positive' : 'negative' );
+        return ((int)$this->getBalance() >= 0 ? 'positive' : 'negative');
     }
 
     public function getBalanceFormatted()

app/Console/Kernel.php

Spacing +8 added lines, -8 removed lines

@@ -33,28 +33,28 @@
     {
 
         $schedule->command('bb:calculate-proposal-votes')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
 
         $schedule->command('bb:check-memberships')->dailyAt('06:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
 
         $schedule->command('bb:fix-equipment-log')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
 
         $schedule->command('bb:calculate-equipment-fees')->dailyAt('02:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
 
         $schedule->command('bb:update-balances')->dailyAt('03:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
 
         $schedule->command('bb:create-todays-sub-charges')->dailyAt('01:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
 
         $schedule->command('bb:bill-members')->dailyAt('01:30')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
 
         $schedule->command('device:check-online')->everyTenMinutes()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
     }
 
     protected function pingIfProduction($url)

app/Entities/ACSNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     public function heartbeatWarning()
     {
         //If the last heartbeat was more than an hour ago there is an issue
-        if ( $this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
+        if ($this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
             return true;
         }
 

app/Entities/Notification.php

Braces +2 added lines, -1 removed lines

@@ -35,7 +35,8 @@
      * @param string $hash
      * @return Notification
      */
-    public static function logNew($userId, $message, $type, $hash) {
+    public static function logNew($userId, $message, $type, $hash)
+    {
         $existingNotifications = Notification::where('user_id', $userId)->where('hash', $hash)->first();
         if ($existingNotifications) {
             return $existingNotifications;

app/Events/Event.php

Indentation +1 added lines, -1 removed lines

@@ -2,6 +2,6 @@
 
 abstract class Event {
 
-	//
+    //
 
 }

Braces +2 added lines, -1 removed lines

@@ -1,6 +1,7 @@
 <?php namespace BB\Events;
 
-abstract class Event {
+abstract class Event
+{
 
 	//
 

app/Exceptions/Handler.php

Indentation +30 added lines, -30 removed lines

@@ -9,43 +9,43 @@ 
 
 class Handler extends ExceptionHandler {
 
-	/**
-	 * A list of the exception types that should not be reported.
-	 *
-	 * @var array
-	 */
-	protected $dontReport = [
+    /**
+     * A list of the exception types that should not be reported.
+     *
+     * @var array
+     */
+    protected $dontReport = [
         HttpException::class,
         NotFoundHttpException::class,
         ModelNotFoundException::class,
         MethodNotAllowedHttpException::class,
         FormValidationException::class,
         AuthenticationException::class,         //These are logged separately below
-	];
+    ];
 
-	/**
-	 * Report or log an exception.
-	 *
-	 * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
-	 *
-	 * @param  \Exception  $e
-	 * @return void
-	 */
-	public function report(Exception $e)
-	{
+    /**
+     * Report or log an exception.
+     *
+     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
+     *
+     * @param  \Exception  $e
+     * @return void
+     */
+    public function report(Exception $e)
+    {
         //The parent will log exceptions that aren't of the types above
-		parent::report($e);
-	}
+        parent::report($e);
+    }
 
-	/**
-	 * Render an exception into an HTTP response.
-	 *
-	 * @param  \Illuminate\Http\Request  $request
-	 * @param  \Exception  $e
-	 * @return \Illuminate\Http\Response
-	 */
-	public function render($request, Exception $e)
-	{
+    /**
+     * Render an exception into an HTTP response.
+     *
+     * @param  \Illuminate\Http\Request  $request
+     * @param  \Exception  $e
+     * @return \Illuminate\Http\Response
+     */
+    public function render($request, Exception $e)
+    {
         if ($e instanceof FormValidationException) {
             if ($request->wantsJson()) {
                 return \Response::json($e->getErrors(), 422);
@@ -92,8 +92,8 @@ 
                 return \Response::json(['error' => $e->getMessage()], $e->getStatusCode());
             }
         }
-		return parent::render($request, $e);
-	}
+        return parent::render($request, $e);
+    }
 
     /**
      * Render an exception using Whoops.

Spacing +5 added lines, -5 removed lines

@@ -20,7 +20,7 @@ 
         ModelNotFoundException::class,
         MethodNotAllowedHttpException::class,
         FormValidationException::class,
-        AuthenticationException::class,         //These are logged separately below
+        AuthenticationException::class, //These are logged separately below
 	];
 
 	/**
@@ -63,7 +63,7 @@ 
         }
 
         if ($e instanceof NotImplementedException) {
-            \Notification::error("NotImplementedException: ".$e->getMessage());
+            \Notification::error("NotImplementedException: " . $e->getMessage());
             \Log::warning($e);
             return redirect()->back()->withInput();
         }
@@ -72,8 +72,8 @@ 
             if ($request->wantsJson()) {
                 return \Response::json(['error' => $e->getMessage()], 403);
             }
-            $userString = \Auth::guest() ? "A guest": \Auth::user()->name;
-            \Log::warning($userString." tried to access something they weren't supposed to.");
+            $userString = \Auth::guest() ? "A guest" : \Auth::user()->name;
+            \Log::warning($userString . " tried to access something they weren't supposed to.");
 
             return \Response::view('errors.403', [], 403);
         }
@@ -82,7 +82,7 @@ 
             $e = new HttpException(404, $e->getMessage());
         }
 
-        if (config('app.debug') && $this->shouldReport($e) && !$request->wantsJson())
+        if (config('app.debug') && $this->shouldReport($e) && ! $request->wantsJson())
         {
             return $this->renderExceptionWithWhoops($e);
         }

Braces +3 added lines, -3 removed lines

@@ -7,7 +7,8 @@ 
 use Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
-class Handler extends ExceptionHandler {
+class Handler extends ExceptionHandler
+{
 
 	/**
 	 * A list of the exception types that should not be reported.
@@ -82,8 +83,7 @@ 
             $e = new HttpException(404, $e->getMessage());
         }
 
-        if (config('app.debug') && $this->shouldReport($e) && !$request->wantsJson())
-        {
+        if (config('app.debug') && $this->shouldReport($e) && !$request->wantsJson()) {
             return $this->renderExceptionWithWhoops($e);
         }
 

app/Http/Controllers/ACSSparkController.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     function __construct(ACSNodeRepository $acsNodeRepository, KeyFobAccess $keyFobAccess, PaymentRepository $paymentRepository)
     {
         $this->acsNodeRepository = $acsNodeRepository;
-        $this->keyFobAccess     = $keyFobAccess;
+        $this->keyFobAccess = $keyFobAccess;
         $this->paymentRepository = $paymentRepository;
     }
 

app/Http/Controllers/Auth/AuthController.php

Indentation +15 added lines, -15 removed lines

@@ -7,7 +7,7 @@ 
 
 class AuthController extends Controller {
 
-	/*
+    /*
 	|--------------------------------------------------------------------------
 	| Registration & Login Controller
 	|--------------------------------------------------------------------------
@@ -18,21 +18,21 @@ 
 	|
 	*/
 
-	use AuthenticatesAndRegistersUsers;
+    use AuthenticatesAndRegistersUsers;
 
-	/**
-	 * Create a new authentication controller instance.
-	 *
-	 * @param  \Illuminate\Contracts\Auth\Guard  $auth
-	 * @param  \Illuminate\Contracts\Auth\Registrar  $registrar
-	 * @return void
-	 */
-	public function __construct(Guard $auth, Registrar $registrar)
-	{
-		$this->auth = $auth;
-		$this->registrar = $registrar;
+    /**
+     * Create a new authentication controller instance.
+     *
+     * @param  \Illuminate\Contracts\Auth\Guard  $auth
+     * @param  \Illuminate\Contracts\Auth\Registrar  $registrar
+     * @return void
+     */
+    public function __construct(Guard $auth, Registrar $registrar)
+    {
+        $this->auth = $auth;
+        $this->registrar = $registrar;
 
-		$this->middleware('guest', ['except' => 'getLogout']);
-	}
+        $this->middleware('guest', ['except' => 'getLogout']);
+    }
 
 }

Braces +2 added lines, -1 removed lines

@@ -5,7 +5,8 @@
 use Illuminate\Contracts\Auth\Registrar;
 use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
 
-class AuthController extends Controller {
+class AuthController extends Controller
+{
 
 	/*
 	|--------------------------------------------------------------------------