ArthurGuy / BBMembershipSystem

app/Http/Controllers/ReminderController.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      * Handle a POST request to reset a user's password.
      *
      * @param Request $request
-     * @return \Illuminate\Http\RedirectResponse|null
+     * @return \Illuminate\Http\RedirectResponse
      */
 	public function postReset(Request $request)
 	{

Indentation +26 added lines, -26 removed lines

@@ -9,16 +9,16 @@ 
 class ReminderController extends Controller
 {
 
-	/**
-	 * Display the password reminder view.
-	 *
-	 * @return Response
-	 */
-	public function create()
-	{
+    /**
+     * Display the password reminder view.
+     *
+     * @return Response
+     */
+    public function create()
+    {
 
         return view('password.create');
-	}
+    }
 
     /**
      * Handle a POST request to remind a user of their password.
@@ -26,8 +26,8 @@ 
      * @param Request $request
      * @return \Illuminate\Http\RedirectResponse|null
      */
-	public function store(Request $request)
-	{
+    public function store(Request $request)
+    {
         $validator = app('Illuminate\Contracts\Validation\Factory')->make($request->all(), ['email' => 'required|email']);
         if ($validator->fails()) {
             throw new FormValidationException('Error', $validator->errors());
@@ -39,31 +39,31 @@ 
         });
 
         switch ($response) {
-			case Password::INVALID_USER:
+            case Password::INVALID_USER:
                 \Notification::error(trans($response));
                 return redirect()->back();
 
-			case Password::RESET_LINK_SENT:
+            case Password::RESET_LINK_SENT:
                 \Notification::success(trans($response));
                 return redirect()->back();
-		}
-	}
-
-	/**
-	 * Display the password reset view for the given token.
-	 *
-	 * @param  string  $token
-	 * @return Response
-	 */
-	public function getReset($token = null)
-	{
+        }
+    }
+
+    /**
+     * Display the password reset view for the given token.
+     *
+     * @param  string  $token
+     * @return Response
+     */
+    public function getReset($token = null)
+    {
         if (is_null($token))
         {
             throw new NotFoundHttpException;
         }
 
         return view('password.reset')->with('token', $token);
-	}
+    }
 
     /**
      * Handle a POST request to reset a user's password.
@@ -71,8 +71,8 @@ 
      * @param Request $request
      * @return \Illuminate\Http\RedirectResponse|null
      */
-	public function postReset(Request $request)
-	{
+    public function postReset(Request $request)
+    {
         $credentials = $request->only(
             'email', 'password', 'password_confirmation', 'token'
         );

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
             throw new FormValidationException('Error', $validator->errors());
         }
 
-        $response = Password::sendResetLink($request->only('email'), function(Message $message)
+        $response = Password::sendResetLink($request->only('email'), function (Message $message)
         {
             $message->subject('Reset your password');
         });
@@ -89,7 +89,7 @@ 
         //We aren't using a confirm password box so this can be faked
         $credentials['password_confirmation'] = $credentials['password'];
 
-        $response = Password::reset($credentials, function($user, $password) {
+        $response = Password::reset($credentials, function ($user, $password) {
             $user->password = $password;
 
             $user->save();

Braces +2 added lines, -4 removed lines

@@ -33,8 +33,7 @@ 
             throw new FormValidationException('Error', $validator->errors());
         }
 
-        $response = Password::sendResetLink($request->only('email'), function(Message $message)
-        {
+        $response = Password::sendResetLink($request->only('email'), function(Message $message) {
             $message->subject('Reset your password');
         });
 
@@ -57,8 +56,7 @@ 
 	 */
 	public function getReset($token = null)
 	{
-        if (is_null($token))
-        {
+        if (is_null($token)) {
             throw new NotFoundHttpException;
         }
 

app/Listeners/EmailMemberAboutDeclinedPhoto.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 
 use BB\Events\MemberPhotoWasDeclined;
 use Illuminate\Contracts\Mail\Mailer;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 class EmailMemberAboutDeclinedPhoto
 {

app/Repo/EquipmentLogRepository.php

Doc Comments +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
      * Locate a users active session
      * @param integer $userId
      * @param string $deviceKey
-     * @return integer|false
+     * @return integer
      */
     public function findActiveUserSession($userId, $deviceKey)
     {
@@ -76,8 +76,8 @@ 
 
     /**
      * Return an existing active session for the device, if any
-     * @param $deviceKey
-     * @return integer|false
+     * @param string $deviceKey
+     * @return integer
      */
     public function findActiveDeviceSession($deviceKey)
     {
@@ -132,7 +132,7 @@ 
 
     /**
      * Return records that have been checked over
-     * @param $deviceKey
+     * @param string $deviceKey
      * @return mixed
      */
     public function getFinishedForEquipment($deviceKey)
@@ -143,7 +143,7 @@ 
     /**
      * @param string $deviceKey
      * @param bool   $billedTime
-     * @param null   $reason
+     * @param string   $reason
      * @return int
      */
     public function getTotalTime($deviceKey, $billedTime = null, $reason = null)

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\EquipmentLog;
 use BB\Exceptions\DeviceException;
-use BB\Exceptions\ValidationException;
 use Carbon\Carbon;
 
 class EquipmentLogRepository extends DBRepository

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
             }
         });
 
-        return (int) ($totalTime / 60);
+        return (int)($totalTime / 60);
     }
 
     /**

app/Repo/InductionRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
     }
 
     /**
-     * @param $deviceId
-     * @return array
+     * @param string $deviceId
+     * @return Collection
      */
     public function getTrainersForEquipment($deviceId)
     {

app/Repo/PaymentRepository.php

Doc Comments +3 added lines

@@ -195,6 +195,9 @@
         $this->update($paymentId, ['user_id' => $userId]);
     }
 
+    /**
+     * @param integer $paymentId
+     */
     public function refundPaymentToBalance($paymentId)
     {
         $payment = $this->getById($paymentId);

Spacing +2 added lines, -2 removed lines

@@ -188,7 +188,7 @@ 
     {
         $payment = $this->getById($paymentId);
 
-        if (!empty($payment->user_id)) {
+        if ( ! empty($payment->user_id)) {
             throw new PaymentException('Payment already assigned to user');
         }
 
@@ -266,7 +266,7 @@ 
      */
     public function getEquipmentFeePayments($referencePrefix)
     {
-        return $this->model->where('reason', 'equipment-fee')->get()->filter(function($payment) use($referencePrefix) {
+        return $this->model->where('reason', 'equipment-fee')->get()->filter(function ($payment) use($referencePrefix) {
             return strpos($payment->reference, ':' . $referencePrefix) !== false;
         });
     }

app/Services/Credit.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\User;
 use BB\Exceptions\InvalidDataException;
-use BB\Exceptions\NotImplementedException;
 use BB\Repo\PaymentRepository;
 use BB\Repo\UserRepository;
 

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 
     public function recalculate()
     {
-        if (! $this->user instanceof User) {
+        if ( ! $this->user instanceof User) {
             throw new InvalidDataException("User not set");
         }
         $runningTotal = 0;

app/Services/KeyFobAccess.php

Doc Comments +3 added lines

@@ -179,6 +179,9 @@
     }
 
 
+    /**
+     * @return KeyFob
+     */
     public function lookupKeyFob($keyId)
     {
         try {

app/Console/Kernel.php

Spacing +8 added lines, -8 removed lines

@@ -33,28 +33,28 @@
     {
 
         $schedule->command('bb:calculate-proposal-votes')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
 
         $schedule->command('bb:check-memberships')->dailyAt('06:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
 
         $schedule->command('bb:fix-equipment-log')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
 
         $schedule->command('bb:calculate-equipment-fees')->dailyAt('02:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
 
         $schedule->command('bb:update-balances')->dailyAt('03:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
 
         $schedule->command('bb:create-todays-sub-charges')->dailyAt('01:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
 
         $schedule->command('bb:bill-members')->dailyAt('01:30')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
 
         $schedule->command('device:check-online')->everyTenMinutes()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
     }
 
     protected function pingIfProduction($url)

app/Entities/ACSNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     public function heartbeatWarning()
     {
         //If the last heartbeat was more than an hour ago there is an issue
-        if ( $this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
+        if ($this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
             return true;
         }