BB\Http\Controllers\ACS\ActivityController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	122
Duplicated Lines	13.11 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	store()	0	31	3
A	update()	8	8	1
A	destroy()	8	8	1

<?php

namespace BB\Http\Controllers\ACS;

use BB\Entities\ACSNode;
use BB\Events\MemberActivity;
use BB\Repo\ACSNodeRepository;
use BB\Repo\EquipmentLogRepository;
use BB\Services\KeyFobAccess;
use Illuminate\Http\Request;
use BB\Http\Requests;
use BB\Http\Controllers\Controller;
use Swagger\Annotations as SWG;

class ActivityController extends Controller
{
    /**
     * @var ACSNodeRepository
     */
    private $ACSNodeRepository;
    /**
     * @var EquipmentLogRepository
     */
    private $equipmentLogRepository;
    /**
     * @var KeyFobAccess
     */
    private $fobAccess;

    /**
     * NodeController constructor.
     *
     * @param ACSNodeRepository $ACSNodeRepository
     */
    public function __construct(ACSNodeRepository $ACSNodeRepository, EquipmentLogRepository $equipmentLogRepository, KeyFobAccess $fobAccess)
    {
        $this->ACSNodeRepository = $ACSNodeRepository;
        $this->equipmentLogRepository = $equipmentLogRepository;
        $this->fobAccess = $fobAccess;
    }

    /**
     * Record the start of a new session
     *
     * @return \Illuminate\Http\Response
     *
     * @SWG\Post(
     *     path="/acs/activity",
     *     tags={"activity"},
     *     description="Record the start of a period of activity, e.g. someone signing into the laser cutter. If an entry device is specified no equipment access record is started but an activity log is created",
     *     @SWG\Parameter(name="activity", in="body", required=true, @SWG\Schema(ref="#/definitions/Activity")),
     *     @SWG\Response(response="201", description="Activity started, the body will contain the new activityId"),
     *     @SWG\Response(response="404", description="Key fob not found"),
     *     security={{"api_key": {}}}
     * )
     */
    public function store(Request $request)
    {
        $activityRequest = new Requests\ACS\Activity($request);

        $keyFob = $this->fobAccess->extendedKeyFobLookup($activityRequest->getTagId());

        // lookup the acs node
        $node = ACSNode::where('device_id', $activityRequest->getDevice())->firstOrFail();
        if ($node->entry_device) {
            $this->fobAccess->verifyForEntry($activityRequest->getTagId(), $activityRequest->getDevice(), $activityRequest->getOccurredAt());
            $this->fobAccess->logSuccess();
        } else {
            $activityId = $this->equipmentLogRepository->recordStartCloseExisting($keyFob->user->id, $keyFob->id, $activityRequest->getDevice());
            event(new MemberActivity($keyFob, $activityRequest->getDevice()));
        }



        return response()->json([
            'activityId' => isset($activityId)? $activityId: null,
            'user'       => [
                'id'              => $keyFob->user->id,
                'name'            => $keyFob->user->name,
                'status'          => $keyFob->user->status,
                'active'          => $keyFob->user->active,
                'key_holder'      => $keyFob->user->key_holder,
                'cash_balance'    => $keyFob->user->cash_balance,

The property cash_balance does not exist on object<BB\Entities\User>. Since you implemented __get, maybe consider adding a @property annotation.

                'profile_private' => $keyFob->user->profile_private,
            ]
        ], 201);
    }

    /**
     * Update an ongoing activity
     *
     * @return \Illuminate\Http\Response
     *
     * @SWG\Put(
     *     path="/acs/activity/{activityId}",
     *     tags={"activity"},
     *     description="Record a heartbeat message for a period of activity, used to ensure activity periods are correctly recorded",
     *     @SWG\Parameter(name="activityId", in="path", type="string", required=true),
     *     @SWG\Response(response="200", description="Activity Heartbeat recorded"),
     *     security={{"api_key": {}}}
     * )
     */
    public function update(Request $request, $activityId)
    {
        $keyFob = $this->fobAccess->extendedKeyFobLookup($request->get('tagId'));

        $this->equipmentLogRepository->recordActivity($activityId);

        return response()->json([], 200);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     *
     * @SWG\Delete(
     *     path="/acs/activity/{activityId}",
     *     tags={"activity"},
     *     description="End a period of an activity",
     *     @SWG\Parameter(name="activityId", in="path", type="string", required=true),
     *     @SWG\Response(response="204", description="Activity ended/deleted"),
     *     @SWG\Response(response="400", description="Session invalid"),
     *     security={{"api_key": {}}}
     * )
     */
    public function destroy(Request $request, $activityId)
    {
        $keyFob = $this->fobAccess->extendedKeyFobLookup($request->get('tagId'));

        $this->equipmentLogRepository->endSession($activityId);

        return response()->json([], 204);
    }

}