ArthurGuy / BBMembershipSystem

app/Http/Controllers/PaypalIPNController.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace BB\Http\Controllers;
 
-use BB\Entities\Payment;
 use BB\Entities\User;
 use BB\Helpers\PayPalConfig;
 use BB\Repo\PaymentRepository;

app/Listeners/EmailMemberAboutDeclinedPhoto.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 
 use BB\Events\MemberPhotoWasDeclined;
 use Illuminate\Contracts\Mail\Mailer;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 class EmailMemberAboutDeclinedPhoto
 {

app/Repo/EquipmentLogRepository.php

Doc Comments +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
      * Locate a users active session
      * @param integer $userId
      * @param string $deviceKey
-     * @return integer|false
+     * @return integer
      */
     public function findActiveUserSession($userId, $deviceKey)
     {
@@ -76,8 +76,8 @@ 
 
     /**
      * Return an existing active session for the device, if any
-     * @param $deviceKey
-     * @return integer|false
+     * @param string $deviceKey
+     * @return integer
      */
     public function findActiveDeviceSession($deviceKey)
     {
@@ -132,7 +132,7 @@ 
 
     /**
      * Return records that have been checked over
-     * @param $deviceKey
+     * @param string $deviceKey
      * @return mixed
      */
     public function getFinishedForEquipment($deviceKey)
@@ -143,7 +143,7 @@ 
     /**
      * @param string $deviceKey
      * @param bool   $billedTime
-     * @param null   $reason
+     * @param string   $reason
      * @return int
      */
     public function getTotalTime($deviceKey, $billedTime = null, $reason = null)

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\EquipmentLog;
 use BB\Exceptions\DeviceException;
-use BB\Exceptions\ValidationException;
 use Carbon\Carbon;
 
 class EquipmentLogRepository extends DBRepository

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
             }
         });
 
-        return (int) ($totalTime / 60);
+        return (int)($totalTime / 60);
     }
 
     /**

app/Services/Credit.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use BB\Entities\User;
 use BB\Exceptions\InvalidDataException;
-use BB\Exceptions\NotImplementedException;
 use BB\Repo\PaymentRepository;
 use BB\Repo\UserRepository;
 

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     public function recalculate()
     {
-        if (! $this->user instanceof User) {
+        if ( ! $this->user instanceof User) {
             throw new InvalidDataException("User not set");
         }
         $runningTotal = 0;
@@ -96,7 +96,7 @@ 
      */
     public function getBalanceSign()
     {
-        return ( (int) $this->getBalance() >= 0 ? 'positive' : 'negative' );
+        return ((int)$this->getBalance() >= 0 ? 'positive' : 'negative');
     }
 
     public function getBalanceFormatted()

app/Services/KeyFobAccess.php

Doc Comments +3 added lines

@@ -179,6 +179,9 @@
     }
 
 
+    /**
+     * @return KeyFob
+     */
     public function lookupKeyFob($keyId)
     {
         try {

app/Console/Kernel.php

Spacing +8 added lines, -8 removed lines

@@ -33,28 +33,28 @@
     {
 
         $schedule->command('bb:calculate-proposal-votes')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/U6l211ROnnZR1vI'); } );
 
         $schedule->command('bb:check-memberships')->dailyAt('06:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/76TWKkWBBpaIyOe'); } );
 
         $schedule->command('bb:fix-equipment-log')->hourly()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxi4SJkwZpIAkBv'); } );
 
         $schedule->command('bb:calculate-equipment-fees')->dailyAt('02:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/tFdRdkUoqSa8X66'); } );
 
         $schedule->command('bb:update-balances')->dailyAt('03:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/TSmoQANsHU9jbtU'); } );
 
         $schedule->command('bb:create-todays-sub-charges')->dailyAt('01:00')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/wSIUR1E2wjVBzPg'); } );
 
         $schedule->command('bb:bill-members')->dailyAt('01:30')
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/nxAz59P6LXlu2P1'); } );
 
         $schedule->command('device:check-online')->everyTenMinutes()
-            ->then( function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
+            ->then(function () { $this->pingIfProduction('http://beats.envoyer.io/heartbeat/WU4zql7LwZs1CzT'); } );
     }
 
     protected function pingIfProduction($url)

app/Entities/ACSNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     public function heartbeatWarning()
     {
         //If the last heartbeat was more than an hour ago there is an issue
-        if ( $this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
+        if ($this->monitor_heartbeat && ($this->last_heartbeat < Carbon::now()->subHour())) {
             return true;
         }
 

app/Entities/Notification.php

Braces +2 added lines, -1 removed lines

@@ -35,7 +35,8 @@
      * @param string $hash
      * @return Notification
      */
-    public static function logNew($userId, $message, $type, $hash) {
+    public static function logNew($userId, $message, $type, $hash)
+    {
         $existingNotifications = Notification::where('user_id', $userId)->where('hash', $hash)->first();
         if ($existingNotifications) {
             return $existingNotifications;

app/Events/Event.php

Indentation +1 added lines, -1 removed lines

@@ -2,6 +2,6 @@
 
 abstract class Event {
 
-	//
+    //
 
 }

Braces +2 added lines, -1 removed lines

@@ -1,6 +1,7 @@
 <?php namespace BB\Events;
 
-abstract class Event {
+abstract class Event
+{
 
 	//