ArjanSchouten\HtmlMinifier\Placeholders\WhitespacePlaceholder

Complexity

Total Complexity

6

Size/Duplication

Total Lines	150
Duplicated Lines	26 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	process()	0	10	1
A	whitespaceBetweenInlineElements()	21	21	1
A	whitespaceInInlineElements()	18	18	1
A	replaceWhitespacesInInlineElements()	0	6	1
B	replaceElementContents()	0	25	1
A	getInlineElementsRegex()	0	4	1

<?php

namespace ArjanSchouten\HtmlMinifier\Placeholders;

use ArjanSchouten\HtmlMinifier\PlaceholderContainer;

class WhitespacePlaceholder implements PlaceholderInterface
{
    /**
     * @var array
     */
    protected $htmlPlaceholderTags = [
        'plaintext',
        'textarea',
        'listing',
        'script',
        'style',
        'code',
        'cite',
        'pre',
        'xmp',
    ];

    /**
     * Replace critical content with a temporary placeholder.
     *
     * @param \ArjanSchouten\HtmlMinifier\MinifyContext $context
     *
     * @return \ArjanSchouten\HtmlMinifier\MinifyContext
     */
    public function process($context)
    {
        $contents = $context->getContents();

        $contents = $this->whitespaceBetweenInlineElements($contents, $context->getPlaceholderContainer());
        $contents = $this->whitespaceInInlineElements($contents, $context->getPlaceholderContainer());
        $contents = $this->replaceElementContents($contents, $context->getPlaceholderContainer());

        return $context->setContents($contents);
    }

    /**
     * Whitespaces between inline html elements must be replaced with a placeholder because
     * a browser is showing that whitespace.
     *
     * @param string $contents
     * @param \ArjanSchouten\HtmlMinifier\PlaceholderContainer $placeholderContainer
     *
     * @return string
     */
    protected function whitespaceBetweenInlineElements($contents, PlaceholderContainer $placeholderContainer)

This method seems to be duplicated in your project.

    {
        $elementsRegex = $this->getInlineElementsRegex();

        return preg_replace_callback(
            '/
                (
                    <('.$elementsRegex.')       # Match the start tag and capture it
                    (?:(?!<\/\2>).*)            # Match everything without the end tag
                    <\/\2>                      # Match the captured elements end tag
                )
                \s+                             # Match minimal 1 whitespace between the elements
                <('.$elementsRegex.')           # Match the start of the next inline element
            /xi',
            function ($match) use ($placeholderContainer) {
                // Where going to respect one space between the inline elements.
                $placeholder = $placeholderContainer->createPlaceholder(' ');

                return $match[1].$placeholder.'<'.$match[3];
        }, $contents);
    }

    /**
     * Whitespaces in an inline element have a function so we replace it.
     *
     * @param string $contents
     * @param \ArjanSchouten\HtmlMinifier\PlaceholderContainer $placeholderContainer
     *
     * @return string
     */
    protected function whitespaceInInlineElements($contents, PlaceholderContainer $placeholderContainer)

This method seems to be duplicated in your project.

    {
        $elementsRegex = $this->getInlineElementsRegex();

        return preg_replace_callback(
            '/
                (
                    <('.$elementsRegex.')   # Match an inline element
                    (?:(?!<\/\2>).*)        # Match everything except its end tag
                    <\/\2>                  # Match the end tag
                    \s+
                )
                <('.$elementsRegex.')       # Match starting tag
            /xis',
            function ($match) use ($placeholderContainer) {
                return $this->replaceWhitespacesInInlineElements($match[1], $placeholderContainer).'<'.$match[3];
            }, $contents);
    }

    /**
     * Replace the whitespaces in inline elements with a placeholder.
     *
     * @param string $element
     * @param \ArjanSchouten\HtmlMinifier\PlaceholderContainer $placeholderContainer
     *
     * @return string
     */
    private function replaceWhitespacesInInlineElements($element, PlaceholderContainer $placeholderContainer)
    {
        return preg_replace_callback('/>\s/', function ($match) use ($placeholderContainer) {

The parameter $match is not used and could be removed.

            return '>'.$placeholderContainer->createPlaceholder(' ');
        }, $element);
    }

    /**
     * @param string $contents
     * @param \ArjanSchouten\HtmlMinifier\PlaceholderContainer $placeholderContainer
     *
     * @return string
     */
    protected function replaceElementContents($contents, PlaceholderContainer $placeholderContainer)
    {
        $htmlTags = implode('|', $this->htmlPlaceholderTags);

        $pattern = '/
            (
                <(' . $htmlTags . ')                    # Match html start tag and capture
                    (?:
                        [^"\'>]*|"[^"]*"|\'[^\']*\'
                    )*                                  # Match all attributes
                >                                       # Match end of tag
            )
            (
                (?:                                     # Negotiate this part
                    (?!<\/\2>)                          # Negative look ahead for the end tag
                    .                                   # Match everything if not the end tag 
                )*+                                     # Possessive quantifier which will prevent backtracking
            )
            (<\/\2>)                                    # Match end tag by back referencing the start tag
            /xis';

        return preg_replace_callback($pattern, function ($match) use ($placeholderContainer) {
            return $match[1].$placeholderContainer->createPlaceholder($match[3]).$match[4];
        }, $contents);
    }

    /**
     * Get the regular expression for matching inline elements.
     *
     * @return string
     */
    private function getInlineElementsRegex()
    {
        return 'a(?:bbr|cronym)?|b(?:utton|r|ig|do)?|c(?:ite|ode)|dfn|em|i(?:mg|nput)|kbd|label|map|object|q|s(?:amp|elect|mall|pan|trong|u[bp])|t(?:extarea|t)|var';
    }
}