Issues in dialog.grants.logic.php (master) - Issues in master - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1751)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/templates/pobject/dialog.grants.logic.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
	$userConfig = $this->loadUserConfig();
	$authconfig = $userConfig['authentication'];

	if( !function_exists("grantsArrayToString") ) {
		function grantsArrayToString($grants) {
			$grantstring = "";
			if (is_array($grants)) {
				foreach ($grants as $grant => $granttype) {
					if (is_array($granttype)) {
						$grantstring .= " $grant ( ";
						reset($granttype);
						while (list($class, $modifierId)=each($granttype)) {
							if( $granttype > 0 ) {
								switch($modifierId) {
									case ARGRANTLOCAL:
										$modifier = "=";
									break;
									case ARGRANTCHILDREN:
										$modifier = ">";
									break;
									default:
										$modifier = "";
								}
								$grantstring .= " $modifier$class ";
							}
						}
						$grantstring .= " ) ";
					} elseif( $granttype > 0 ) {
						switch($granttype) {
							case ARGRANTLOCAL:
								$modifier = "=";
							break;
							case ARGRANTCHILDREN:
								$modifier = ">";
							break;
							default:
								$modifier = "";
						}
						$grantstring .= " $modifier$grant ";
					}
				}
			}
			return $grantstring;
		}
	}

	if( !function_exists("arGetGrantType") ) {
		function arGetGrantType($value) {
			if (($value & ARMASKLOCAL) && ($value & ARMASKCHILDREN)) {
				$result="";
			} else if ($value & ARMASKLOCAL) {
				$result="=";
			} else {
				$result=">";
			}
			return $result;
		}
	}

	if( !function_exists("array_compare") ) {
		function array_compare(&$ar1, &$ar2) {
			if (count($ar1) != count($ar2)) {
				return false;
			} else {
				foreach ($ar1 as $key => $value) {
					if (is_array($value) && is_array($ar2[$key])) {
						return array_compare($ar1[$key], $ar2[$key]);
					} else
					if ($value !== $ar2[$key]) {
						return false;
					}
					return true;
				}
			}
		}
	}

	if( !function_exists("getClass") ) {
		function getClass($grey=false) {
			global $ARCurrent;
			if ($ARCurrent->oddline=($ARCurrent->oddline+1)%2) {
				$class='odd';
			} else {
				$class='even';
			}
			if ($grey) {
				$class .= '-grey';
			}
			return $class;
		}
	}

	if( !function_exists("getPathByType") ) {
		function getPathByType($type, $id) {
			global $AR;
			switch ($type) {
				case 'pgroup':
					foreach ($authconfig['groupdirs'] as $groupdir) {

						$path  = current($AR->user->find($groupdir, 'login.value=\''.$id.'\'', 'system.get.path.phtml'));
						if ($path) {
							break;
						}
					}
					break;
				case 'puser':
					foreach ($authconfig['userdirs'] as $userdir) {
						$path  = current($AR->user->find($userdir, 'login.value=\''.$id.'\'', 'system.get.path.phtml'));
						if ($path) {
							break;
						}
					}
					break;
			}
			return $path;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}
	}

	if( !function_exists("removeSimilarGrants") ) {
		function removeSimilarGrants($grants) {
			// first check for similar grants (same modifiers)
			$grants_check = $grants;
			foreach ($grants as $grant => $grant_ar) {
				// loop $grants for each entry in $grants_check (which is a copy)
				array_shift($grants_check);
				if (is_array($grant_ar)) {
					foreach ($grants_check as $grant_c => $grant_ar_c) {
						if (is_array($grant_ar_c) && array_compare($grant_ar, $grant_ar_c)) {
							unset($grants[$grant_c]);
						}
					}
				}
			}
			reset($grants);
			ksort($grants);
			return $grants;
		}
	}

	if( !function_exists("getGrantString") ) {
		function getGrantString($id, $type, $grants, $grey) {
			if ($grants && is_array($grants)) {
				$grants = removeSimilarGrants($grants);
				$grant_display = '';
				$grant_string = '';

				foreach ($grants as $grant => $modifiers) {
					if (!is_array($modifiers)) {
						$grant_type=arGetGrantType($modifiers);
						$grant_display .= htmlspecialchars($grant_type); // echo
					} else {
						$grant_type='';
					}

					if (!$grey) {
						$grant_display .= "<a href=\"javascript:selectGrant('$type', '$id', '$grant');\">";
					} else {
						$grant_display .= "<span class='grey'>";
					}

					$grant_display .= $grant;
					if (is_array($grants_eq[$grant])) {

						foreach ($grants_eq[$grant] as $g_add) {

							$grant .= ", ".$grant_type."$g_add";
						}
						$grant_display .= "[$grant]";
						$grant_string .= "[$grant]";
					} else {
						$grant_string .= "$grant_type$grant ";
					}
					if (is_array($modifiers)) {
						$grant_string .= "( ";
						$grant_display .= "( ";
						foreach ($modifiers as $modifier => $value) {
							$grant_type=arGetGrantType($value);
							$grant_display .= htmlspecialchars($grant_type);
							$grant_display .= $modifier." ";
							$grant_string .= $grant_type.$modifier." ";
						}
						$grant_display .= ") ";
						$grant_string .= ") ";
					}
					if (!$grey) {
						$grant_display .= "</a>";
					} else {
						$grant_display .= "</span>";
					}
				}
				$grant_display .= " ";
				$grant_string .= " ";
			}
			return array($grant_string, $grant_display);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}
	}

	if( !function_exists("DisplayGrants") ) {
		function DisplayGrants(&$grantslist, $type, $grey=false) {
			global $AR, $ARCurrent;
			if ($grantslist[$type] && is_array($grantslist[$type])) {
				ksort($grantslist[$type]);
				while (list($id, $grants)=each($grantslist[$type])) { // path was login en is weer login
					$grant_string = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
					if (!$ARCurrent->donelist[$type][$id]) {
						$ARCurrent->donelist[$type][$id]=true;
						$row_id = "grants-$type-$id";
						$row_class = getClass($grey);
						$path = getPathByType($type, $id);
						$grant_strings = getGrantString($id, $type, $grants, $grey);
						$grant_string = $grant_strings[0];
						$grant_html = $grant_strings[1];
						$icon = $AR->dir->images . "icons/small/" . $type . ".png";

						?>
						<script type="text/javascript">
							id2path['<?php echo $type; ?>']['<?php echo $id; ?>'] = '<?php echo $path; ?>';
							grant_strings['<?php echo $type; ?>']['<?php echo $id; ?>']='<?php echo $grant_string; ?>';
						</script>
						<tr class='<?php echo $row_class; ?>' id="<?php echo $row_id; ?>">
							<td>
								<img alt="<?php echo $type; ?>" src="<?php echo $icon; ?>">
							</td>
							<td>
								<a href="javascript:loadUser('<?php echo $type; ?>', '<?php echo $id; ?>');"><?php echo $id; ?></a>
							</td>
							<td>
								<?php echo $grant_html; ?>
							</td>
						</tr>
						<?php
					}
				}
			}
		}
	}
?>


Issues (1751)

Security Analysis not enabled

lib/templates/pobject/dialog.grants.logic.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		$userConfig = $this->loadUserConfig();
3		$authconfig = $userConfig['authentication'];
4
5		if( !function_exists("grantsArrayToString") ) {
6		function grantsArrayToString($grants) {
7		$grantstring = "";
8		if (is_array($grants)) {
9		foreach ($grants as $grant => $granttype) {
10		if (is_array($granttype)) {
11		$grantstring .= " $grant ( ";
12		reset($granttype);
13		while (list($class, $modifierId)=each($granttype)) {
14	View Code Duplication	if( $granttype > 0 ) {
15		switch($modifierId) {
16		case ARGRANTLOCAL:
17		$modifier = "=";
18		break;
19		case ARGRANTCHILDREN:
20		$modifier = ">";
21		break;
22		default:
23		$modifier = "";
24		}
25		$grantstring .= " $modifier$class ";
26		}
27		}
28		$grantstring .= " ) ";
29	View Code Duplication	} elseif( $granttype > 0 ) {
30		switch($granttype) {
31		case ARGRANTLOCAL:
32		$modifier = "=";
33		break;
34		case ARGRANTCHILDREN:
35		$modifier = ">";
36		break;
37		default:
38		$modifier = "";
39		}
40		$grantstring .= " $modifier$grant ";
41		}
42		}
43		}
44		return $grantstring;
45		}
46		}
47
48		if( !function_exists("arGetGrantType") ) {
49		function arGetGrantType($value) {
50		if (($value & ARMASKLOCAL) && ($value & ARMASKCHILDREN)) {
51		$result="";
52		} else if ($value & ARMASKLOCAL) {
53		$result="=";
54		} else {
55		$result=">";
56		}
57		return $result;
58		}
59		}
60
61		if( !function_exists("array_compare") ) {
62		function array_compare(&$ar1, &$ar2) {
63		if (count($ar1) != count($ar2)) {
64		return false;
65		} else {
66		foreach ($ar1 as $key => $value) {
67		if (is_array($value) && is_array($ar2[$key])) {
68		return array_compare($ar1[$key], $ar2[$key]);
69		} else
70		if ($value !== $ar2[$key]) {
71		return false;
72		}
73		return true;
74		}
75		}
76		}
77		}
78
79		if( !function_exists("getClass") ) {
80		function getClass($grey=false) {
81		global $ARCurrent;
82		if ($ARCurrent->oddline=($ARCurrent->oddline+1)%2) {
83		$class='odd';
84		} else {
85		$class='even';
86		}
87		if ($grey) {
88		$class .= '-grey';
89		}
90		return $class;
91		}
92		}
93
94		if( !function_exists("getPathByType") ) {
95		function getPathByType($type, $id) {
96		global $AR;
97		switch ($type) {
98		case 'pgroup':
99	View Code Duplication	foreach ($authconfig['groupdirs'] as $groupdir) {
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$authconfig` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
100		$path = current($AR->user->find($groupdir, 'login.value=\''.$id.'\'', 'system.get.path.phtml'));
101		if ($path) {
102		break;
103		}
104		}
105		break;
106		case 'puser':
107	View Code Duplication	foreach ($authconfig['userdirs'] as $userdir) {
108		$path = current($AR->user->find($userdir, 'login.value=\''.$id.'\'', 'system.get.path.phtml'));
109		if ($path) {
110		break;
111		}
112		}
113		break;
114		}
115		return $path;
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$path` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
116		}
117		}
118
119		if( !function_exists("removeSimilarGrants") ) {
120		function removeSimilarGrants($grants) {
121		// first check for similar grants (same modifiers)
122		$grants_check = $grants;
123		foreach ($grants as $grant => $grant_ar) {
124		// loop $grants for each entry in $grants_check (which is a copy)
125		array_shift($grants_check);
126		if (is_array($grant_ar)) {
127		foreach ($grants_check as $grant_c => $grant_ar_c) {
128		if (is_array($grant_ar_c) && array_compare($grant_ar, $grant_ar_c)) {
129		unset($grants[$grant_c]);
130		}
131		}
132		}
133		}
134		reset($grants);
135		ksort($grants);
136		return $grants;
137		}
138		}
139
140		if( !function_exists("getGrantString") ) {
141		function getGrantString($id, $type, $grants, $grey) {
142		if ($grants && is_array($grants)) {
143		$grants = removeSimilarGrants($grants);
144		$grant_display = '';
145		$grant_string = '';
146
147		foreach ($grants as $grant => $modifiers) {
148		if (!is_array($modifiers)) {
149		$grant_type=arGetGrantType($modifiers);
150		$grant_display .= htmlspecialchars($grant_type); // echo
151		} else {
152		$grant_type='';
153		}
154
155		if (!$grey) {
156		$grant_display .= "<a href=\"javascript:selectGrant('$type', '$id', '$grant');\">";
157		} else {
158		$grant_display .= "<span class='grey'>";
159		}
160
161		$grant_display .= $grant;
162		if (is_array($grants_eq[$grant])) {
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$grants_eq` does not exist. Did you mean `$grants`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
163		foreach ($grants_eq[$grant] as $g_add) {
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$grants_eq` does not exist. Did you mean `$grants`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
164		$grant .= ", ".$grant_type."$g_add";
165		}
166		$grant_display .= "[$grant]";
167		$grant_string .= "[$grant]";
168		} else {
169		$grant_string .= "$grant_type$grant ";
170		}
171		if (is_array($modifiers)) {
172		$grant_string .= "( ";
173		$grant_display .= "( ";
174		foreach ($modifiers as $modifier => $value) {
175		$grant_type=arGetGrantType($value);
176		$grant_display .= htmlspecialchars($grant_type);
177		$grant_display .= $modifier." ";
178		$grant_string .= $grant_type.$modifier." ";
179		}
180		$grant_display .= ") ";
181		$grant_string .= ") ";
182		}
183		if (!$grey) {
184		$grant_display .= "</a>";
185		} else {
186		$grant_display .= "</span>";
187		}
188		}
189		$grant_display .= " ";
190		$grant_string .= " ";
191		}
192		return array($grant_string, $grant_display);
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$grant_string` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$grant_display` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
193		}
194		}
195
196		if( !function_exists("DisplayGrants") ) {
197		function DisplayGrants(&$grantslist, $type, $grey=false) {
198		global $AR, $ARCurrent;
199		if ($grantslist[$type] && is_array($grantslist[$type])) {
200		ksort($grantslist[$type]);
201		while (list($id, $grants)=each($grantslist[$type])) { // path was login en is weer login
202		$grant_string = "";
		0 ignored issues – show Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$grant_string` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
203		if (!$ARCurrent->donelist[$type][$id]) {
204		$ARCurrent->donelist[$type][$id]=true;
205		$row_id = "grants-$type-$id";
206		$row_class = getClass($grey);
207		$path = getPathByType($type, $id);
208		$grant_strings = getGrantString($id, $type, $grants, $grey);
209		$grant_string = $grant_strings[0];
210		$grant_html = $grant_strings[1];
211		$icon = $AR->dir->images . "icons/small/" . $type . ".png";
212
213		?>
214		<script type="text/javascript">
215		id2path['<?php echo $type; ?>']['<?php echo $id; ?>'] = '<?php echo $path; ?>';
216		grant_strings['<?php echo $type; ?>']['<?php echo $id; ?>']='<?php echo $grant_string; ?>';
217		</script>
218		<tr class='<?php echo $row_class; ?>' id="<?php echo $row_id; ?>">
219		<td>
220		<img alt="<?php echo $type; ?>" src="<?php echo $icon; ?>">
221		</td>
222		<td>
223		<a href="javascript:loadUser('<?php echo $type; ?>', '<?php echo $id; ?>');"><?php echo $id; ?></a>
224		</td>
225		<td>
226		<?php echo $grant_html; ?>
227		</td>
228		</tr>
229		<?php
230		}
231		}
232		}
233		}
234		}
235		?>
236

Ariadne-CMS / ariadne

Issues (1751)

Security Analysis not enabled

lib/templates/pobject/dialog.grants.logic.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like