Issues in mod_stats.php (master) - Issues in master - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1751)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/modules/mod_stats.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


    /******************************************************************
     mod_stats.php                                         Muze Ariadne
     ------------------------------------------------------------------
     Author: Florian Overkamp ([email protected])
     Date: 4 february 2003

     Copyright 2003 ObSimRef and Muze

     This file is part of Ariadne.

     Ariadne is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published
     by the Free Software Foundation; either version 2 of the License,
     or (at your option) any later version.

     Ariadne is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.

     You should have received a copy of the GNU General Public License
     along with Ariadne; if not, write to the Free Software
     Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
     02111-1307  USA

    -------------------------------------------------------------------

     Description:

	   This module calls the stats tools with the given
	   options.

    ******************************************************************/

 	$StatsSupportedTools = "phpOpenTracker";

	class stats {


		function log() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			// all info is gathered from the php/webserver environment
			global $AR, $StatsSupportedTools;
			global $path;

			if($AR->Stats->makestats && (stristr($StatsSupportedTools, $AR->Stats->tool)!=false)) {

				// Go Go Go
				$client_id = $_SERVER[$AR->Stats->clientvar];
				$referer =  $_SERVER['HTTP_REFERER'];

				//$cookie=ldGetCredentials();
				//$username = $cookie[$ARCurrent->session->id]['login'];

				// log the entry if there is a CLIENT_ID
				if((isset($client_id)) || (!$AR->Stats->logdefault)) {
					// Take logdefault if there is no CLIENT_ID

					// Mangle the path (adjust to your own taste)
					$logpath = $path;
					$proceed = true;

					// Small tests for stuff we never want to log (i.e. access to /system/)
					// set $proceed to false if you wish to skip this log
					if(is_array($AR->Stats->ignore)) {
						foreach($AR->Stats->ignore as $ignorepath) {
							if(substr($logpath, 0, strlen($ignorepath)) == $ignorepath) $proceed = false;
							// path may contain NLS data
							if(substr($logpath, 3, strlen($ignorepath)) == $ignorepath) $proceed = false;
						}
					}

					if($proceed) {
						// Do the logging
						debug ("mod_stats::log: path = $logpath", "class");
						switch($AR->Stats->tool) {
       	                        			case "phpOpenTracker":	$this->opentrackerlog($logpath, $referer, $client_id);
						}
					} else {
						debug ("mod_stats::log: path NOT logged ($logpath)", "class");
					}
				}
			}
		}

//
// All function below are tool-specific
//

		function opentrackerlog($logpath, $referer, $client_id) {
			// opentracker specific
			global $AR;

			// phpOpenTracker User Tracking
			require_once($AR->Stats->path);
			debug ("mod_stats::opentrackerlog: logging $logpath to phpOpenTracker", "class");
			// log the visitor
			if($client_id != "") {
				debug ("mod_stats::opentrackerlog: client_id = $client_id", "class");
				@phpOpenTracker::log( Array(
					'document' => $logpath,
					'referer' => $referer,
					'client_id' => $client_id)
				);
			} else {
				debug ("mod_stats::opentrackerlog: logging without client_id", "class");
				@phpOpenTracker::log( Array(
					'document' => $logpath,
					'referer' => $referer)
				);
			}
			// ---
		}

		// Class end
	}


1			<?php
2
3
4			/******************************************************************
5			mod_stats.php Muze Ariadne
6			------------------------------------------------------------------
7			Author: Florian Overkamp ([email protected])
8			Date: 4 february 2003
9
10			Copyright 2003 ObSimRef and Muze
11
12			This file is part of Ariadne.
13
14			Ariadne is free software; you can redistribute it and/or modify
15			it under the terms of the GNU General Public License as published
16			by the Free Software Foundation; either version 2 of the License,
17			or (at your option) any later version.
18
19			Ariadne is distributed in the hope that it will be useful,
20			but WITHOUT ANY WARRANTY; without even the implied warranty of
21			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
22			GNU General Public License for more details.
23
24			You should have received a copy of the GNU General Public License
25			along with Ariadne; if not, write to the Free Software
26			Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
27			02111-1307 USA
28
29			-------------------------------------------------------------------
30
31			Description:
32
33			This module calls the stats tools with the given
34			options.
35
36			******************************************************************/
37
38			$StatsSupportedTools = "phpOpenTracker";
39
40			class stats {
41
42
43			function log() {
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC Report Bug Copy Issue Report Show Similar Issues like this `log` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
44			// all info is gathered from the php/webserver environment
45			global $AR, $StatsSupportedTools;
46			global $path;
47
48			if($AR->Stats->makestats && (stristr($StatsSupportedTools, $AR->Stats->tool)!=false)) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-26 08:52 UTC Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `stristr($StatsSupportedTools, $AR->Stats->tool)` of type `string` to the boolean `false`. If you are specifically checking for a non-empty string, consider using the more explicit `!== ''` instead. Loading history...
49			// Go Go Go
50			$client_id = $_SERVER[$AR->Stats->clientvar];
51			$referer = $_SERVER['HTTP_REFERER'];
52
53			//$cookie=ldGetCredentials();
54			//$username = $cookie[$ARCurrent->session->id]['login'];
55
56			// log the entry if there is a CLIENT_ID
57			if((isset($client_id)) \|\| (!$AR->Stats->logdefault)) {
58			// Take logdefault if there is no CLIENT_ID
59
60			// Mangle the path (adjust to your own taste)
61			$logpath = $path;
62			$proceed = true;
63
64			// Small tests for stuff we never want to log (i.e. access to /system/)
65			// set $proceed to false if you wish to skip this log
66			if(is_array($AR->Stats->ignore)) {
67			foreach($AR->Stats->ignore as $ignorepath) {
68			if(substr($logpath, 0, strlen($ignorepath)) == $ignorepath) $proceed = false;
69			// path may contain NLS data
70			if(substr($logpath, 3, strlen($ignorepath)) == $ignorepath) $proceed = false;
71			}
72			}
73
74			if($proceed) {
75			// Do the logging
76			debug ("mod_stats::log: path = $logpath", "class");
77			switch($AR->Stats->tool) {
78			case "phpOpenTracker": $this->opentrackerlog($logpath, $referer, $client_id);
79			}
80			} else {
81			debug ("mod_stats::log: path NOT logged ($logpath)", "class");
82			}
83			}
84			}
85			}
86
87			//
88			// All function below are tool-specific
89			//
90
91			function opentrackerlog($logpath, $referer, $client_id) {
92			// opentracker specific
93			global $AR;
94
95			// phpOpenTracker User Tracking
96			require_once($AR->Stats->path);
97			debug ("mod_stats::opentrackerlog: logging $logpath to phpOpenTracker", "class");
98			// log the visitor
99			if($client_id != "") {
100			debug ("mod_stats::opentrackerlog: client_id = $client_id", "class");
101			@phpOpenTracker::log( Array(
102			'document' => $logpath,
103			'referer' => $referer,
104			'client_id' => $client_id)
105			);
106			} else {
107			debug ("mod_stats::opentrackerlog: logging without client_id", "class");
108			@phpOpenTracker::log( Array(
109			'document' => $logpath,
110			'referer' => $referer)
111			);
112			}
113			// ---
114			}
115
116			// Class end
117			}
118

Ariadne-CMS / ariadne

Issues (1751)

Security Analysis not enabled

lib/modules/mod_stats.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like