Issues in mod_grant.php (master) - Issues in master - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1751)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/modules/mod_grant.php (15 issues)

Labels

Severity

Major 15

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
	define("T_G_IDENT",		253);

	class mod_grant {
		function get_token() {
			$this->token = $this->token_ahead;
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->token_value = $this->token_ahead_value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->input = preg_replace('/^([[:space:]]|,)*/', '', $this->input);
class MyClass { }

$x = new MyClass();
$x->foo = true;
			//echo "scanner: input(".$this->input.")<br>\n";
			switch (true) {

				case preg_match('/^([a-zA-Z0-9_][a-zA-Z0-9._:]*)/', $this->input, $regs):
					$this->token_ahead = T_G_IDENT;
					$this->token_ahead_value = $regs[1];
function someFunction() {
    $x = 5;
    echo $x;
}
					$this->input = substr($this->input, strlen($regs[1]));
function someFunction() {
    $x = 5;
    echo $x;
}
				break;
				case preg_match('/^([]+->=(){}[])/', $this->input, $regs):
					$this->token_ahead = $regs[1];
function someFunction() {
    $x = 5;
    echo $x;
}
					$this->token_ahead_value = $regs[1];
function someFunction() {
    $x = 5;
    echo $x;
}
					$this->input = substr($this->input, 1);
				break;
				default:
					$this->token_ahead = 0;
					$this->token_ahead_value = '';

			}
			//echo "scanner:: (".$this->token_ahead.") (".$this->token_ahead_value.")<br>\n";
			return $this->token_ahead;
		}

		function parse_stmt(&$grants) {
			$g_array = Array();
			switch ($this->token_ahead) {
				case '-':
					$g_op = '-';
					$this->get_token();
				break;
				case '+':
					$this->get_token();
				default:
					$g_op = '+';
			}

			switch ($this->token_ahead) {
				case '>':
					$g_val = ARGRANTCHILDREN;
					$this->get_token();
				break;
				case '=':
					$g_val = ARGRANTLOCAL;
					$this->get_token();
				break;
				default:
					$g_val = ARGRANTGLOBAL;
			}

			if ($this->token_ahead === '[') {
				$this->get_token();
					while ($this->token_ahead === T_G_IDENT) {
						$this->get_token();
						$g_array[$this->token_value] = $g_val;
					}
				if (!$this->token_ahead === ']') {
					$this->error = 'expected ]';
class MyClass { }

$x = new MyClass();
$x->foo = true;
					return 0;
				}
				$this->get_token();
			} else
			if ($this->token_ahead === T_G_IDENT) {
				$this->get_token();
				$g_array[$this->token_value] = $g_val;
			} else {
				return 0;
			}

			$m_array = Array();

			/* parse modifiers */
			if ($this->token_ahead === '(') {
				$this->get_token();
				do {
					switch ($this->token_ahead) {
						case '>':
							$m_val = ARGRANTCHILDREN;
							$this->get_token();
						break;
						case '=':
							$m_val = ARGRANTLOCAL;
							$this->get_token();
						break;
						default:
							$m_val = $g_val;
					}
					if ($this->token_ahead != T_G_IDENT) {
						$this->error = 'expected modifier near: '.$this->input;
						return 0;
					}
					$this->get_token();
					$m_array[$this->token_value] = $m_val;
				} while ($this->token_ahead && $this->token_ahead != ')');

				if ($this->token_ahead != ')') {
					$this->error = 'modifier list is not closed';
					return 0;
				}
				$this->get_token();

				foreach($g_array as $grant => $g_val) {
					$g_array[$grant] = $m_array;
				}
			}

			foreach($g_array as $grant => $g_val) {
				if ($g_op === '-') {
					unset($grants[$grant]);
				} else {
					$grants[$grant] = $g_val;
				}
			}
			return 1;
		}

		function compile($input, &$grants) {
			$this->input = $input;
			$this->get_token();
			while (!$this->error && $this->parse_stmt($grants));
			ksort($grants);
			foreach( $grants as $key => $value ) {
				if( is_array($value) ) {
					ksort($grants[$key]);
				}
			}
		}
	}


1		<?php
2		define("T_G_IDENT", 253);
3
4		class mod_grant {
5		function get_token() {
6		$this->token = $this->token_ahead;
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_ahead` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
7		$this->token_value = $this->token_ahead_value;
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_value` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_ahead_value` does not seem to exist. Did you mean `token_ahead`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
8		$this->input = preg_replace('/^([[:space:]]\|,)*/', '', $this->input);
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `input` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
9		//echo "scanner: input(".$this->input.")<br>\n";
10		switch (true) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `preg_match('/^([a-zA-Z0-...', $this->input, $regs)` of type `integer` to the boolean `true`. If you are specifically checking for non-zero, consider using something more explicit like `> 0` or `!== 0` instead. Loading history... Bug Best Practice introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `preg_match('/^([]+->=(){...', $this->input, $regs)` of type `integer` to the boolean `true`. If you are specifically checking for non-zero, consider using something more explicit like `> 0` or `!== 0` instead. Loading history...
11	View Code Duplication	case preg_match('/^([a-zA-Z0-9_][a-zA-Z0-9._:]*)/', $this->input, $regs):
12		$this->token_ahead = T_G_IDENT;
13		$this->token_ahead_value = $regs[1];
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_ahead_value` does not seem to exist. Did you mean `token_ahead`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$regs` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
14		$this->input = substr($this->input, strlen($regs[1]));
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$regs` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
15		break;
16	View Code Duplication	case preg_match('/^([]+->=(){}[])/', $this->input, $regs):
17		$this->token_ahead = $regs[1];
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$regs` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
18		$this->token_ahead_value = $regs[1];
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_ahead_value` does not seem to exist. Did you mean `token_ahead`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$regs` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
19		$this->input = substr($this->input, 1);
20		break;
21		default:
22		$this->token_ahead = 0;
23		$this->token_ahead_value = '';
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `token_ahead_value` does not seem to exist. Did you mean `token_ahead`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
24		}
25		//echo "scanner:: (".$this->token_ahead.") (".$this->token_ahead_value.")<br>\n";
26		return $this->token_ahead;
27		}
28
29		function parse_stmt(&$grants) {
30		$g_array = Array();
31		switch ($this->token_ahead) {
32		case '-':
33		$g_op = '-';
34		$this->get_token();
35		break;
36		case '+':
37		$this->get_token();
38		default:
39		$g_op = '+';
40		}
41
42	View Code Duplication	switch ($this->token_ahead) {
43		case '>':
44		$g_val = ARGRANTCHILDREN;
45		$this->get_token();
46		break;
47		case '=':
48		$g_val = ARGRANTLOCAL;
49		$this->get_token();
50		break;
51		default:
52		$g_val = ARGRANTGLOBAL;
53		}
54
55		if ($this->token_ahead === '[') {
56		$this->get_token();
57		while ($this->token_ahead === T_G_IDENT) {
58		$this->get_token();
59		$g_array[$this->token_value] = $g_val;
60		}
61		if (!$this->token_ahead === ']') {
62		$this->error = 'expected ]';
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `error` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63		return 0;
64		}
65		$this->get_token();
66		} else
67		if ($this->token_ahead === T_G_IDENT) {
68		$this->get_token();
69		$g_array[$this->token_value] = $g_val;
70		} else {
71		return 0;
72		}
73
74		$m_array = Array();
75
76		/* parse modifiers */
77		if ($this->token_ahead === '(') {
78		$this->get_token();
79		do {
80	View Code Duplication	switch ($this->token_ahead) {
81		case '>':
82		$m_val = ARGRANTCHILDREN;
83		$this->get_token();
84		break;
85		case '=':
86		$m_val = ARGRANTLOCAL;
87		$this->get_token();
88		break;
89		default:
90		$m_val = $g_val;
91		}
92		if ($this->token_ahead != T_G_IDENT) {
93		$this->error = 'expected modifier near: '.$this->input;
94		return 0;
95		}
96		$this->get_token();
97		$m_array[$this->token_value] = $m_val;
98		} while ($this->token_ahead && $this->token_ahead != ')');
99
100		if ($this->token_ahead != ')') {
101		$this->error = 'modifier list is not closed';
102		return 0;
103		}
104		$this->get_token();
105
106		foreach($g_array as $grant => $g_val) {
107		$g_array[$grant] = $m_array;
108		}
109		}
110
111		foreach($g_array as $grant => $g_val) {
112		if ($g_op === '-') {
113		unset($grants[$grant]);
114		} else {
115		$grants[$grant] = $g_val;
116		}
117		}
118		return 1;
119		}
120
121		function compile($input, &$grants) {
122		$this->input = $input;
123		$this->get_token();
124		while (!$this->error && $this->parse_stmt($grants));
125		ksort($grants);
126		foreach( $grants as $key => $value ) {
127		if( is_array($value) ) {
128		ksort($grants[$key]);
129		}
130		}
131		}
132		}
133

Ariadne-CMS / ariadne

Issues (1751)

Security Analysis not enabled

lib/modules/mod_grant.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like