Issues in zen.php (master) - Issues in master - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1751)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/ar/html/zen.php (12 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

	ar_pinp::allow( 'ar_html_zen' );

	class ar_html_zen extends ar_htmlNodes {

		const T_EOF                 = 0;
		const T_IDENT               = 1;
		const T_NUMBER              = 2;
		const T_PLACEHOLDER         = 3;
		const T_EXPRESSION_OPEN     = 4;
		const T_EXPRESSION_CLOSE    = 5;

		const T_OP_ATTRIBUTES_OPEN  = 6;
		const T_OP_ATTRIBUTES_CLOSE = 7;
		const T_OP_FILTER           = 8;
		const T_OP_MULTIPLIER       = 9;
		const T_OP_ASSIGN           = 11;
		const T_OP_ID               = 12;
		const T_OP_CLASS            = 13;
		const T_OP_CHILDREN         = 14;
		const T_OP_SIBLINGS         = 15;
		const T_OP_SETTING          = 16;

		public function __construct( $string ) {
			$parser = new ar_html_zenParser($string);
			$nodes = $parser->run();
			parent::__construct( (array)$this->compileNodes($nodes) );
		}

		private function compileNodes($nodes, $childNodes = null) {
			if( !isset($childNodes) ) {
				$childNodes = ar_html::nodes();
			}
			if( isset($nodes["children"]) ) {
				$childNodes = $this->compileNodes($nodes["children"], $childNodes);
			}
			unset($nodes["children"]);
			$result = array();
			$mult = 1;
			if( isset($nodes["multiplier"]) ) {
				$mult = (int)$nodes["multiplier"];
				unset($nodes["multiplier"]);
			}
			for($i=0;$i<$mult;$i++) {
				foreach( $nodes as $key => $value ) {
					if( $value["tagName"] ) {
						$tmult = 1;
						if( isset($value["multiplier"]) ) {
							$tmult = (int)$value["multiplier"];
						}
						for($j=0;$j<$tmult;$j++) {
							$result[] = ar_html::tag( $value["tagName"], $value["attributes"], $childNodes->cloneNode(true));
						}
					} else {
						$result = array_merge($result, (array)$this->compileNodes($value, $childNodes));
					}
				}
			}
			return ar_html::nodes($result);
		}
	}

	class ar_html_zenScanner {
		protected $YYLINE;
		protected $YYBUFFER;
		protected $YYCURSOR;
		protected $YYSTATE;

		protected $class_ident = array();
		protected $class_ident_next = array();
		protected $class_number = array();
		protected $class_whitespace = array();

		protected $tokens = array();

		public $token;
		public $token_value;
		public $token_ahead;
		public $token_ahead_value;


		function __construct($buffer) {
			$this->YYBUFFER = $buffer."\000";
			$this->YYLINE = 0;
			$this->YYCURSOR = 0;
			$this->YYSTATE = STATE_TEXT;


			// Identifiers [a-zA-Z]
			$class_ident_start = array();
			$start = ord('a');
			$end   = ord('z');
			for ($i = $start; $i <= $end; $i++) {
				$class_ident_start[chr($i)] = chr($i);
				$class_ident_start[strtoupper(chr($i))] = strtoupper(chr($i));
			}
			$this->class_ident = array_merge(array('-' => '-', '_' => '_'), $class_ident_start);
			$this->class_ident_start = $class_ident_start;

			// Numbers [0-9]
			$class_number = array();
			$start = ord('0');
			$end   = ord('9');
			for ($i = $start; $i <= $end; $i++) {
				$class_ident_next[chr($i)] = chr($i);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
				$class_number[chr($i)] = chr($i);
			}
			$this->class_number = $class_number;
			$this->class_ident = array_merge($this->class_ident, $class_ident_next);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			// Whitespace
			$class_whitespace = array(" " => " ", "\t" => "\t", "\r" => "\r", "\n" => "\n");
			$this->class_whitespace = $class_whitespace;
		}

		function next() {
			if (count($this->tokens) == 0) {
				$new_token = $this->scan($new_value);
			} else {
				$entry = array_shift($this->tokens);
				list($new_token, $new_value) = each($entry);
			}
			if (isset($this->token_ahead)) {
				$this->token = $this->token_ahead;
				$this->token_value = $this->token_ahead_value;
			}
			$this->token_ahead = $new_token;
			$this->token_ahead_value = $new_value;
			return $this->token;
		}


		function scan(&$value) {
			$YYCURSOR = &$this->YYCURSOR;
			$YYBUFFER = &$this->YYBUFFER;
			$yych = $YYBUFFER[$YYCURSOR];
			$token = "";

			do {
				switch (true) {
					case '"' === $yych:
					case "'" === $yych:
						$quote = $yych;
						$yych = $YYBUFFER[++$YYCURSOR];
						while ($yych !== "\000" && $yych !== $quote) {
							if ($yych == "\\") {
								$yych = $YYBUFFER[++$YYCURSOR];
								if ($yych !== $quote && $yych != "\\") {
									$value .= "\\";
								}
							}
							$value .= $yych;
							$yych = $YYBUFFER[++$YYCURSOR];
						}
						++$YYCURSOR;
						return ar_html_zen::T_IDENT;
					break;
					case '|' === $yych: ($token || $token = ar_html_zen::T_OP_FILTER);
					case '(' === $yych: ($token || $token = ar_html_zen::T_EXPRESSION_OPEN);
					case ')' === $yych: ($token || $token = ar_html_zen::T_EXPRESSION_CLOSE);
					case '*' === $yych: ($token || $token = ar_html_zen::T_OP_MULTIPLIER);
					case '+' === $yych: ($token || $token = ar_html_zen::T_OP_SIBLINGS);
					case '[' === $yych: ($token || $token = ar_html_zen::T_OP_ATTRIBUTES_OPEN);
					case ']' === $yych: ($token || $token = ar_html_zen::T_OP_ATTRIBUTES_CLOSE);
					case '=' === $yych: ($token || $token = ar_html_zen::T_OP_ASSIGN);
					case '$' === $yych: ($token || $token = ar_html_zen::T_PLACEHOLDER);
					case '>' === $yych: ($token || $token = ar_html_zen::T_OP_CHILDREN);
					case '.' === $yych: ($token || $token = ar_html_zen::T_OP_CLASS);
					case '#' === $yych: ($token || $token = ar_html_zen::T_OP_ID);
					case ':' === $yych: ($token || $token = ar_html_zen::T_OP_SETTING);
						$value = $yych;
						++$YYCURSOR;
						return $token;
					break;
					case $this->class_whitespace[$yych] === $yych:
						$yych = $YYBUFFER[++$YYCURSOR]; continue;
					break;
					case $this->class_number[$yych] === $yych:
						$value = "";
						while ($this->class_number[$yych] == $yych && ($yych != "\000")) {
							$value .= $yych;
							$yych = $YYBUFFER[++$YYCURSOR];
						}
						return ar_html_zen::T_NUMBER;
					break;
					case $this->class_ident_start[$yych] === $yych:

						$value = $yych;
						$yych = $YYBUFFER[++$YYCURSOR];
						while ($this->class_ident[$yych] == $yych && ($yych != "\000")) {
							$value .= $yych;
							$yych = $YYBUFFER[++$YYCURSOR];
						}
						return ar_html_zen::T_IDENT;
					break;
					case "\000" === $yych:
						$value = $yych;
						return ar_html_zen::T_EOF;
					break;
					default:
						$value = $yych;
						++$YYCURSOR;
						return $value;
					break;
				}
			} while(1);
		}
	}

	class ar_html_zenParser {
		protected $scanner;

		public function __construct($string) {
			$this->scanner = new ar_html_zenScanner($string);
			$this->scanner->next();
		}

		public function run() {
			$nodelist = $this->parse();
			return $nodelist;
		}

		private function parse() {
			$result = array();
			$result[] = $this->parseExpression();
			$bye = false;
			do {
				$token = $this->scanner->token_ahead;
				switch($token) {
					case ar_html_zen::T_OP_CHILDREN:
						$this->scanner->next();
						$result["children"] = $this->parse();
					break;
					case ar_html_zen::T_OP_SIBLINGS:
						$this->scanner->next();
						$result[] = $this->parseExpression();
					break;
					default:
						$bye = true;
					break;
				}
			} while( !$bye );
			return $result;
		}

		private function parseExpression() {
			$token = $this->scanner->token_ahead;
			switch( $token ) {
				case ar_html_zen::T_EXPRESSION_OPEN:
					$this->scanner->next();
					$result = $this->parse();
					if( $this->scanner->token_ahead != ar_html_zen::T_EXPRESSION_CLOSE ) {
						die("No closing ')' found for expression.");

					}
					$this->scanner->next();
				break;
				case ar_html_zen::T_IDENT:
					$tagName = $this->scanner->token_ahead_value;
					$result["tagName"] = $tagName;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					$this->scanner->next();
					$result["attributes"] = $this->parseAttributes();
				break;
			}
			$mult = $this->parseMultiplier();
			if( $mult ) {
				$result["multiplier"] = $mult;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
			return $result;
		}

		private function parseAttributes() {
			$bye = false;
			$result = array();
			do {
				$token = $this->scanner->token_ahead;
				$key = false;
				switch( $token ) {
					case ar_html_zen::T_OP_ID:
						$key = "id";
					case ar_html_zen::T_OP_CLASS:
						if( !$key ) { $key = "class"; }
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
						$this->scanner->next();
						if( $this->scanner->token_ahead == ar_html_zen::T_IDENT ) {
							$result[$key][] = $this->scanner->token_ahead_value;
							$this->scanner->next();
						} else {
							die('no ident found for attribute: '.$key);

						}
					break;
					case ar_html_zen::T_OP_ATTRIBUTES_OPEN:
						$this->scanner->next();
						$result = array_merge($result, $this->parseAttributeList() ); // FIXME: deep merge
						if( $this->scanner->token_ahead != ar_html_zen::T_OP_ATTRIBUTES_CLOSE ) {
							die("No attribute closing tag ']' found.");

						}
						$this->scanner->next();
					break;
					default:
						$bye = true;
					break;
				}
			} while( !$bye );
			return $result;
		}

		private function parseAttributeList() {
			$bye = false;
			$result = array();
			do {
				$token = $this->scanner->token_ahead;
				switch( $token ) {
					case ar_html_zen::T_IDENT:
						$attr = $this->scanner->token_ahead_value;
						$value = "";
						$this->scanner->next();
						if( $this->scanner->token_ahead == ar_html_zen::T_OP_ASSIGN ) {
							$this->scanner->next();
							if( $this->scanner->token_ahead != ar_html_zen::T_IDENT ) {
								die('Trying to assign empty attribute '.$this->scanner->token_ahead_value );

							}
							$value = $this->scanner->token_ahead_value;
							$this->scanner->next();
						}
						$result[$attr] = $value;
					break;
					default:
						$bye = true;
					break;
				}
			} while( !$bye );
			return $result;
		}

		private function parseMultiplier() {
			$token = $this->scanner->token_ahead;
			if( $token == ar_html_zen::T_OP_MULTIPLIER ) {
				$this->scanner->next();
				if( $this->scanner->token_ahead == ar_html_zen::T_NUMBER ) {
					$value = $this->scanner->token_ahead_value;
					$this->scanner->next();
					return $value;
				} else {
					die('Invalid multiplier found: '.$this->scanner->token_ahead_value);

				}
			}
			return false;
		}
	}


Issues (1751)

Security Analysis not enabled

lib/ar/html/zen.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1		<?php
2
3		ar_pinp::allow( 'ar_html_zen' );
4
5		class ar_html_zen extends ar_htmlNodes {
6
7		const T_EOF = 0;
8		const T_IDENT = 1;
9		const T_NUMBER = 2;
10		const T_PLACEHOLDER = 3;
11		const T_EXPRESSION_OPEN = 4;
12		const T_EXPRESSION_CLOSE = 5;
13
14		const T_OP_ATTRIBUTES_OPEN = 6;
15		const T_OP_ATTRIBUTES_CLOSE = 7;
16		const T_OP_FILTER = 8;
17		const T_OP_MULTIPLIER = 9;
18		const T_OP_ASSIGN = 11;
19		const T_OP_ID = 12;
20		const T_OP_CLASS = 13;
21		const T_OP_CHILDREN = 14;
22		const T_OP_SIBLINGS = 15;
23		const T_OP_SETTING = 16;
24
25		public function __construct( $string ) {
26		$parser = new ar_html_zenParser($string);
27		$nodes = $parser->run();
28		parent::__construct( (array)$this->compileNodes($nodes) );
29		}
30
31		private function compileNodes($nodes, $childNodes = null) {
32		if( !isset($childNodes) ) {
33		$childNodes = ar_html::nodes();
34		}
35		if( isset($nodes["children"]) ) {
36		$childNodes = $this->compileNodes($nodes["children"], $childNodes);
37		}
38		unset($nodes["children"]);
39		$result = array();
40		$mult = 1;
41		if( isset($nodes["multiplier"]) ) {
42		$mult = (int)$nodes["multiplier"];
43		unset($nodes["multiplier"]);
44		}
45		for($i=0;$i<$mult;$i++) {
46		foreach( $nodes as $key => $value ) {
47		if( $value["tagName"] ) {
48		$tmult = 1;
49		if( isset($value["multiplier"]) ) {
50		$tmult = (int)$value["multiplier"];
51		}
52		for($j=0;$j<$tmult;$j++) {
53		$result[] = ar_html::tag( $value["tagName"], $value["attributes"], $childNodes->cloneNode(true));
54		}
55		} else {
56		$result = array_merge($result, (array)$this->compileNodes($value, $childNodes));
57		}
58		}
59		}
60		return ar_html::nodes($result);
61		}
62		}
63
64		class ar_html_zenScanner {
65		protected $YYLINE;
66		protected $YYBUFFER;
67		protected $YYCURSOR;
68		protected $YYSTATE;
69
70		protected $class_ident = array();
71		protected $class_ident_next = array();
72		protected $class_number = array();
73		protected $class_whitespace = array();
74
75		protected $tokens = array();
76
77		public $token;
78		public $token_value;
79		public $token_ahead;
80		public $token_ahead_value;
81
82
83		function __construct($buffer) {
84		$this->YYBUFFER = $buffer."\000";
85		$this->YYLINE = 0;
86		$this->YYCURSOR = 0;
87		$this->YYSTATE = STATE_TEXT;
88
89
90		// Identifiers [a-zA-Z]
91		$class_ident_start = array();
92		$start = ord('a');
93		$end = ord('z');
94		for ($i = $start; $i <= $end; $i++) {
95		$class_ident_start[chr($i)] = chr($i);
96		$class_ident_start[strtoupper(chr($i))] = strtoupper(chr($i));
97		}
98		$this->class_ident = array_merge(array('-' => '-', '_' => '_'), $class_ident_start);
99		$this->class_ident_start = $class_ident_start;
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `class_ident_start` does not seem to exist. Did you mean `class_ident`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
100		// Numbers [0-9]
101		$class_number = array();
102		$start = ord('0');
103		$end = ord('9');
104	View Code Duplication	for ($i = $start; $i <= $end; $i++) {
105		$class_ident_next[chr($i)] = chr($i);
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$class_ident_next` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$class_ident_next = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
106		$class_number[chr($i)] = chr($i);
107		}
108		$this->class_number = $class_number;
109		$this->class_ident = array_merge($this->class_ident, $class_ident_next);
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$class_ident_next` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
110		// Whitespace
111		$class_whitespace = array(" " => " ", "\t" => "\t", "\r" => "\r", "\n" => "\n");
112		$this->class_whitespace = $class_whitespace;
113		}
114
115	View Code Duplication	function next() {
116		if (count($this->tokens) == 0) {
117		$new_token = $this->scan($new_value);
118		} else {
119		$entry = array_shift($this->tokens);
120		list($new_token, $new_value) = each($entry);
121		}
122		if (isset($this->token_ahead)) {
123		$this->token = $this->token_ahead;
124		$this->token_value = $this->token_ahead_value;
125		}
126		$this->token_ahead = $new_token;
127		$this->token_ahead_value = $new_value;
128		return $this->token;
129		}
130
131
132		function scan(&$value) {
133		$YYCURSOR = &$this->YYCURSOR;
134		$YYBUFFER = &$this->YYBUFFER;
135		$yych = $YYBUFFER[$YYCURSOR];
136		$token = "";
137
138		do {
139		switch (true) {
140		case '"' === $yych:
141	View Code Duplication	case "'" === $yych:
142		$quote = $yych;
143		$yych = $YYBUFFER[++$YYCURSOR];
144		while ($yych !== "\000" && $yych !== $quote) {
145		if ($yych == "\\") {
146		$yych = $YYBUFFER[++$YYCURSOR];
147		if ($yych !== $quote && $yych != "\\") {
148		$value .= "\\";
149		}
150		}
151		$value .= $yych;
152		$yych = $YYBUFFER[++$YYCURSOR];
153		}
154		++$YYCURSOR;
155		return ar_html_zen::T_IDENT;
156		break;
157		case '\|' === $yych: ($token \|\| $token = ar_html_zen::T_OP_FILTER);
158		case '(' === $yych: ($token \|\| $token = ar_html_zen::T_EXPRESSION_OPEN);
159		case ')' === $yych: ($token \|\| $token = ar_html_zen::T_EXPRESSION_CLOSE);
160		case '*' === $yych: ($token \|\| $token = ar_html_zen::T_OP_MULTIPLIER);
161		case '+' === $yych: ($token \|\| $token = ar_html_zen::T_OP_SIBLINGS);
162		case '[' === $yych: ($token \|\| $token = ar_html_zen::T_OP_ATTRIBUTES_OPEN);
163		case ']' === $yych: ($token \|\| $token = ar_html_zen::T_OP_ATTRIBUTES_CLOSE);
164		case '=' === $yych: ($token \|\| $token = ar_html_zen::T_OP_ASSIGN);
165		case '$' === $yych: ($token \|\| $token = ar_html_zen::T_PLACEHOLDER);
166		case '>' === $yych: ($token \|\| $token = ar_html_zen::T_OP_CHILDREN);
167		case '.' === $yych: ($token \|\| $token = ar_html_zen::T_OP_CLASS);
168		case '#' === $yych: ($token \|\| $token = ar_html_zen::T_OP_ID);
169		case ':' === $yych: ($token \|\| $token = ar_html_zen::T_OP_SETTING);
170		$value = $yych;
171		++$YYCURSOR;
172		return $token;
173		break;
174		case $this->class_whitespace[$yych] === $yych:
175		$yych = $YYBUFFER[++$YYCURSOR]; continue;
176		break;
177	View Code Duplication	case $this->class_number[$yych] === $yych:
178		$value = "";
179		while ($this->class_number[$yych] == $yych && ($yych != "\000")) {
180		$value .= $yych;
181		$yych = $YYBUFFER[++$YYCURSOR];
182		}
183		return ar_html_zen::T_NUMBER;
184		break;
185		case $this->class_ident_start[$yych] === $yych:
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `class_ident_start` does not seem to exist. Did you mean `class_ident`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
186		$value = $yych;
187		$yych = $YYBUFFER[++$YYCURSOR];
188		while ($this->class_ident[$yych] == $yych && ($yych != "\000")) {
189		$value .= $yych;
190		$yych = $YYBUFFER[++$YYCURSOR];
191		}
192		return ar_html_zen::T_IDENT;
193		break;
194		case "\000" === $yych:
195		$value = $yych;
196		return ar_html_zen::T_EOF;
197		break;
198		default:
199		$value = $yych;
200		++$YYCURSOR;
201		return $value;
202		break;
203		}
204		} while(1);
205		}
206		}
207
208		class ar_html_zenParser {
209		protected $scanner;
210
211		public function __construct($string) {
212		$this->scanner = new ar_html_zenScanner($string);
213		$this->scanner->next();
214		}
215
216		public function run() {
217		$nodelist = $this->parse();
218		return $nodelist;
219		}
220
221		private function parse() {
222		$result = array();
223		$result[] = $this->parseExpression();
224		$bye = false;
225		do {
226		$token = $this->scanner->token_ahead;
227		switch($token) {
228		case ar_html_zen::T_OP_CHILDREN:
229		$this->scanner->next();
230		$result["children"] = $this->parse();
231		break;
232		case ar_html_zen::T_OP_SIBLINGS:
233		$this->scanner->next();
234		$result[] = $this->parseExpression();
235		break;
236		default:
237		$bye = true;
238		break;
239		}
240		} while( !$bye );
241		return $result;
242		}
243
244		private function parseExpression() {
245		$token = $this->scanner->token_ahead;
246		switch( $token ) {
247	View Code Duplication	case ar_html_zen::T_EXPRESSION_OPEN:
248		$this->scanner->next();
249		$result = $this->parse();
250		if( $this->scanner->token_ahead != ar_html_zen::T_EXPRESSION_CLOSE ) {
251		die("No closing ')' found for expression.");
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `parseExpression()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
252		}
253		$this->scanner->next();
254		break;
255		case ar_html_zen::T_IDENT:
256		$tagName = $this->scanner->token_ahead_value;
257		$result["tagName"] = $tagName;
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
258		$this->scanner->next();
259		$result["attributes"] = $this->parseAttributes();
260		break;
261		}
262		$mult = $this->parseMultiplier();
263		if( $mult ) {
264		$result["multiplier"] = $mult;
		0 ignored issues – show Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
265		}
266		return $result;
267		}
268
269		private function parseAttributes() {
270		$bye = false;
271		$result = array();
272		do {
273		$token = $this->scanner->token_ahead;
274		$key = false;
275		switch( $token ) {
276		case ar_html_zen::T_OP_ID:
277		$key = "id";
278		case ar_html_zen::T_OP_CLASS:
279		if( !$key ) { $key = "class"; }
		0 ignored issues – show Bug Best Practice introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$key` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
280		$this->scanner->next();
281		if( $this->scanner->token_ahead == ar_html_zen::T_IDENT ) {
282		$result[$key][] = $this->scanner->token_ahead_value;
283		$this->scanner->next();
284		} else {
285		die('no ident found for attribute: '.$key);
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `parseAttributes()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
286		}
287		break;
288	View Code Duplication	case ar_html_zen::T_OP_ATTRIBUTES_OPEN:
289		$this->scanner->next();
290		$result = array_merge($result, $this->parseAttributeList() ); // FIXME: deep merge
291		if( $this->scanner->token_ahead != ar_html_zen::T_OP_ATTRIBUTES_CLOSE ) {
292		die("No attribute closing tag ']' found.");
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `parseAttributes()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
293		}
294		$this->scanner->next();
295		break;
296		default:
297		$bye = true;
298		break;
299		}
300		} while( !$bye );
301		return $result;
302		}
303
304		private function parseAttributeList() {
305		$bye = false;
306		$result = array();
307		do {
308		$token = $this->scanner->token_ahead;
309		switch( $token ) {
310		case ar_html_zen::T_IDENT:
311		$attr = $this->scanner->token_ahead_value;
312		$value = "";
313		$this->scanner->next();
314		if( $this->scanner->token_ahead == ar_html_zen::T_OP_ASSIGN ) {
315		$this->scanner->next();
316		if( $this->scanner->token_ahead != ar_html_zen::T_IDENT ) {
317		die('Trying to assign empty attribute '.$this->scanner->token_ahead_value );
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `parseAttributeList()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
318		}
319		$value = $this->scanner->token_ahead_value;
320		$this->scanner->next();
321		}
322		$result[$attr] = $value;
323		break;
324		default:
325		$bye = true;
326		break;
327		}
328		} while( !$bye );
329		return $result;
330		}
331
332		private function parseMultiplier() {
333		$token = $this->scanner->token_ahead;
334		if( $token == ar_html_zen::T_OP_MULTIPLIER ) {
335		$this->scanner->next();
336		if( $this->scanner->token_ahead == ar_html_zen::T_NUMBER ) {
337		$value = $this->scanner->token_ahead_value;
338		$this->scanner->next();
339		return $value;
340		} else {
341		die('Invalid multiplier found: '.$this->scanner->token_ahead_value);
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `parseMultiplier()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
342		}
343		}
344		return false;
345		}
346		}
347

Ariadne-CMS / ariadne

Issues (1751)

Security Analysis not enabled

lib/ar/html/zen.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like