Issues in twitter.php (master) - Issues in master - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1751)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/ar/connect/twitter.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

ar_pinp::allow('ar_connect_twitter');
ar_pinp::allow('ar_connect_twitterClient');

class ar_connect_twitter extends arBase {

	public static function client( $httpClient = null ) {
		return new ar_connect_twitterClient( $httpClient );
	}

	public static function parse( $text, $parseTwitterLinks = true ) {
		// FIXME: allow normal links and mailto links to be specified like the user and argument links
		// link URLs
		$text = " ".preg_replace(
			"/(([[:alnum:]]+:\/\/)|www\.)([^[:space:]]*)([[:alnum:]#?\/&=])/i",
			"<a href=\"\\1\\3\\4\" target=\"_blank\">\\1\\3\\4</a>", $text);

		// link mailtos
		$text = preg_replace(
			"/(([a-z0-9_]|\\-|\\.)+@([^[:space:]]*)([[:alnum:]-]))/i",
			"<a href=\"mailto:\\1\">\\1</a>", $text);

		if ( $parseTwitterLinks ) {
			if ( is_array($parseTwitterLinks) ) {
				$userLink = $parseTwitterLinks['user'];
				$argumentLink = $parseTwitterLinks['argument'];
			} else {
				$userLink = true;
				$argumentLink = true;
			}
			if ( is_bool($userLink) && $userLink ) {
				$userLink = '<a href="http://twitter.com/{user}" target="_blank">@{user}</a>';
			}
			if ( is_bool($argumentLink) && $argumentLink ) {
				$argumentLink = '<a href="http://twitter.com/search?q=%23{argument}" target="_blank">#{argument}</a>';
			}
			if ($userLink) {
				//link twitter users
				$text = preg_replace_callback( '/([\b ])@([a-z0-9_]*)\b/i',
					function ( $matches ) use ( $userLink )  {
						return $matches[1].str_replace( "{user}", $matches[2], $userLink );
					},
					$text
				);
			}
			if ($argumentLink) {
				//link twitter arguments
				$text = preg_replace_callback( '/([\b ])#([a-z0-9_]*)\b/i',
					function ( $matches ) use ( $argumentLink )  {
						return $matches[1].str_replace( "{argument}", $matches[2], $argumentLink );
					},
					$text
				);
			}
		}

		return trim($text);
	}

	public static function friendlyDate( $date, $nls = null, $now = null ) {
		if (!$nls) {
			$nls = array(
				'lastyear'   => 'last year',
				'yearsago'   => '%d years ago',
				'lastmonth'  => 'last month',
				'monthsago'  => '%d months ago',
				'lastweek'   => 'last week',
				'weeksago'   => '%d weeks ago',
				'yesterday'  => 'yesterday',
				'daysago'    => '%d days ago',
				'hourago'    => '1 hour ago',
				'hoursago'   => '%d hours ago',
				'minuteago'  => '1 minute ago',
				'minutesago' => '%d minutes ago',
				'justnow'    => 'just now'
			);
		}

		if ( !isset($now) ) {
			$now = time();
		}
		if ( is_string($date) ) {
			$date = strtotime($date, $now);
		}
		if ( is_string( $now ) ) {
			$now = strtotime( $now );
		}
		if ( is_int( $date ) && is_int( $now ) ) {
			$interval = getdate($now - $date);

			if ( $interval['year'] > 1971 ) {
				return sprintf( $nls['yearsago'], ( $interval['year'] - 1970 ) );
			} else if ( ($interval['year'] > 1970 ) || ( $interval['mon'] > 11 ) ) {
				return $nls['lastyear'];
			} else if ( $interval['mon'] > 2 ) {
				return sprintf( $nls['monthsago'], $interval['mon'] );
			} else if ( $interval['mon'] > 1 ) {
				return $nls['lastmonth'];
			} else if ( $interval['mday'] > 2 ) {
				return sprintf( $nls['daysago'], $interval['mday'] );
			} else if ( $interval['mday'] > 1 ) {
				return $nls['yesterday'];
			} else if ( $interval['hours'] > 2 ) {
				return sprintf( $nls['hoursago'], $interval['hours'] );
			} else if ( $interval['hours'] > 1 ) {
				return $nls['hourago'];
			} else if ( $interval['minutes'] > 1 ) {
				return sprintf( $nls['minutesago'], $interval['minutes'] );
			} else if ( $interval['minutes'] > 0 ) {
				return $nls['minuteago'];
			} else {
				return $nls['justnow'];
			}
		} else {
			return ar_error::raiseError( 'Illegal date argument', ar_exceptions::ILLEGAL_ARGUMENT );
		}
	}
}

class ar_connect_twitterClient extends arBase {

	private $rootURL = 'https://api.twitter.com/1.1/';
	private $client = null;

	public function __construct( $httpClient = null ) {
		if (!$httpClient) {
			ar::load('http');
			$httpClient = new ar_httpClientStream();
		}
		$this->client = $httpClient;
	}

	public function parse( $text, $parseTwitterLinks=true ) {
		return ar_connect_twitter::parse( $text, $parseTwitterLinks );
	}

	public function friendlyDate( $date, $nls = null, $now = null ) {
		return ar_connect_twitter::friendlyDate( $date, $nls, $now );
	}

	public function setAccessToken( $access_token, $access_token_secret, $consumerKey = null, $consumerSecret = null ) {

		if ( !$this->client instanceof ar_connect_oauthClient ) { //FIXME: a real OAuth is also ok
			// FIXME: what if you want a caching client?
			$this->client = ar_connect_oauth::client( $consumerKey, $consumerSecret );
			if ( ar_error::isError($this->client) ) {
				return $this->client;
			}
		}

		return $this->client->setToken( $access_token, $access_token_secret );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	public function login( $consumerKey = null, $consumerSecret = null, $callback = '', $redirect = true ) {
		// FIXME: $redirect should probably be allowed to be an object that implements a redirect() method
		$session = ar_loader::session(); //FIXME: allow different session object to be passed
		if ( !$session->id() ) {
			$session->start();
		}

		if ( isset($callback) && substr( (string) $callback, 0, 4)!='http' && $callback!='oob' ) {
			$callback = ar_loader::makeURL().$callback;
		}

		if ( !$this->client instanceof ar_connect_oauthClient ) { ////FIXME: a real OAuth is also ok
			// FIXME: what if you want a caching client?
			$this->client = ar_connect_oauth::client( $consumerKey, $consumerSecret );
			if ( ar_error::isError($this->client) ) {
				return $this->client;
			}
		}

		$access_token        = $session->getvar('access_token');
		$access_token_secret = $session->getvar('access_token_secret');
		if ( $access_token && $access_token_secret ) {
			$this->client->setToken( $access_token, $access_token_secret );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			return true;
		}

		$oauth_verifier     = $session->getvar('oauth_verifier');
		$oauth_token        = $session->getvar('oauth_token');
		$oauth_token_secret = $session->getvar('oauth_token_secret');
		if ( !$oauth_verifier ) {
			$oauth_verifier  = ar::getvar('oauth_verifier');
			if ( $oauth_verifier ) {
				$session->putvar( 'oauth_verifier', $oauth_verifier );
			} else {
				if ( !$callback ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
					$callback = 'oob';
				}
				$info = $this->client->getRequestToken( 'https://api.twitter.com/oauth/request_token', (string) $callback );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
				if ( ar_error::isError($info) ) {
					$info->debugInfo = $this->client->debugInfo;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
					return $info;
				}
				$this->client->setToken( $info['oauth_token'], $info['oauth_token_secret'] );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
				$session->putvar( 'oauth_token', $info['oauth_token'] );
				$session->putvar( 'oauth_token_secret', $info['oauth_token_secret'] );
				if ($redirect) {
					ar_loader::redirect( 'https://api.twitter.com/oauth/authorize?oauth_token='.RawUrlEncode( $info['oauth_token'] ) );
					return false;
				} else {
					return 'https://api.twitter.com/oauth/authorize?oauth_token='.RawUrlEncode( $info['oauth_token'] );
				}
			}
		}

		if ( $oauth_verifier ) {
			$this->client->setToken( $oauth_token, $oauth_token_secret );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			$info = $this->client->getAccessToken( 'https://api.twitter.com/oauth/access_token', '', $oauth_verifier );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			if ( ar_error::isError( $info ) ) {
				$info->debugInfo = $this->client->debugInfo;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
				return $info;
			}
			$access_token = $info['oauth_token'];
			$access_token_secret = $info['oauth_token_secret'];
			$this->client->setToken( $access_token, $access_token_secret );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			$session->putvar( 'access_token', $access_token );
			$session->putvar( 'access_token_secret', $access_token_secret );
			return $info;
		}

		return false;
	}

	public function tweets( $user, $options = array() ) {
		// http://dev.twitter.com/doc/get/statuses/user_timeline
		$defaults = array(
			'count' => 10,
			'page' => 1
		);
		$options += $defaults;
		if ( is_numeric($user) ) {
			$options['user_id'] = $user;
			unset($user);
		} else if ($user) {
			$options['screen_name'] = $user;
		}
		return $this->get( 'statuses/user_timeline', $options );
	}

	public function trends( $location = 'place', $options = array() ) {
		switch ( $location ) {
			case 'place':			//https://dev.twitter.com/docs/api/1.1/get/trends/place
				if (!$options['id']) {
					$options['id'] = 1; // YAHOO! Where On Earth ID, 1 = worldwide
				}
				break;
			case 'available':		//https://dev.twitter.com/docs/api/1.1/get/trends/available
			case 'closest':			//https://dev.twitter.com/docs/api/1.1/get/trends/closest
			break;
			default :
				$location = 'place';
				$options['id'] = 1;
			break;
		}
		return $this->get( 'trends/'.$location, $options );
	}

	public function search( $options ) {
		if ( is_string($options) ) {
			$options = array( 'q' => $options );
		}
		return $this->get( 'search/tweets', $options );
	}

	public function tweet( $status, $options = array() ) {
		$options['status'] = $status;
		return $this->post( 'statuses/update', $options );
	}

	public function get( $path, $options = array() ) {
		$url = ar::url( $this->rootURL.$path.'.json' );
		$url->query->import( $options );

		$json = $this->client->get( $url );

		if ($json && !ar_error::isError($json) ) {
			return json_decode( $json );
		} else {
			return $json;
		}
	}

	public function post( $path, $options = array() ) {
		$url = ar::url( $this->rootURL.$path.'.json' );
		$json = $this->client->post( $url, $options );
		if ($json && !ar_error::isError($json) ) {
			return json_decode( $json );
		} else {
			return $json;
		}
	}

}


1		<?php
2
3		ar_pinp::allow('ar_connect_twitter');
4		ar_pinp::allow('ar_connect_twitterClient');
5
6		class ar_connect_twitter extends arBase {
7
8		public static function client( $httpClient = null ) {
9		return new ar_connect_twitterClient( $httpClient );
10		}
11
12		public static function parse( $text, $parseTwitterLinks = true ) {
13		// FIXME: allow normal links and mailto links to be specified like the user and argument links
14		// link URLs
15		$text = " ".preg_replace(
16		"/(([[:alnum:]]+:\/\/)\|www\.)([^[:space:]]*)([[:alnum:]#?\/&=])/i",
17		"<a href=\"\\1\\3\\4\" target=\"_blank\">\\1\\3\\4</a>", $text);
18
19		// link mailtos
20		$text = preg_replace(
21		"/(([a-z0-9_]\|\\-\|\\.)+@([^[:space:]]*)([[:alnum:]-]))/i",
22		"<a href=\"mailto:\\1\">\\1</a>", $text);
23
24		if ( $parseTwitterLinks ) {
25		if ( is_array($parseTwitterLinks) ) {
26		$userLink = $parseTwitterLinks['user'];
27		$argumentLink = $parseTwitterLinks['argument'];
28		} else {
29		$userLink = true;
30		$argumentLink = true;
31		}
32		if ( is_bool($userLink) && $userLink ) {
33		$userLink = '<a href="http://twitter.com/{user}" target="_blank">@{user}</a>';
34		}
35		if ( is_bool($argumentLink) && $argumentLink ) {
36		$argumentLink = '<a href="http://twitter.com/search?q=%23{argument}" target="_blank">#{argument}</a>';
37		}
38	View Code Duplication	if ($userLink) {
39		//link twitter users
40		$text = preg_replace_callback( '/([\b ])@([a-z0-9_]*)\b/i',
41		function ( $matches ) use ( $userLink ) {
42		return $matches[1].str_replace( "{user}", $matches[2], $userLink );
43		},
44		$text
45		);
46		}
47	View Code Duplication	if ($argumentLink) {
48		//link twitter arguments
49		$text = preg_replace_callback( '/([\b ])#([a-z0-9_]*)\b/i',
50		function ( $matches ) use ( $argumentLink ) {
51		return $matches[1].str_replace( "{argument}", $matches[2], $argumentLink );
52		},
53		$text
54		);
55		}
56		}
57
58		return trim($text);
59		}
60
61		public static function friendlyDate( $date, $nls = null, $now = null ) {
62		if (!$nls) {
63		$nls = array(
64		'lastyear' => 'last year',
65		'yearsago' => '%d years ago',
66		'lastmonth' => 'last month',
67		'monthsago' => '%d months ago',
68		'lastweek' => 'last week',
69		'weeksago' => '%d weeks ago',
70		'yesterday' => 'yesterday',
71		'daysago' => '%d days ago',
72		'hourago' => '1 hour ago',
73		'hoursago' => '%d hours ago',
74		'minuteago' => '1 minute ago',
75		'minutesago' => '%d minutes ago',
76		'justnow' => 'just now'
77		);
78		}
79
80		if ( !isset($now) ) {
81		$now = time();
82		}
83		if ( is_string($date) ) {
84		$date = strtotime($date, $now);
85		}
86		if ( is_string( $now ) ) {
87		$now = strtotime( $now );
88		}
89		if ( is_int( $date ) && is_int( $now ) ) {
90		$interval = getdate($now - $date);
91
92		if ( $interval['year'] > 1971 ) {
93		return sprintf( $nls['yearsago'], ( $interval['year'] - 1970 ) );
94		} else if ( ($interval['year'] > 1970 ) \|\| ( $interval['mon'] > 11 ) ) {
95		return $nls['lastyear'];
96		} else if ( $interval['mon'] > 2 ) {
97		return sprintf( $nls['monthsago'], $interval['mon'] );
98		} else if ( $interval['mon'] > 1 ) {
99		return $nls['lastmonth'];
100		} else if ( $interval['mday'] > 2 ) {
101		return sprintf( $nls['daysago'], $interval['mday'] );
102		} else if ( $interval['mday'] > 1 ) {
103		return $nls['yesterday'];
104		} else if ( $interval['hours'] > 2 ) {
105		return sprintf( $nls['hoursago'], $interval['hours'] );
106		} else if ( $interval['hours'] > 1 ) {
107		return $nls['hourago'];
108		} else if ( $interval['minutes'] > 1 ) {
109		return sprintf( $nls['minutesago'], $interval['minutes'] );
110		} else if ( $interval['minutes'] > 0 ) {
111		return $nls['minuteago'];
112		} else {
113		return $nls['justnow'];
114		}
115		} else {
116		return ar_error::raiseError( 'Illegal date argument', ar_exceptions::ILLEGAL_ARGUMENT );
117		}
118		}
119		}
120
121		class ar_connect_twitterClient extends arBase {
122
123		private $rootURL = 'https://api.twitter.com/1.1/';
124		private $client = null;
125
126		public function __construct( $httpClient = null ) {
127		if (!$httpClient) {
128		ar::load('http');
129		$httpClient = new ar_httpClientStream();
130		}
131		$this->client = $httpClient;
132		}
133
134		public function parse( $text, $parseTwitterLinks=true ) {
135		return ar_connect_twitter::parse( $text, $parseTwitterLinks );
136		}
137
138		public function friendlyDate( $date, $nls = null, $now = null ) {
139		return ar_connect_twitter::friendlyDate( $date, $nls, $now );
140		}
141
142		public function setAccessToken( $access_token, $access_token_secret, $consumerKey = null, $consumerSecret = null ) {
143
144	View Code Duplication	if ( !$this->client instanceof ar_connect_oauthClient ) { //FIXME: a real OAuth is also ok
145		// FIXME: what if you want a caching client?
146		$this->client = ar_connect_oauth::client( $consumerKey, $consumerSecret );
147		if ( ar_error::isError($this->client) ) {
148		return $this->client;
149		}
150		}
151
152		return $this->client->setToken( $access_token, $access_token_secret );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
153		}
154
155		public function login( $consumerKey = null, $consumerSecret = null, $callback = '', $redirect = true ) {
156		// FIXME: $redirect should probably be allowed to be an object that implements a redirect() method
157		$session = ar_loader::session(); //FIXME: allow different session object to be passed
158		if ( !$session->id() ) {
159		$session->start();
160		}
161
162		if ( isset($callback) && substr( (string) $callback, 0, 4)!='http' && $callback!='oob' ) {
163		$callback = ar_loader::makeURL().$callback;
164		}
165
166	View Code Duplication	if ( !$this->client instanceof ar_connect_oauthClient ) { ////FIXME: a real OAuth is also ok
167		// FIXME: what if you want a caching client?
168		$this->client = ar_connect_oauth::client( $consumerKey, $consumerSecret );
169		if ( ar_error::isError($this->client) ) {
170		return $this->client;
171		}
172		}
173
174		$access_token = $session->getvar('access_token');
175		$access_token_secret = $session->getvar('access_token_secret');
176		if ( $access_token && $access_token_secret ) {
177		$this->client->setToken( $access_token, $access_token_secret );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
178		return true;
179		}
180
181		$oauth_verifier = $session->getvar('oauth_verifier');
182		$oauth_token = $session->getvar('oauth_token');
183		$oauth_token_secret = $session->getvar('oauth_token_secret');
184		if ( !$oauth_verifier ) {
185		$oauth_verifier = ar::getvar('oauth_verifier');
186		if ( $oauth_verifier ) {
187		$session->putvar( 'oauth_verifier', $oauth_verifier );
188		} else {
189		if ( !$callback ) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$callback` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
190		$callback = 'oob';
191		}
192		$info = $this->client->getRequestToken( 'https://api.twitter.com/oauth/request_token', (string) $callback );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getRequestToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
193		if ( ar_error::isError($info) ) {
194		$info->debugInfo = $this->client->debugInfo;
		0 ignored issues – show Documentation introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `debugInfo` does not exist on `object<ar_connect_oauthClient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
195		return $info;
196		}
197		$this->client->setToken( $info['oauth_token'], $info['oauth_token_secret'] );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
198		$session->putvar( 'oauth_token', $info['oauth_token'] );
199		$session->putvar( 'oauth_token_secret', $info['oauth_token_secret'] );
200		if ($redirect) {
201		ar_loader::redirect( 'https://api.twitter.com/oauth/authorize?oauth_token='.RawUrlEncode( $info['oauth_token'] ) );
202		return false;
203		} else {
204		return 'https://api.twitter.com/oauth/authorize?oauth_token='.RawUrlEncode( $info['oauth_token'] );
205		}
206		}
207		}
208
209		if ( $oauth_verifier ) {
210		$this->client->setToken( $oauth_token, $oauth_token_secret );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
211		$info = $this->client->getAccessToken( 'https://api.twitter.com/oauth/access_token', '', $oauth_verifier );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getAccessToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
212		if ( ar_error::isError( $info ) ) {
213		$info->debugInfo = $this->client->debugInfo;
		0 ignored issues – show Documentation introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `debugInfo` does not exist on `object<ar_connect_oauthClient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
214		return $info;
215		}
216		$access_token = $info['oauth_token'];
217		$access_token_secret = $info['oauth_token_secret'];
218		$this->client->setToken( $access_token, $access_token_secret );
		0 ignored issues – show Documentation Bug introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setToken` does not exist on `object<ar_connect_oauthClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
219		$session->putvar( 'access_token', $access_token );
220		$session->putvar( 'access_token_secret', $access_token_secret );
221		return $info;
222		}
223
224		return false;
225		}
226
227		public function tweets( $user, $options = array() ) {
228		// http://dev.twitter.com/doc/get/statuses/user_timeline
229		$defaults = array(
230		'count' => 10,
231		'page' => 1
232		);
233		$options += $defaults;
234		if ( is_numeric($user) ) {
235		$options['user_id'] = $user;
236		unset($user);
237		} else if ($user) {
238		$options['screen_name'] = $user;
239		}
240		return $this->get( 'statuses/user_timeline', $options );
241		}
242
243		public function trends( $location = 'place', $options = array() ) {
244		switch ( $location ) {
245		case 'place': //https://dev.twitter.com/docs/api/1.1/get/trends/place
246		if (!$options['id']) {
247		$options['id'] = 1; // YAHOO! Where On Earth ID, 1 = worldwide
248		}
249		break;
250		case 'available': //https://dev.twitter.com/docs/api/1.1/get/trends/available
251		case 'closest': //https://dev.twitter.com/docs/api/1.1/get/trends/closest
252		break;
253		default :
254		$location = 'place';
255		$options['id'] = 1;
256		break;
257		}
258		return $this->get( 'trends/'.$location, $options );
259		}
260
261		public function search( $options ) {
262		if ( is_string($options) ) {
263		$options = array( 'q' => $options );
264		}
265		return $this->get( 'search/tweets', $options );
266		}
267
268		public function tweet( $status, $options = array() ) {
269		$options['status'] = $status;
270		return $this->post( 'statuses/update', $options );
271		}
272
273	View Code Duplication	public function get( $path, $options = array() ) {
274		$url = ar::url( $this->rootURL.$path.'.json' );
275		$url->query->import( $options );
276
277		$json = $this->client->get( $url );
278
279		if ($json && !ar_error::isError($json) ) {
280		return json_decode( $json );
281		} else {
282		return $json;
283		}
284		}
285
286	View Code Duplication	public function post( $path, $options = array() ) {
287		$url = ar::url( $this->rootURL.$path.'.json' );
288		$json = $this->client->post( $url, $options );
289		if ($json && !ar_error::isError($json) ) {
290		return json_decode( $json );
291		} else {
292		return $json;
293		}
294		}
295
296		}
297

Ariadne-CMS / ariadne

Issues (1751)

Security Analysis not enabled

lib/ar/connect/twitter.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like