system_checks.php ➔ check_db_charset() - Code Metrics - Inspection of "Merge pull request #139 from Ariadne-CMS/php7.2-tr..." - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 31bf8b...790ba1 )

by Auke

created 2018-12-19 14:33 UTC

system_checks.php ➔ check_db_charset() B

↳ Parent: Project

Complexity

Conditions	7
Paths	7

Size

Total Lines

Duplication

Lines	11
Ratio	78.57 %

Importance

Changes

Metric	Value
cc	7
nc	7
nop	1
dl	11
loc	14
rs	8.8333
c	0
b	0
f	0

<?php
	$ariadne = '';

	function check_php_version() {
		if (version_compare(PHP_VERSION, '5.6.2', '>=')) {
			return true;
		}
		return false;
	}

	function check_database_support() {
		if (check_mysql() || check_postgresql()) {
			return true;
		}
		return false;
	}

	function check_mysql() {
		if(function_exists('mysqli_connect')) {
			return true;
		}
		return false;
	}

	function check_postgresql() {
		if (function_exists('pg_connect')) {
			return true;
		}
		return false;
	}

	function check_apache() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if (preg_match("/^apache/i", $_SERVER['SERVER_SOFTWARE'])) {
			return true;
		}
		return false;
	}

	function check_webserver() {
		if (
			check_apache()
			// FIXME: Add more compatible webservers.
		) {
			return true;
		}
		return false;
	}

	function check_accept_path_info() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( function_exists('apache_lookup_uri')) {
			$extrapath = "/test_path_info/";
			$object = apache_lookup_uri($_SERVER['REQUEST_URI'] . $extrapath);
			if ($object->path_info == $extrapath) {
				return true;
			}
			return false;
		} else {
			$ariadne = '';
			@include("../ariadne.inc");
			if ( $ariadne != '' ) {
				require_once($ariadne . '/ar.php');

				// checking if path_info could be available
				$testuri = new ar_url('http://' .  $_SERVER["HTTP_HOST"] . $_SERVER["REQUEST_URI"]);
				$testuri->query = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
				$testuri->path = str_replace('/index.php', '/', $testuri->path)."serverinfo.php";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
				$testuri = (string)$testuri;
				$result1 = json_decode(ar_http::get($testuri),true);
				$result2 = json_decode(ar_http::get($testuri.'/my/path/info'),true);

				if ( is_array($result1) && is_array($result2) ) {
					// self request works
					// pathinfo could work
					if( $result2['server']['PATH_INFO'] == '/my/path/info' ) {
						return true;
					} else {
						return false;
					}
				} elseif ( is_array($result1) && is_null($result2) ) {
					// self request works
					// request with pathinfo fails
					return false;
				} else {
					// self request fails
					// should return 'check via browser'
					return false;
				}
			}
		}
		return false;
	}

	function check_zend_compat() {
		if (!ini_get("zend.ze1_compatibility_mode")) {
			return true;
		}
		return false;
	}

	function check_ariadne_inc_read() {
		if (is_readable("../ariadne.inc")) {
			return true;
		}
		return false;
	}

	function check_ariadne_path() {
		@include("../ariadne.inc");
		if (is_readable($ariadne . "/templates/pobject/")) {

			return true;
		}
		return false;
	}


	function check_files_write() {
		@include("../ariadne.inc");
		if (is_writable($ariadne . "/../files/")) {

			return true;
		}
		return false;
	}

	function check_ariadne_phtml_write() {
		@include("../ariadne.inc");
		if (file_exists($ariadne . "/configs/ariadne.phtml")) {
			if (is_writable($ariadne . "/configs/ariadne.phtml")) {

				return true;
			}
		} else {
			if (is_writable($ariadne . "/configs/")) {
				return true;
			}
		}
		return false;
	}

	function check_im_convert() {
		$bin = find_in_path('convert');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_convert'] = $bin;
			return true;
		}
		return false;
	}

	function check_im_mogrify() {
		$bin = find_in_path('mogrify');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_mogrify'] = $bin;
			return true;
		}
		return false;
	}

	function check_im_composite() {
		$bin = find_in_path('composite');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_composite'] = $bin;
			return true;
		}
		return false;
	}

	function check_im_identify() {
		$bin = find_in_path('identify');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_identify'] = $bin;
			return true;
		}
		return false;
	}

	function check_image_magick() {
		if (
			check_im_convert() &&
			check_im_mogrify() &&
			check_im_composite() &&
			check_im_identify()
		) {
			return true;
		}
		return false;
	}

	function check_svn() {
		if (
			check_svn_class() &&
			check_svn_binary()
		) {
			return true;
		}
		return false;
	}

	function check_svn_class() {
		@include_once("VersionControl/SVN.php");
		if (class_exists("VersionControl_SVN")) {
			return true;
		}
		return false;
	}

	function check_domdocument_class() {
		if (class_exists("DOMDocument")) {
			return true;
		}
		return false;
	}

	function check_svn_binary() {

		$bin = find_in_path('svn');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_svn'] = $bin;
			return true;
		}
		return false;
	}

	function check_svn_write() {
		@include("../ariadne.inc");
		if (is_writeable($ariadne . "/configs/svn/")) {

			return true;
		}
		return false;
	}

	function check_html_tidy() {

		$bin = find_in_path('tidy');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_tidy'] = $bin;
			return true;
		}
		return false;
	}

	function check_grep() {

		$bin = find_in_path('grep');
		if (is_executable($bin)) {
			global $found_bins;
			$found_bins['bin_grep'] = $bin;
			return true;
		}
		return false;
	}

	function check_connect_db($conf) {
		if ($conf && $conf->dbms) {
			switch ( $conf->dbms ) {
				case 'mysql':
				case 'mysql_workspaces':
					return check_connect_db_mysql($conf);
				break;
				case 'postgresql':
					return check_connect_db_postgresql($conf);
				break;
			}
			// FIXME: Add postgresql checks too
		}
		return false;
	}

	function check_select_db($conf) {
		if ($conf && $conf->dbms) {
			switch ( $conf->dbms ) {
				case 'mysql':
				case 'mysql_workspaces':
					return check_select_db_mysql($conf);
				break;
				case 'postgresql':
					return check_select_db_postgresql($conf);
				break;
			}
		}
		return false;
	}

	function check_db_grants($conf) {
		if ($conf && $conf->dbms) {
			switch ( $conf->dbms ) {
				case 'mysql':
				case 'mysql_workspaces':
					return check_db_grants_mysql($conf);
				break;
				case 'postgresql':
					return check_db_grants_postgresql($conf);
				break;
			}
		}
		return false;
	}

	function check_db_charset($conf) {
		if ($conf && $conf->dbms) {
			switch ( $conf->dbms ) {
				case 'mysql':
				case 'mysql_workspaces':
					return check_db_charset_mysql($conf) && check_db_collation_mysql($conf);
				break;
				case 'postgresql':
					return true; // No known issues for postgres
				break;
			}
		}
		return false;
	}

	function check_db_grants_mysql($conf) {
		$dbh = getConnection($conf);
		if (!$dbh->connect_errno) {
			$query = "SHOW GRANTS FOR CURRENT_USER();";

			$result = $dbh->query($query);
			if (!$dbh->errno ) {
				while ($row = $result->fetch_row()){
					if (preg_match("/^GRANT ALL/", $row[0])) {
						return true;
					}
					if (
						preg_match("/^GRANT.*?SELECT.*?ON/", $row[0]) &&
						preg_match("/^GRANT.*?INSERT.*?ON/", $row[0]) &&
						preg_match("/^GRANT.*?UPDATE.*?ON/", $row[0]) &&
						preg_match("/^GRANT.*?CREATE.*?ON/", $row[0]) &&
						preg_match("/^GRANT.*?DELETE.*?ON/", $row[0])
					) {
						return true;
					}
				}
			}
		}
		return false;
	}

	function check_db_grants_postgresql($conf) {
		if ( check_select_db_postgresql($conf) ) {
			$query = "SELECT has_database_privilege ( '".$conf->database."', 'CREATE' );";
			$result = pg_query( $query );
			while ( $row = pg_fetch_row( $result ) ) {
				if ( $row[0]=='t' ) {
					return true;
				}
			}
		}
		return false;
	}

	function getConnection($conf){
		static $dbh;
		if(!isset($dbh)) {
			$dbh = new mysqli($conf->host, $conf->user, $conf->password, $conf->database);
		}
		return $dbh;
	}

	function check_connect_db_mysql($conf) {
		$dbh = getConnection($conf);
		if ($dbh->connect_errno) {
			return false;
		}
		return true;
	}

	function check_connect_db_postgresql($conf) {
		$port = null;
		$host = $conf->host;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		if ( strpos($conf->host,':') !== false) {
			list($host,$port) = explode($conf->host, ':',2);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
		}

		if( $conf->host == ''){
			$hoststr = '';
		} else {
			$hoststr = 'host='.$conf->host;
		}

		if ($port) {
			$hoststr = $hoststr .= ' port='.$port;
		}

		if( $conf->password != '' ){
			$password = ' password='.$conf->password;
		}

		$connstring = $hoststr.' dbname='.$conf->database.' user='.$conf->user . ' ' .$password;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$conf->connection = pg_connect($connstring);
		return (bool) $conf->connection;
	}

	function check_select_db_mysql($conf) {
		return check_connect_db_mysql($conf); //connect also checks database
	}

	function check_select_db_postgresql($conf) {
		return check_connect_db_postgresql($conf); //connect also checks database
	}


	function check_db_is_empty($conf) {
		switch( $conf->dbms ) {
			case 'mysql':
			case 'mysql_workspaces':
				return check_db_is_empty_mysql($conf);
			break;
			case 'postgresql':
				return check_db_is_empty_postgresql($conf);
			break;
		}
		return false;
	}

	function check_db_is_empty_mysql($conf) {
		$dbh = getConnection($conf);
		if (!$dbh->connect_errno) {
			$query = "SHOW TABLES;";
			$result = $dbh->query($query);
			if (!$dbh->errno && $result->num_rows == 0) {
				return true;
			}
		}
		return false;
	}

	function check_db_collation_mysql($conf) {

		$dbh = getConnection($conf);
		if (!$dbh->connect_errno) {
			$query = "SHOW VARIABLES LIKE 'collation_server'";
			$result = $dbh->query($query);
			if (!$dbh->errno && $result->num_rows) {
				$vars = mysqli_fetch_row($result);
				if ($vars && $vars[1] && ($vars[1] == "latin1_swedish_ci")) {
					return true;
				}
			}
		}
		return false;
	}

	function check_db_charset_mysql($conf) {

		$dbh = getConnection($conf);
		if (!$dbh->connect_errno) {
			$query = "SHOW VARIABLES LIKE 'character_set_server'";
			$result = $dbh->query($query);
			if (!$dbh->errno && $result->num_rows) {
				$vars = mysqli_fetch_row($result);
				if ($vars && $vars[1] && ($vars[1] == "latin1")) {
					return true;
				}
			}
		}
		return false;
	}

	function check_db_is_empty_postgresql($conf) {
		if (check_connect_db_postgresql($conf)) {
			$query = "SELECT table_name FROM information_schema.tables WHERE table_schema = 'public';";
			$result = pg_query($conf->connection, $query);
			if (pg_num_rows($result) == 0) {
				return true;
			}
		}
		return false;
	}

	function check_file( $file ) {
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
		if (file_exists($file) && is_readable($file)) {
			return true;
		}
		return false;
	}

	function check_base_ax() {
		if (check_file("packages/base.ax")) {
			return true;
		}
		return false;
	}

	function check_demo_ax() {
		if (check_file("packages/demo.ax")) {
			return true;
		}
		return false;
	}

	function check_libs_ax() {
		if (check_file("packages/libs.ax")) {
			return true;
		}
		return false;
	}

	function check_docs_ax() {
		if (check_file("packages/docs.ax")) {
			return true;
		}
		return false;
	}

	function check_admin_password($admin_passwords) {
		if ($admin_passwords[0] && $admin_passwords[1] && $admin_passwords[0] == $admin_passwords[1]) {
			return true;
		}
		return false;
	}

	function check_tar_class() {
		@include_once("Archive/Tar.php");
		if (class_exists("Archive_Tar")) {
			return true;
		}
		return false;
	}

	function check_exif() {
		if (function_exists('exif_read_data')) {
			return true;
		}
		return false;
	}

	function check_mb_functions() {
		if (function_exists('mb_substr')) {
			return true;
		}
		return false;
	}

	function check_mcrypt() {
		if (function_exists('mcrypt_encrypt')) {
			return true;
		}
		return false;
	}

	function getServerVar( $name ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		return isset( $_SERVER[$name] ) ? $_SERVER[$name] : null;
	}

	function find_in_path($needle,array $extrapath=array()) {
		$paths = explode(PATH_SEPARATOR,getServerVar('PATH'));
		$paths = array_merge($paths,$extrapath);

		$exts = explode(PATH_SEPARATOR, getServerVar('PATHEXT'));

		foreach($paths as $path){
			$file = $path . DIRECTORY_SEPARATOR . $needle;
			if(file_exists($file)) {
				return $file;
			}

			// W32 needs this
			foreach ($exts as $ext) {
				if(file_exists($file.$ext)) {
					return $file.$ext;
				}
			}
		}
	}

	$found_bins = array(); // will be filled by the check functions

	$required_checks = array(
		"check_php_version" => check_php_version(),		// php => 5.6.2
		"check_database_support" => check_database_support(),	// MySQL or Postgres
		"check_webserver" => check_webserver(),			// Apache, IIS, NGINX?
		"check_accept_path_info" => check_accept_path_info(),	// Apache config: AcceptPathInfo
		"check_zend_compat" => check_zend_compat(),		// zend.ze1_compatibility_mode = Off
		"check_ariadne_inc_read" => check_ariadne_inc_read(),	// Check if configuration file (ariadne.inc) can be read bij www-data
		"check_ariadne_path" => check_ariadne_path(),		// Check if path in ariadne.inc looks like an Ariadne tree
		"check_files_write" => check_files_write(),		// Check if files dir can be written by www-data
		"check_base_ax"	=> check_base_ax(),
		"check_tar_class" => check_tar_class(),			// Check if Archive/Tar class is available to import packages with.
		"check_mb_functions" => check_mb_functions(),			// Check if Archive/Tar class is available to import packages with.
		"check_domdocument_class" => check_domdocument_class(),
	);

	$recommended_checks = array(
		"check_ariadne_phtml_write" => check_ariadne_phtml_write(),	// Check if configuration file (ariadne.phtml) can be written bij www-data
		"check_exif" => check_exif(),
		"check_image_magick" => check_image_magick(),
		"check_svn" => check_svn(),
		"check_svn_write" => check_svn_write(),
		"check_html_tidy" => check_html_tidy(),
		"check_grep" => check_grep(),
		"check_demo_ax" => check_demo_ax(),
		"check_mcrypt" => check_mcrypt(),
//		"check_libs_ax" => check_libs_ax(),
//		"check_docs_ax" => check_docs_ax()
	);

?>



1			<?php
2			$ariadne = '';
3
4			function check_php_version() {
5			if (version_compare(PHP_VERSION, '5.6.2', '>=')) {
6			return true;
7			}
8			return false;
9			}
10
11			function check_database_support() {
12			if (check_mysql() \|\| check_postgresql()) {
13			return true;
14			}
15			return false;
16			}
17
18			function check_mysql() {
19			if(function_exists('mysqli_connect')) {
20			return true;
21			}
22			return false;
23			}
24
25			function check_postgresql() {
26			if (function_exists('pg_connect')) {
27			return true;
28			}
29			return false;
30			}
31
32			function check_apache() {
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report `check_apache` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33			if (preg_match("/^apache/i", $_SERVER['SERVER_SOFTWARE'])) {
34			return true;
35			}
36			return false;
37			}
38
39			function check_webserver() {

Ariadne-CMS / ariadne

Push — master ( 31bf8b...790ba1 )

system_checks.php ➔ check_db_charset() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like