ar_http::getvar() - Code Metrics - Inspection of "Merge pull request #106 from mjrider/for-upstream" - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db26d9...e5ef44 )

by Auke

created 2016-04-06 13:12 UTC

ar_http::getvar() C

↳ Parent: ar_http

Complexity

Conditions	13
Paths	48

Size

Total Lines	37
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	18.5377

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	37
ccs	17
cts	25
cp	0.68
rs	5.1234
cc	13
eloc	23
nc	48
nop	2
crap	18.5377

How to fix Complexity

<?php


	ar_pinp::allow( 'ar_http');
	ar_pinp::allow( 'ar_httpClientStream' );

	/*
	 * prevent mess detector from warning for the private static fields
	 * @SuppressWarnings(PHPMD.UnusedPrivateField)
	 */
	class ar_http extends arBase {

		private static $_GET, $_POST, $_REQUEST, $_SERVER, $_COOKIE;  //needed to make __get() work

		public static $tainting = true;

		public function __get($var) {
			switch ($var) {
				case '_GET' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return $this->getvar( null, 'GET');
				break;
				case '_POST' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return $this->getvar( null, 'POST');
				break;
				case '_REQUEST' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return $this->getvar();
				break;
				case '_SERVER' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return $this->getvar( null, 'SERVER');
				break;
				case '_COOKIE' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return $this->getvar( null, 'COOKIE');
				break;
				case 'tainting' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					return self::$tainting;
				break;
			}
		}

		public function __set( $var, $value ) {
			if ($var=='tainting') {
				self::$tainting = (bool) $value;
			}
		}

		public static function getvar( $name = null, $method = null) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			/*
				The full list of field-name characters that PHP converts to _ (underscore) is the following (not just dot):

				chr(32) ( ) (space)
				chr(46) (.) (dot)
				chr(91) ([) (open square bracket)
				chr(128) - chr(159) (various)
				PHP irreversibly modifies field names containing these characters in an attempt to maintain compatibility with the deprecated register_globals feature.
			*/
			if (isset($name) ) {
				$name = preg_replace("/[ \.\[\x80-\x9f]/", "_", $name);
			}

			switch($method) {
				case 'GET' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					$result = isset($name) ? $_GET[$name] : $_GET;
				break;
				case 'POST' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					$result = isset($name) ? $_POST[$name] : $_POST;
				break;
				case 'COOKIE' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					$result = isset($name) ? $_COOKIE[$name] : $_COOKIE;
				break;
				case 'SERVER' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					$result = isset($name) ? $_SERVER[$name] : $_SERVER;
				break;
				default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
					$result = !isset($name) ? $_REQUEST :
						( isset($_POST[$name]) ? $_POST[$name] : $_GET[$name] );
				break;
			}
			if (self::$tainting) {
				ar::taint( $result );
			}
			return $result;
		}

		public static function request( $method = null, $url = null, $postdata = null, $options = array() ) {
			$client = new ar_httpClientStream(); //$method, $url, $postdata, $port);

			return $client->send( $method, $url, $postdata, $options );
		}

		public static function client( $options = array() ) {
			return new ar_httpClientStream( $options );
		}

		public static function configure( $option, $value ) {
			switch ( $option ) {
				case 'tainting' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
					self::$tainting = $value;
				break;
			}
		}

		public static function header( $header ) {
			return ar_http_headers::header( $header );
		}

		public static function get( $url, $request = null, $options = array() ) {
			return self::request( 'GET', $url, $request, $options);
		}

		public static function post( $url, $request = null, $options = array() ) {
			return self::request( 'POST', $url, $request, $options);
		}

	}

	interface ar_httpClient {


		public function get( $url, $request = null, $options = array() );

		public function post( $url, $request = null, $options = array() );

		public function put( $url, $request = null, $options = array() );

		public function delete( $url, $request = null, $options = array() );

		public function send( $type, $url, $request = null, $options = array() );

		public function headers( $headers );

	}

	class ar_httpClientStream extends arBase implements ar_httpClient {


		private $options = array();

		public $responseHeaders = null;

		/* FIXME: function not used, is it still relevant?

		private function parseRequestURL( $url ) {
			$request = explode( '?', (string) $url );
			if ( isset($request[1]) ) {
				return $request[1];
			} else {
				return null;
			}
		}
		*/

		private function compileRequest( array $request ) {
			$result = "";
			foreach ( $request as $key => $value ) {
				if ( !is_integer( $key ) ) {
					$result .= urlencode($key) . "=" . urlencode($value) . "&";
				}
			}
			return substr( $result, 0, -1);
		}

		private function mergeOptions( ) {
			$args = func_get_args();
			array_unshift( $args, $this->options );
			return call_user_func_array( 'array_merge', $args );
		}

		public function send( $type, $url, $request = null, $options = array() ) {
			if ( is_array( $request ) ) {
				$request = $this->compileRequest( $request );
			}
			$options = $this->mergeOptions( array(
				'method' => $type,
				'content' => $request
			), $options );

			if ( $options['method'] == 'GET' && $options['content'] ) {
				if ( strpos( $url, '?' ) === false ) {
					$url = $url . '?' . $options['content'];
				} else {
					$url = $url . '&' . $options['content'];
				}
				$options['content'] = '';
			}
			$context = stream_context_create( array( 'http' => $options ) );
			$result = @file_get_contents( (string) $url, false, $context );

			$this->responseHeaders = $http_response_header; //magic php variable set by file_get_contents.
			if (is_array($this->responseHeaders) && isset($this->responseHeaders[0])) {
				$statusLine = explode(" ", $this->responseHeaders[0]);
				$this->statusCode = $statusLine[1];
class MyClass { }

$x = new MyClass();
$x->foo = true;
			}

			$this->requestHeaders = $options['header'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
			return $result;
		}

		public function __construct( $options = array() ) {
			$this->options = $options;
		}

		public function get( $url, $request = null, $options = array() ) {
			return $this->send( 'GET', $url, $request, $options );
		}

		public function post( $url, $request = null, $options = array() ) {
			return $this->send( 'POST', $url, $request, $options );
		}

		public function put( $url, $request = null, $options = array() ) {
			return $this->send( 'PUT', $url, $request, $options );
		}

		public function delete( $url, $request = null, $options = array() ) {
			return $this->send( 'DELETE', $url, $request, $options );
		}

		public function headers( $headers ) {
			if (is_array($headers)) {
				$headers = join("\r\n", $headers);
			}
			$this->options['header'] = $this->options['headers'].$headers;
			return $this;
		}
	}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-15 09:55 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 10 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			ar_pinp::allow( 'ar_http');
4			ar_pinp::allow( 'ar_httpClientStream' );
5
6			/*
7			* prevent mess detector from warning for the private static fields
8			* @SuppressWarnings(PHPMD.UnusedPrivateField)
9			*/
10			class ar_http extends arBase {
11
12			private static $_GET, $_POST, $_REQUEST, $_SERVER, $_COOKIE; //needed to make __get() work
			0 ignored issues – show Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report The property `$_GET` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report The property `$_POST` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report The property `$_REQUEST` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report The property `$_SERVER` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Unused Code introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report The property `$_COOKIE` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history...
13			public static $tainting = true;
14
15			public function __get($var) {
16			switch ($var) {
17			case '_GET' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
18			return $this->getvar( null, 'GET');
19			break;
20			case '_POST' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
21			return $this->getvar( null, 'POST');
22			break;
23			case '_REQUEST' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
24			return $this->getvar();
25			break;
26			case '_SERVER' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
27			return $this->getvar( null, 'SERVER');
28			break;
29			case '_COOKIE' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
30			return $this->getvar( null, 'COOKIE');
31			break;
32			case 'tainting' :
			0 ignored issues – show Coding Style introduced 2015-11-26 08:52 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...

Ariadne-CMS / ariadne

Push — master ( db26d9...e5ef44 )

ar_http::getvar() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like