+global\sql_compiler::parse_ident()

Complexity

Conditions	22
Paths	722

Size

Total Lines	109
Code Lines	78

Duplication

Lines	24
Ratio	22.02 %

Code Coverage

Tests	61
CRAP Score	41.7196

<?php
	protected function parse_ident(&$YYBUFFER) {
		/* parse identifier regs 1,2 and 3

37% of this comment could be valid code. Did you maybe forget this after debugging?

			reg[1]: tablename
			reg[2]: property name
			reg[3]: only used with 'my' properties
		*/
		$reg_id='^[[:space:]]*(([a-z_][a-z0-9_]*)(:[a-z]+)?([.][a-z_][a-z0-9_]*)?([.][a-z_][a-z0-9_]*)?)';
		$reg_id.='[[:space:]]*';

		$YYCURSOR = 0;
		while (isset($this->_SCAN_WS[$YYBUFFER[$YYCURSOR]])) {
			$YYCURSOR++;
		}
		$value = '';
		$yych = $YYBUFFER[$YYCURSOR];

		if ($this->_SCAN_AZ[$yych]) {
			$value .= $yych;
			$yych = $YYBUFFER[++$YYCURSOR];
			while (isset($this->_SCAN_AZ_09[$yych])) {
				$value .= $yych;
				$yych = $YYBUFFER[++$YYCURSOR];
			}
			$match_1 = $value; $value = '';
			if ($yych === ':') {
				$yych = $YYBUFFER[++$YYCURSOR];
				while (isset($this->_SCAN_AZ[$yych])) {
					$value .= $yych;
					$yych = $YYBUFFER[++$YYCURSOR];
				}
				$record_id = $value; $value = '';
			}
			if ($yych === '.') {
				$yych = $YYBUFFER[++$YYCURSOR];
				if ($this->_SCAN_AZ[$yych]) {
					$value .= $yych;
					$yych = $YYBUFFER[++$YYCURSOR];
					while (isset($this->_SCAN_AZ_09[$yych])) {
						$value .= $yych;
						$yych = $YYBUFFER[++$YYCURSOR];
					}
				}
				$match_2 = $value; $value = '';
			}
			if ($yych === '.') {
				$yych = $YYBUFFER[++$YYCURSOR];
				if ($this->_SCAN_AZ[$yych]) {
					$value .= $yych;
					$yych = $YYBUFFER[++$YYCURSOR];
					while (isset($this->_SCAN_AZ_09[$yych])) {
						$value .= $yych;
						$yych = $YYBUFFER[++$YYCURSOR];
					}
				}
				$match_3 = $value; $value = '';

$value is not used, you could remove the assignment.

			}

		}


		if($match_1) {
			if (!$match_2) {

The variable $match_2 does not seem to be defined for all execution paths leading up to this point.

				/* default table is 'object' */
				$match_2 = $match_1;

The variable $match_1 does not seem to be defined for all execution paths leading up to this point.

				$match_1 = "object";
			}
			$node["id"]="ident";

$node was never initialized. Although not strictly required by PHP, it is generally a good practice to add $node = array(); before regardless.

			$table=$match_1;
			$field=$match_2;
			if ($table=="object") {
				switch ($field) {
					case "implements":
						$node["id"]="implements";
					break;
					case "path":
					case "parent":
					case "priority":
						$node["table"]="nodes";
						$node["field"]=$field;
					break;
					default:
						$node["table"]="objects";
						$node["field"]=$field;
				}
			} else
			if ($table === "my") {
				$node["id"] = "custom";
				if ($match_3) {
					$node["nls"] = $field;
					$field = $match_3;

The variable $match_3 does not seem to be defined for all execution paths leading up to this point.

				}
				$node["field"] = $field;
				$node["record_id"] = $record_id;

The variable $record_id does not seem to be defined for all execution paths leading up to this point.

			} else {
				$node["id"]="property";
				if ($match_3) {
					$node["nls"] = $field;
					$field = $match_3;
				}
				$node["table"]="prop_".$table;
				$node["field"]="AR_".$field;
				$node["record_id"] = $record_id;
			}
		}
		$YYBUFFER = substr($YYBUFFER, $YYCURSOR);
		return $node;

The variable $node does not seem to be defined for all execution paths leading up to this point.

	}