ar_http

Complexity

Total Complexity

28

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

25.86%

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__set()	0	5	2
C	__get()	0	22	7
C	getvar()	0	35	12
A	request()	0	4	1
A	client()	0	3	1
A	configure()	0	7	2
A	header()	0	3	1
A	get()	0	3	1
A	post()	0	3	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 10 and the first side effect is on line 3.

	ar_pinp::allow( 'ar_http');
	ar_pinp::allow( 'ar_httpClientStream' );

	/*
	 * prevent mess detector from warning for the private static fields
	 * @SuppressWarnings(PHPMD.UnusedPrivateField)
	 */
	class ar_http extends arBase {

		private static $_GET, $_POST, $_REQUEST, $_SERVER, $_COOKIE;  //needed to make __get() work

The property $_GET is not used and could be removed.

The property $_POST is not used and could be removed.

The property $_REQUEST is not used and could be removed.

The property $_SERVER is not used and could be removed.

The property $_COOKIE is not used and could be removed.

It is generally advisable to only define one property per statement.

		public static $tainting = true;

		public function __get($var) {
			switch ($var) {
				case '_GET' :

There must be no space before the colon in a CASE statement

					return $this->getvar( null, 'GET');
				break;
				case '_POST' :

There must be no space before the colon in a CASE statement

					return $this->getvar( null, 'POST');
				break;
				case '_REQUEST' :

There must be no space before the colon in a CASE statement

					return $this->getvar();
				break;
				case '_SERVER' :

There must be no space before the colon in a CASE statement

					return $this->getvar( null, 'SERVER');
				break;
				case '_COOKIE' :

There must be no space before the colon in a CASE statement

					return $this->getvar( null, 'COOKIE');
				break;
				case 'tainting' :

There must be no space before the colon in a CASE statement

					return self::$tainting;
				break;
			}
		}

		public function __set( $var, $value ) {
			if ($var=='tainting') {
				self::$tainting = (bool) $value;
			}
		}

		public static function getvar( $name = null, $method = null) {

getvar uses the super-global variable $_GET which is generally not recommended.

getvar uses the super-global variable $_POST which is generally not recommended.

getvar uses the super-global variable $_COOKIE which is generally not recommended.

getvar uses the super-global variable $_SERVER which is generally not recommended.

getvar uses the super-global variable $_REQUEST which is generally not recommended.

			/*
				The full list of field-name characters that PHP converts to _ (underscore) is the following (not just dot):

				chr(32) ( ) (space)
				chr(46) (.) (dot)
				chr(91) ([) (open square bracket)
				chr(128) - chr(159) (various)
				PHP irreversibly modifies field names containing these characters in an attempt to maintain compatibility with the deprecated register_globals feature.
			*/
			$name = preg_replace("/[ \.\[\x80-\x9f]/", "_", $name);

			switch($method) {
				case 'GET' :

There must be no space before the colon in a CASE statement

					$result = isset($name) ? $_GET[$name] : $_GET;
				break;
				case 'POST' :

There must be no space before the colon in a CASE statement

					$result = isset($name) ? $_POST[$name] : $_POST;
				break;
				case 'COOKIE' :

There must be no space before the colon in a CASE statement

					$result = isset($name) ? $_COOKIE[$name] : $_COOKIE;
				break;
				case 'SERVER' :

There must be no space before the colon in a CASE statement

					$result = isset($name) ? $_SERVER[$name] : $_SERVER;
				break;
				default :

There must be no space before the colon in a DEFAULT statement

					$result = !isset($name) ? $_REQUEST :
						( isset($_POST[$name]) ? $_POST[$name] : $_GET[$name] );
				break;
			}
			if (self::$tainting) {
				ar::taint( $result );
			}
			return $result;
		}

		public static function request( $method = null, $url = null, $postdata = null, $options = array() ) {
			$client = new ar_httpClientStream(); //$method, $url, $postdata, $port);

75% of this comment could be valid code. Did you maybe forget this after debugging?

			return $client->send( $method, $url, $postdata, $options );
		}

		public static function client( $options = array() ) {
			return new ar_httpClientStream( $options );
		}

		public static function configure( $option, $value ) {
			switch ( $option ) {
				case 'tainting' :

There must be no space before the colon in a CASE statement

					self::$tainting = $value;
				break;
			}
		}

		public static function header( $header ) {
			return ar_http_headers::header( $header );
		}

		public static function get( $url, $request = null, $options = array() ) {
			return self::request( 'GET', $url, $request, $options);
		}

		public static function post( $url, $request = null, $options = array() ) {
			return self::request( 'POST', $url, $request, $options);
		}

	}

	interface ar_httpClient {

PSR1 recommends that each class should be in its own file to aid autoloaders.

		public function get( $url, $request = null, $options = array() );

		public function post( $url, $request = null, $options = array() );

		public function put( $url, $request = null, $options = array() );

		public function delete( $url, $request = null, $options = array() );

		public function send( $type, $url, $request = null, $options = array() );

		public function headers( $headers );

	}

	class ar_httpClientStream extends arBase implements ar_httpClient {

Each interface must be in a file by itself

		private $options = array();

		public $responseHeaders = null;

		/* FIXME: function not used, is it still relevant?

50% of this comment could be valid code. Did you maybe forget this after debugging?

Comment refers to a FIXME task "function not used, is it still relevant?"

		private function parseRequestURL( $url ) {
			$request = explode( '?', (string) $url );
			if ( isset($request[1]) ) {
				return $request[1];
			} else {
				return null;
			}
		}
		*/

		private function compileRequest( array $request ) {
			$result = "";
			foreach ( $request as $key => $value ) {
				if ( !is_integer( $key ) ) {
					$result .= urlencode($key) . "=" . urlencode($value) . "&";
				}
			}
			return substr( $result, 0, -1);
		}

		private function mergeOptions( ) {
			$args = func_get_args();
			array_unshift( $args, $this->options );
			return call_user_func_array( 'array_merge', $args );
		}

		public function send( $type, $url, $request = null, $options = array() ) {
			if ( is_array( $request ) ) {
				$request = $this->compileRequest( $request );
			}
			$options = $this->mergeOptions( array(
				'method' => $type,
				'content' => $request
			), $options );

			if ( $options['method'] == 'GET' && $options['content'] ) {
				if ( strpos( $url, '?' ) === false ) {
					$url = $url . '?' . $options['content'];
				} else {
					$url = $url . '&' . $options['content'];
				}
				$options['content'] = '';
			}
			$context = stream_context_create( array( 'http' => $options ) );
			$result = @file_get_contents( (string) $url, false, $context );

			$this->responseHeaders = $http_response_header; //magic php variable set by file_get_contents.
			if (is_array($this->responseHeaders) && isset($this->responseHeaders[0])) {
				$statusLine = explode(" ", $this->responseHeaders[0]);
				$this->statusCode = $statusLine[1];

The property statusCode does not exist. Did you maybe forget to declare it?

			}

			$this->requestHeaders = $options['header'];

The property requestHeaders does not exist. Did you maybe forget to declare it?

			return $result;
		}

		public function __construct( $options = array() ) {
			$this->options = $options;
		}

		public function get( $url, $request = null, $options = array() ) {
			return $this->send( 'GET', $url, $request, $options );
		}

		public function post( $url, $request = null, $options = array() ) {
			return $this->send( 'POST', $url, $request, $options );
		}

		public function put( $url, $request = null, $options = array() ) {
			return $this->send( 'PUT', $url, $request, $options );
		}

		public function delete( $url, $request = null, $options = array() ) {
			return $this->send( 'DELETE', $url, $request, $options );
		}

		public function headers( $headers ) {
			if (is_array($headers)) {
				$headers = join("\r\n", $headers);
			}
			$this->options['header'] = $this->options['headers'].$headers;
			return $this;
		}
	}