cache

Complexity

Total Complexity

17

Size/Duplication

Total Lines	93
Duplicated Lines	32.26 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

39.13%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	3	1
A	__construct()	0	7	1
C	save()	0	35	8
A	onTemplateSaved()	15	15	2
A	onObjectSaved()	15	15	2
A	invalidate()	0	11	3

<?php
	class cache {
		public function __construct($cache_config) {
			debug("cache([array])","store");
			// init cache store
			$inst_store = $cache_config["dbms"]."store";
			include_once($cache_config["code"]."stores/$inst_store.phtml");
			$this->cachestore=new $inst_store($cache_config["root"], $cache_config);

The property cachestore does not exist. Did you maybe forget to declare it?

		}

		public function save($filename, $objectChain, $templateChain) {
			if (!is_array($objectChain)) {
				return false;
			}
			if (!is_array($templateChain)) {
				return false;
			}
			if ( !$this->cachestore->exists('/') ) {
				$this->cachestore->save( '/', 'pobject', new object );
			}

			$data = new object;
			$data->filename = $filename;

The property filename does not seem to exist in object.

			$data->objectChain = $objectChain;

The property objectChain does not seem to exist in object.

			$data->templateChain = $templateChain;

The property templateChain does not seem to exist in object.

                        $properties = array();
			$properties["objectref"] = array();
			$properties["template"] = array();

			foreach ($objectChain as $id => $value) {
				$properties["objectref"][] = array("name" => "id", "value" => $id);
			}
			foreach ($templateChain as $id => $template) {
				foreach ($template as $name => $value) {
					foreach ($value as $type => $dummy) {
						$properties["template"][] = array("name" => "name", "value" => $id . ":" . $type . ":" . $name);
					}
				}
			}

			$this->cachestore->save("/" . md5($filename) . "/", "pcache", $data, $properties);

			// $onsave = $this->onTemplateSaved("1944", "ppage", "ppage.view.div1.html.any");

62% of this comment could be valid code. Did you maybe forget this after debugging?

		}

		public function onTemplateSaved($id, $type, $name) {

This method seems to be duplicated in your project.

			$query = "template.value='$id:$type:$name' order by none";
			$objects = $this->cachestore->find("/", $query, 0, 0);

			$template = function($object) {
				return $object->data->filename;
			};

			$result = $this->cachestore->call($template,array(),$objects);
			$result = array_unique($result);

			foreach ($result as $filename) {
				$this->invalidate($filename);
			}
		}

		public function onObjectSaved($id) {

This method seems to be duplicated in your project.

			$query = "objectref.value='$id' order by none";
			$objects = $this->cachestore->find("/", $query, 0, 0);

			$template = function($object) {
				return $object->data->filename;
			};

			$result = $this->cachestore->call($template,array(),$objects);
			$result = array_unique($result);

			foreach ($result as $filename) {
				$this->invalidate($filename);
			}
		}

		public function invalidate($filename) {
			global $store;
			$absFilename = $store->get_config("files")."cache/".$filename;
			$stamp = time();

			if (file_exists($absFilename)) {
				if (filemtime($absFilename) > $stamp + 2) {  // do not touch file which will expire soon
					touch($absFilename, $stamp + 1); // set mtime to now; this means the cache image is now invalid;
				}
			}
		}

		public function delete($filename) {
			$this->cachestore->delete("/" . md5($filename) . "/");
		}
	}
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.