ar_urlQuery

Complexity

Total Complexity

17

Size/Duplication

Total Lines	70
Duplicated Lines	17.14 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	__setQuery()	0	5	2
A	__call()	12	12	3
A	__get()	0	3	1
A	__set()	0	3	1
A	getvar()	0	3	1
A	putvar()	0	3	1
A	__toString()	0	3	1
A	import()	0	3	1
A	offsetExists()	0	3	1
A	offsetGet()	0	3	1
A	offsetSet()	0	3	1
A	offsetUnset()	0	3	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 7 and the first side effect is on line 3.

	ar_pinp::allow( 'ar_url');
	ar_pinp::allow( 'ar_urlQuery' );
	use \arc\url;

This use statement conflicts with another class in this namespace, url.

	class ar_url extends arBase implements arKeyValueStoreInterface {

		private $url, $query;

It is generally advisable to only define one property per statement.

		public function __construct( $url ) {
			$query = new \arc\url\PHPQuery();
			$this->url = new \arc\url\Url($url, $query);
			$this->query = new ar_urlQuery($query);
		}

		public function __get($var) {
			if ($var=='password') {
				$var = 'pass';
			}
			if ($var=='query') {
				return $this->query;
			} else if ( isset( $this->url->{$var} ) ) {
				return $this->url->{$var};
			} else {
				return null;
			}
		}

		public function __set($var, $value) {
			switch($var) {
				case 'query' :

There must be no space before the colon in a CASE statement

					if (is_string($value)) {
						$this->url->query = $value;
						$this->query = new ar_urlQuery($this->url->query);
					} else if ($value instanceof ar_urlQuery) {
						$this->url->query = (string) $value;
					} else if (is_object($value) && method_exists($value, '__toString') ) {
						$this->url->query = (string)$value;
					}
				break;
				case 'password' :

There must be no space before the colon in a CASE statement

There must be a comment when fall-through is intentional in a non-empty case body

					$var = 'pass';
				case 'path' :

There must be no space before the colon in a CASE statement

				case 'scheme':
				case 'host' :

There must be no space before the colon in a CASE statement

				case 'port' :

There must be no space before the colon in a CASE statement

				case 'user' :

There must be no space before the colon in a CASE statement

				case 'pass' :

There must be no space before the colon in a CASE statement

				case 'fragment' :

There must be no space before the colon in a CASE statement

					return $this->url->{$var} = $value;
				break;
			}
		}

		public function __toString() {
			return (string)$this->url;
		}

		public function getvar( $name ) {
			return $this->query->$name;
		}

		public function putvar( $name, $value ) {
			$this->query->{$name} = $value;
		}

		public function import( $values ) {
			$this->query->import( $values );
		}

	}

	class ar_urlQuery implements arKeyValueStoreInterface, ArrayAccess /*, ArrayAcces, IteratorAggregate, .. */ {

PSR1 recommends that each class should be in its own file to aid autoloaders.

		private $query;

		public function __construct( $query ) {
			if ( $query instanceof \arc\url\Query ){
				$this->query  = $query;
			} else {
				$this->query = new \arc\url\PHPQuery($query);
			}
		}

		public function __setQuery($url, $query) {
			if ( $url->query === $this->query ) {
				$url->query = $this->query = $query->query;
			}
		}

		public function __call( $name, $arguments ) {

This method seems to be duplicated in your project.

			if (($name[0]==='_')) {
				$realName = substr($name, 1);
				if (ar_pinp::isAllowed($this, $realName)) {
					return call_user_func_array(array($this, $realName), $arguments);
				} else {
					trigger_error("Method $realName not found in class ".get_class($this), E_USER_WARNING);
				}
			} else {
				trigger_error("Method $name not found in class ".get_class($this), E_USER_WARNING);
			}
		}

		public function __get( $name ) {
			return $this->query->{$name};
		}

		public function __set( $name, $value ) {
			$this->query->{$name} = $value;
		}

		public function getvar( $name ) {
			return $this->query->{$name};
		}

		public function putvar( $name, $value ) {
			$this->query->{$name} = $value;
		}

		public function __toString() {
			return (string)$this->query;
		}

		public function import( $values ) {
			$this->query->import( $values );
		}

		public function offsetExists($name){
			return isset($this->query->{$name});
		}

		public function offsetGet($name) {
			return $this->query->{$name};
		}

		public function offsetSet($name, $value) {
			$this->query->{$name} = $value;
		}
		public function offsetUnset($name) {
			unset($this->query->{$name});
		}

	}