ar_template_filesystem::ls() - Code Metrics - Inspection of "Rework of getPinpTemplate and supporting functions" - Ariadne-CMS/ariadne - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#117)

by Robbert

created 2016-05-27 12:16 UTC

ar_template_filesystem::ls() C

↳ Parent: ar_template_filesystem

Complexity

Conditions	12
Paths	5

Size

Total Lines	64
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	12
eloc	47
c	1
b	0
f	1
nc	5
nop	1
dl	0
loc	64
rs	6.0561

How to fix Long Method Complexity

<?php

	use arc\path as path;

	class ar_template_filesystem extends arBase {
		private $path;
		private $config;

		public function __construct($path, $config ) {
			$this->path   = path::collapse($path);
			$this->config = $config;
			$this->config['path'] = path::collapse($config['path']);
		}

		public function get($path, $name){
			$arpath = path::collapse($path);

			if ( strpos($arpath, $this->path, 0) !== 0) {
				return ar('error')->raiseError('invalide path for loading template',500);
			}

			$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
			$realpath = realpath($realpath) .'/';

			// FIXME 'netjes' een path opzoeken hier voor

			$cachepath = sha1($path . $name);
			$cacheroot = '/home/muller/devel/site/files/temp/';
			if ( 
				! file_exists( $cacheroot . $cachepath )  ||
				( filemtime($cacheroot . $cachepath ) < filemtime ( $realpath  . $name ) )
			) {
				$compiled = $this->compile($path, $name);
				file_put_contents($cacheroot . $cachepath, $compiled);
			}
			include (  $cacheroot . $cachepath );
			return $arTemplateFunction;

		}

		public function save($path, $name, $template, $local=null, $private=null) {

			return false;
		}

		public function load($path, $name) {

			$arpath = path::collapse($path);

			if ( strpos($arpath, $this->path, 0) !== 0) {
				return ar('error')->raiseError('invalide path for loading template',500);
			}

			$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
			$realpath = realpath($realpath) .'/';

			return file_get_contents($realpath . $name);
		}

		public function ls($path) {
			$arpath = path::collapse($path);

			if ( strpos($arpath, $this->path, 0) !== 0) {
				return [];
			}
			$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
			$realpath = realpath($realpath) .'/';
			$config = json_decode(file_get_contents($realpath . 'library.json'),true);
			if(!isset($config['exports']) ) {
				$config['exports'] = [];
			}
			if(!isset($config['local']) ) {
				$config['local'] = [];
			}

			$result = [];

			$traverseDir = function ($path, $type = 'pobject', $nls = 'any') use ($arpath, &$result, $config, &$traverseDir, $realpath) {
				$path = path::collapse($path);
				$index = scandir($path, SCANDIR_SORT_NONE);
				if($index !== false) {
					list($maintype, $subtype) = explode('.', $type,2);
					foreach($index as $filename) {
						if($filename[0] === "." ) {
							continue;
						}
						$filepath = $path . $filename;
						if ( is_dir($filepath) ) {
							if (strlen($filename) == 2) {
								$traverseDir(path::collapse($filename, $path), $type, $filename);
							} else {
								$traverseDir(path::collapse($filename, $path), $filename);
							}
						} else if ( is_file($filepath) ) {
							$tempname = sprintf("%s.%s.%s",$type,$filename,$nls);
							$confname = sprintf("%s::%s",$type,$filename);
							$private = true;
							if (isset( $config['exports'] ) ) {
								$private = ! in_array($confname, $config['exports']);
							}
							$local = false;
							if (isset( $config['local'] ) ) {
								$local = in_array($confname, $config['local']);
							}
							$result[$filename][] = [
								'id'       => PHP_INT_MAX,
								'path'     => $arpath,
								'type'     => $maintype,
								'subtype'  => $subtype,
								'name'     => $tempname,
								'filename' => substr($filepath,strlen($realpath)),
								'language' => $nls,
								'private'  => $private,
								'local'    => $local,
							];
						}
					}
				}

			};
			$traverseDir($realpath . 'src/');
			return $result;
		}

		public function rm($path, $name){

		}

		public function exists($path, $name) {

			$arpath = path::collapse($path);

			if ( strpos($arpath, $this->path, 0) !== 0) {
				return ar('error')->raiseError('invalide path for loading template',500);
			}

			$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
			$realpath = realpath($realpath) .'/';
			return file_exists($realpath . $name);
		}

		public function compile($path, $name) {
			global $AR;
			$arpath = path::collapse($path);

			if ( strpos($arpath, $this->path, 0) !== 0) {
				return ar('error')->raiseError('invalide path for loading template',500);
			}

			$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
			$realpath = realpath($realpath) .'/';

			$template = file_get_contents($realpath . $name);

			require_once(AriadneBasePath."/modules/mod_pinp.phtml");

			$pinp = new pinp($AR->PINP_Functions, "local->", "\$AR_this->_");

			// FIXME error checking

			$compiled = $pinp->compile(strtr($template,"\r",""));
			$compiled = sprintf($AR->PINPtemplate, $compiled);
			return $compiled;

		}
	}


1		<?php
2
3		use arc\path as path;
4
5		class ar_template_filesystem extends arBase {
6		private $path;
7		private $config;
8
9		public function __construct($path, $config ) {
10		$this->path = path::collapse($path);
11		$this->config = $config;
12		$this->config['path'] = path::collapse($config['path']);
13		}
14
15		public function get($path, $name){
16		$arpath = path::collapse($path);
17
18		if ( strpos($arpath, $this->path, 0) !== 0) {
19		return ar('error')->raiseError('invalide path for loading template',500);
20		}
21
22		$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
23		$realpath = realpath($realpath) .'/';
24
25		// FIXME 'netjes' een path opzoeken hier voor
		0 ignored issues – show Coding Style introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report Comment refers to a FIXME task "'netjes' een path opzoeken hier voor" Loading history...
26		$cachepath = sha1($path . $name);
27		$cacheroot = '/home/muller/devel/site/files/temp/';
28		if (
29		! file_exists( $cacheroot . $cachepath ) \|\|
30		( filemtime($cacheroot . $cachepath ) < filemtime ( $realpath . $name ) )
31		) {
32		$compiled = $this->compile($path, $name);
33		file_put_contents($cacheroot . $cachepath, $compiled);
34		}
35		include ( $cacheroot . $cachepath );
36		return $arTemplateFunction;
		0 ignored issues – show Bug introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The variable `$arTemplateFunction` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
37		}
38
39		public function save($path, $name, $template, $local=null, $private=null) {
		0 ignored issues – show Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$path` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$template` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$local` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$private` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40		return false;
41		}
42
43	View Code Duplication	public function load($path, $name) {
		0 ignored issues – show Duplication introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		$arpath = path::collapse($path);
45
46		if ( strpos($arpath, $this->path, 0) !== 0) {
47		return ar('error')->raiseError('invalide path for loading template',500);
48		}
49
50		$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
51		$realpath = realpath($realpath) .'/';
52
53		return file_get_contents($realpath . $name);
54		}
55
56		public function ls($path) {
57		$arpath = path::collapse($path);
58
59		if ( strpos($arpath, $this->path, 0) !== 0) {
60		return [];
61		}
62		$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
63		$realpath = realpath($realpath) .'/';
64		$config = json_decode(file_get_contents($realpath . 'library.json'),true);
65		if(!isset($config['exports']) ) {
66		$config['exports'] = [];
67		}
68		if(!isset($config['local']) ) {
69		$config['local'] = [];
70		}
71
72		$result = [];
73
74		$traverseDir = function ($path, $type = 'pobject', $nls = 'any') use ($arpath, &$result, $config, &$traverseDir, $realpath) {
75		$path = path::collapse($path);
76		$index = scandir($path, SCANDIR_SORT_NONE);
77		if($index !== false) {
78		list($maintype, $subtype) = explode('.', $type,2);
79		foreach($index as $filename) {
80		if($filename[0] === "." ) {
81		continue;
82		}
83		$filepath = $path . $filename;
84		if ( is_dir($filepath) ) {
85		if (strlen($filename) == 2) {
86		$traverseDir(path::collapse($filename, $path), $type, $filename);
87		} else {
88		$traverseDir(path::collapse($filename, $path), $filename);
89		}
90		} else if ( is_file($filepath) ) {
91		$tempname = sprintf("%s.%s.%s",$type,$filename,$nls);
92		$confname = sprintf("%s::%s",$type,$filename);
93		$private = true;
94		if (isset( $config['exports'] ) ) {
95		$private = ! in_array($confname, $config['exports']);
96		}
97		$local = false;
98		if (isset( $config['local'] ) ) {
99		$local = in_array($confname, $config['local']);
100		}
101		$result[$filename][] = [
102		'id' => PHP_INT_MAX,
103		'path' => $arpath,
104		'type' => $maintype,
105		'subtype' => $subtype,
106		'name' => $tempname,
107		'filename' => substr($filepath,strlen($realpath)),
108		'language' => $nls,
109		'private' => $private,
110		'local' => $local,
111		];
112		}
113		}
114		}
115
116		};
117		$traverseDir($realpath . 'src/');
118		return $result;
119		}
120
121		public function rm($path, $name){
		0 ignored issues – show Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$path` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
122		}
123
124	View Code Duplication	public function exists($path, $name) {
		0 ignored issues – show Duplication introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
125		$arpath = path::collapse($path);
126
127		if ( strpos($arpath, $this->path, 0) !== 0) {
128		return ar('error')->raiseError('invalide path for loading template',500);
129		}
130
131		$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
132		$realpath = realpath($realpath) .'/';
133		return file_exists($realpath . $name);
134		}
135
136		public function compile($path, $name) {
137		global $AR;
138		$arpath = path::collapse($path);
139
140		if ( strpos($arpath, $this->path, 0) !== 0) {
141		return ar('error')->raiseError('invalide path for loading template',500);
142		}
143
144		$realpath = $this->config['path'] . substr($arpath,strlen($this->path));
145		$realpath = realpath($realpath) .'/';
146
147		$template = file_get_contents($realpath . $name);
148
149		require_once(AriadneBasePath."/modules/mod_pinp.phtml");
150
151		$pinp = new pinp($AR->PINP_Functions, "local->", "\$AR_this->_");
152
153		// FIXME error checking
		0 ignored issues – show Coding Style introduced 2016-05-20 15:31 UTC by Report Bug Copy Issue Report Comment refers to a FIXME task "error checking" Loading history...
154		$compiled = $pinp->compile(strtr($template,"\r",""));
155		$compiled = sprintf($AR->PINPtemplate, $compiled);
156		return $compiled;
157
158		}
159		}
160

Ariadne-CMS / ariadne

Pull Request — master (#117)

ar_template_filesystem::ls() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like