Ariadne-CMS /
ariadne
| Conditions | 23 |
| Paths | > 20000 |
| Total Lines | 51 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | function display_perms( $mode ) { |
||
| 84 | /* Determine Type */ |
||
| 85 | if( $mode & 0x1000 ) { |
||
| 86 | $type='p'; /* FIFO pipe */ |
||
| 87 | } else if( $mode & 0x2000 ) { |
||
| 88 | $type='c'; /* Character special */ |
||
| 89 | } else if( $mode & 0x4000 ) { |
||
| 90 | $type='d'; /* Directory */ |
||
| 91 | } else if( $mode & 0x6000 ) { |
||
| 92 | $type='b'; /* Block special */ |
||
| 93 | } else if( $mode & 0x8000 ) { |
||
| 94 | $type='-'; /* Regular */ |
||
| 95 | } else if( $mode & 0xA000 ) { |
||
| 96 | $type='l'; /* Symbolic Link */ |
||
| 97 | } else if( $mode & 0xC000 ) { |
||
| 98 | $type='s'; /* Socket */ |
||
| 99 | } else { |
||
| 100 | $type='u'; /* UNKNOWN */ |
||
| 101 | } |
||
| 102 | |||
| 103 | /* Determine permissions */ |
||
| 104 | $owner = array(); |
||
| 105 | $group = array(); |
||
| 106 | $world = array(); |
||
| 107 | |||
| 108 | $owner["read"] = ($mode & 00400) ? 'r' : '-'; |
||
| 109 | $owner["write"] = ($mode & 00200) ? 'w' : '-'; |
||
| 110 | $owner["execute"] = ($mode & 00100) ? 'x' : '-'; |
||
| 111 | $group["read"] = ($mode & 00040) ? 'r' : '-'; |
||
| 112 | $group["write"] = ($mode & 00020) ? 'w' : '-'; |
||
| 113 | $group["execute"] = ($mode & 00010) ? 'x' : '-'; |
||
| 114 | $world["read"] = ($mode & 00004) ? 'r' : '-'; |
||
| 115 | $world["write"] = ($mode & 00002) ? 'w' : '-'; |
||
| 116 | $world["execute"] = ($mode & 00001) ? 'x' : '-'; |
||
| 117 | |||
| 118 | /* Adjust for SUID, SGID and sticky bit */ |
||
| 119 | if( $mode & 0x800 ) { |
||
| 120 | $owner["execute"] = ($owner['execute']=='x') ? 's' : 'S'; |
||
| 121 | } |
||
| 122 | if( $mode & 0x400 ) { |
||
| 123 | $group["execute"] = ($group['execute']=='x') ? 's' : 'S'; |
||
| 124 | } |
||
| 125 | if( $mode & 0x200 ) { |
||
| 126 | $world["execute"] = ($world['execute']=='x') ? 't' : 'T'; |
||
| 127 | } |
||
| 128 | |||
| 129 | printf("%1s", $type); |
||
| 130 | printf("%1s%1s%1s", $owner['read'], $owner['write'], $owner['execute']); |
||
| 131 | printf("%1s%1s%1s", $group['read'], $group['write'], $group['execute']); |
||
| 132 | printf("%1s%1s%1s\n", $world['read'], $world['write'], $world['execute']); |
||
| 133 | } |
||
| 134 | |||
| 144 |
Loading history...
An exit expression should only be used in rare cases. For example, if you write a short command line script.
In most cases however, using an
exitexpression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.