ar_pinp

Complexity

Total Complexity

26

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

32.84%

7 Methods

Rating	Name	Duplication	Size	Complexity
A	allow()	0	11	3
A	allowMatch()	0	3	1
C	isAllowed()	0	23	9
A	getCallback()	0	19	4
A	load()	0	4	1
B	loaded()	0	18	5
A	exists()	0	12	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 2 and the first side effect is on line 104.

	class ar_pinp extends arBase {

		private static $allowed;

		public static function allow($class, $methods = null) {
			if (isset($methods)) {
				self::$allowed[$class]['methods'] = array_combine( $methods, array_fill( 0, count($methods), true ) );
				if (func_num_args()>2) {
					$args = array_slice(func_get_args(), 2);
					self::$allowed[$class]['implements'] = $args;
				}
			} else {
				self::$allowed[$class]['methods'] = true;
			}
		}

		public static function allowMatch($class, $methods) {
			self::$allowed[$class]['matches'] = array_combine( $methods, array_fill( 0, count($methods), true ) );
		}

		public static function isAllowed($class, $method) {
			// FIXME: support interfaces?

Comment refers to a FIXME task "support interfaces?"

			if (!is_string($class)) {
				$class = get_class($class);
			}
			$current = $class;
			do {
				if (isset(self::$allowed[$current]) ) {
					if (self::$allowed[$current]['methods']===true) {
						return true;
					} else if (isset(self::$allowed[$current]['methods'][$method])
						&& self::$allowed[$current]['methods'][$method]) {
						return true;
					} else if (isset(self::$allowed[$current]['matches'])) {
						$result = preg_match( '/(' . implode ( '|', self::$allowed[$current]['matches']) . ')/is',  $method );
						if ($result) {
							return true;
						}
					}
				}
			} while ($current = get_parent_class($current));
			return false;
		}

		public static function getCallback( $method, $params = array() ) {
			if (is_string($method)) {
				return function() use ( $params, $method ) {
					$me = ar::context()->getObject();

$me is not used, you could remove the assignment.

					$args_in = func_get_args();
					if (count($params)) {
						$args = array();
						foreach($params as $key => $arg) {
							$args[$arg] = $args_in[$key];
						}
					} else {
						$args = $args_in;
					}
					return ar::call($method, $args);
				};
			} else {
				return false;
			}
		}

		public static function load( $name, $library ) {
			$context = ar::context()->getObject();
			return $context->loadLibrary( $name, $library );
		}

		public static function loaded( $name = null, $library = null ) {
			global $ARConfig;
			// return if a library with that name is loaded
			// if library is set will also check if it is the same path
			$context = ar::context()->getObject();
			$path = $context->path;
			$config = $ARConfig->cache[$path] ?: $context->loadConfig($path);
			if ( isset($name) ) {
				$libraryPath = $config->libraries[$name] ?: null;
				if ( isset($library) ) {
					return ($libraryPath == $library );
				} else {
					return $libraryPath;
				}
			} else {
				return $config->libraries;
			}
		}

		public static function exists( $template ) {
			// will check if a template with the given name is available to call
			// template has format "library:type::function"
			// FIXME: allow search for specific nls as well

Comment refers to a FIXME task "allow search for specific nls as well"

			$context = ar::context()->getObject();
			$templateData = $context->getPinpTemplate($template);
			if ( !$templateData || !$templateData['arTemplateId'] ) {
				return false;
			} else {
				return $templateData;
			}
		}
	}

	ar_pinp::allow('ar_pinp', array('isAllowed', 'getCallback', 'load', 'loaded', 'exists'));