+global\ariadne_object::HTTPRequest()

Complexity

Conditions	25
Paths	144

Size

Total Lines

104

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	650

Importance

Changes

0

<?php
	public function HTTPRequest($method, $url, $postdata = "", $port=80 ) {
		$maxtries = 5;
		$tries = 0;
		$redirecting = true;

		if(isset($postdata) && is_array($postdata)) {
			foreach($postdata as $key=>$val) {
				if(!is_integer($key)) {
					$data .= "$key=".urlencode($val)."&";

The variable $data does not seem to be defined for all execution paths leading up to this point.

				}
			}
		} else {
			$data = $postdata;
		}

		while ($redirecting && $tries < $maxtries) {
			$tries++;
			// get host name and URI from URL, URI not needed though
			preg_match("/^([htps]*:\/\/)?([^\/]+)(.*)/i", $url, $matches);
			$host = $matches[2];
			$uri = $matches[3];
			if (!$matches[1]) {
				$url="http://".$url;
			}
			$connection = @fsockopen( $host, $port, $errno, $errstr, 120);
			if( $connection ) {
				if( strtoupper($method) == "GET" ) {
					if ($data) {

The expression $data of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

						$uri .= "?" . $data;
					}
					fputs( $connection, "GET $uri HTTP/1.0\r\n");
				} else if( strtoupper($method) == "POST" ) {
					fputs( $connection, "POST $uri HTTP/1.0\r\n");
				} else {
					fputs( $connection, "$method $uri HTTP/1.0\r\n");
				}

				fputs( $connection, "Host: $host\r\n");
				fputs( $connection, "Accept: */*\r\n");
				fputs( $connection, "Accept: image/gif\r\n");
				fputs( $connection, "Accept: image/x-xbitmap\r\n");
				fputs( $connection, "Accept: image/jpeg\r\n");

				if( strtoupper($method) == "POST" ) {
					$strlength = strlen( $data);
					fputs( $connection, "Content-type: application/x-www-form-urlencoded\r\n" );
					fputs( $connection, "Content-length: ".$strlength."\r\n\r\n");
					fputs( $connection, $data."\r\n");
				}

				fputs( $connection, "\r\n" , 2);

				$headerContents = '';
				$headerStart = 0;
				$headerEnd = 0;
				$redirecting = false;

				while (!feof($connection)) {
					$currentLine = fgets ($connection, 1024);
					if ($headerEnd && $redirecting) {
						break;
					} else if ($headerEnd && !$redirecting) {
						//this is the html from the page
						$contents = $contents . $currentLine;

The variable $contents does not seem to be defined for all execution paths leading up to this point.

					} else if ( preg_match("/^HTTP/", $currentLine) ) {
						//came to the start of the header
						$headerStart = 1;
						$headerContents = $currentLine;
					} else if ( $headerStart && preg_match('/^[\n\r\t ]*$/', $currentLine) ) {
						//came to the end of the header
						$headerEnd = 1;
					} else {
						//this is the header, if you want it...
						if (preg_match("/^Location: (.+?)\n/is",$currentLine,$matches) ) {
							$headerContents .= $currentLine;
							//redirects are sometimes relative
							$newurl = $matches[1];
							if (!preg_match("/http:\/\//i", $newurl, $matches) ) {
								$url .= $newurl;
							} else {
								$url = $newurl;
							}
							//extra \r's get picked up sometimes
							//i think only with relative redirects
							//this is a quick fix.
							$url = preg_replace("/\r/s","",$url);
							$redirecting = true;
						} else {
							$headerContents.=$currentLine;
						}
					}
				}
			} else {
				$this->error="$errstr ($errno)";
				$contents=false;
				$url = "";
			}
			@fclose($connection);
		}
		if (($method!="GET") && ($method!="POST")) {
			$contents=$headerContents."\n".$contents;

The variable $headerContents does not seem to be defined for all execution paths leading up to this point.

		}
		return $contents;
	}