arc\http\ClientStream

Complexity

Total Complexity

19

Size/Duplication

Total Lines	146
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

89.66%

Importance

Changes	10
Bugs	4	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	4	1
A	delete()	0	4	1
B	mergeHeaders()	0	17	5
B	request()	0	29	5
A	post()	0	4	1
A	put()	0	4	1
A	headers()	0	16	4

<?php

/*
 * This file is part of the Ariadne Component Library.
 *
 * (c) Muze <info@muze.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace arc\http;

/**
 * Class ClientStream
 * Implements a HTTP client using PHP's stream handling.
 * @package arc\http
 */
class ClientStream implements Client
{
    private $options = ['headers' => []];

    public $responseHeaders = null;
    public $requestHeaders = null;

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

    /**
     * Merges header string and headers array to single string with all headers
     * @return string
     */
    private function mergeHeaders() {
        $args = func_get_args();

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $result = '';
        foreach ( $args as $headers ) {
            if (is_array($headers) || $headers instanceof \ArrayObject ) {
                $result .= array_reduce( (array) $headers, function($carry, $entry) {
                    return $carry . "\r\n" . $entry;
                }, '');
            } else {
                $result .= (string) $headers;
            }
        }
        if (substr($result, -2)!="\r\n") {
            $result .= "\r\n";
        }
        return $result;
    }

    /**
     * Send a HTTP request and return the response
     * @param string       $method  The method to use, GET, POST, etc.

There is no parameter named $method. Was it maybe removed?

     * @param string       $url     The URL to request
     * @param array|string $request The query string
     * @param array        $options Any of the HTTP stream context options, e.g. extra headers.
     * @return string
     */
    public function request( $type, $url, $request = null, $options = [] )
    {
        $url = \arc\url::url( (string) $url);
        if ($type == 'GET' && $request) {
            $url->query->import( $request);

The property $query is declared private in arc\url\Url. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

            $request = null;
        }

        $options = [
            'method' => $type,
            'content' => $request
        ] + $options;

        $options['headers'] = $this->mergeHeaders(
            \arc\hash::get('header', $this->options),
            \arc\hash::get('headers', $this->options),
            \arc\hash::get('header', $options),
            \arc\hash::get('headers', $options)
        );

        $options += (array) $this->options;

        $context = stream_context_create( [ 'http' => $options ] );

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space

        $result  = @file_get_contents( (string) $url, false, $context );

Equals sign not aligned with surrounding assignments; expected 16 spaces but found 2 spaces

        $this->responseHeaders = isset($http_response_header) ? $http_response_header : null; //magic php variable set by file_get_contents.
        $this->requestHeaders  = isset($options['headers']) ? explode("\r\n",$options['headers']) : [];

        return $result;
    }

    /**
     * @param array $options Any of the HTTP stream context options, e.g. extra headers.
     */
    public function __construct( $options = [] )
    {
        $this->options = $options;
    }

    /**
     * Send a GET request
     * @param string         $url     The URL to request
     * @param array|string   $request The query string
     * @param array          $options Any of the HTTP stream context options, e.g. extra headers.
     * @return string
     */
    public function get( $url, $request = null, $options = [] )
    {
        return $this->request( 'GET', $url, $request, $options );
    }

    /**
     * Send a POST request
     * @param string         $url     The URL to request
     * @param array|string   $request The query string
     * @param array          $options Any of the HTTP stream context options, e.g. extra headers.
     * @return string
     */
    public function post( $url, $request = null, $options = [] )
    {
        return $this->request( 'POST', $url, $request, $options );
    }

    /**
     * Send a PUT request
     * @param string         $url     The URL to request
     * @param array|string   $request The query string
     * @param array          $options Any of the HTTP stream context options, e.g. extra headers.
     * @return string
     */
    public function put( $url, $request = null, $options = [] )
    {
        return $this->request( 'PUT', $url, $request, $options );
    }

    /**
     * Send a DELETE request
     * @param string         $url     The URL to request
     * @param array|string   $request The query string
     * @param array          $options Any of the HTTP stream context options, e.g. extra headers.
     * @return string
     */
    public function delete( $url, $request = null, $options = [] )
    {
        return $this->request( 'DELETE', $url, $request, $options );
    }


    /**
     * Adds headers for subsequent requests
     * @param mixed $headers The headers to add, either as a string or an array of headers.
     * @return $this
     */
    public function headers($headers)
    {
        if (!isset($this->options['headers'])) {
            $this->options['headers'] = [];
        }
        if ( !is_array($headers) ) {
            $headers = explode("\r\n",$headers);
            if (end($headers) == '') {
                array_pop($headers);
            }
        }

        $this->options['headers'] = array_merge($this->options['headers'], $headers);

        return $this;
    }
}