Parser - Code Metrics - Inspection of "[WIP] Html encoding" - Ariadne-CMS/arc-html - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Robbert

created 2016-01-22 20:41 UTC

Parser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	77
Duplicated Lines	11.69 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

72%

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	15
c	3
b	0
f	1
lcom	1
cbo	2
dl	9
loc	77
ccs	36
cts	50
cp	0.72
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	parse()	0	15	4
A	__construct()	9	9	3
A	parsePartial()	0	10	2
B	parseFull()	0	32	6

How to fix Duplicated Code

<?php

namespace arc\html;

class Parser 
{
	public $options = [
		'libxml_options' => 0
	];

	public function __construct( $options = array() )

	{
		$optionList = [ 'libxml_options' ];
		foreach( $options as $option => $optionValue ) {
			if ( in_array( $option, $optionList ) ) {
				$this->{$option} = $optionValue;
			}
		}
	}

	public function parse( $html, $encoding = 'UTF-8' )
	{
		if ( !$html ) {
			return \arc\html\Proxy( null );
		}
		if ( $html instanceof Proxy ) { // already parsed
			return $html;
		}
		$html = (string) $html;
		if ( stripos($html, '<html>')!==false ) {
			return $this->parseFull( $html, $encoding );
		} else {		
			return $this->parsePartial( $html, $encoding );
		}
	}

	private function parsePartial( $html, $encoding = 'UTF-8' )
	{
		$result = $this->parseFull( '<div id="ArcPartialHTML">'.$html.'</div>', $encoding );
		if ( $result ) {
			$result = new \arc\html\Proxy( $result->find('#ArcPartialHTML')[0]->children(), $this );
		} else {
			throw new \arc\Exception('parse error');
		}
		return $result;
	}

	private function parseFull( $html, $encoding = 'UTF-8')
	{
		$dom = new \DomDocument('1.0', $encoding);
		$prefix = '';
		if ( isset($encoding) ) {
			$prefix  = <<<EOS
<head id='ar_html_parser_encoding_header'>
<meta http-equiv="content-type" content="text/html; charset=$encoding">
</head>
EOS;
		}
		libxml_disable_entity_loader(); // prevents XXE attacks
		$prevErrorSetting = libxml_use_internal_errors(true);
		if ( $dom->loadHTML( $prefix . $html, $this->options['libxml_options'] ) ) {
			if ( isset($encoding) ) {
				$elm  = $dom->getElementById('ar_html_parser_encoding_header');
				if ( isset($elm) ) {
					$elm->parentNode->removeChild($elm);
				}
			}
			libxml_use_internal_errors( $prevErrorSetting );
			return new \arc\html\Proxy( simplexml_import_dom( $dom ), $this );
		}
		$errors = libxml_get_errors();
		libxml_clear_errors();
		libxml_use_internal_errors( $prevErrorSetting );
		$message = 'Incorrect html passed.';
		foreach ( $errors as $error ) {
			$message .= "\nline: ".$error->line."; column: ".$error->column."; ".$error->message;
		}
		throw new \arc\Exception( $message, \arc\exceptions::ILLEGAL_ARGUMENT );
	}

}


1			<?php
2
3			namespace arc\html;
4
5			class Parser
6			{
7			public $options = [
8			'libxml_options' => 0
9			];
10
11	6	View Code Duplication	public function __construct( $options = array() )
			0 ignored issues – show Duplication introduced 2016-01-17 17:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13	6		$optionList = [ 'libxml_options' ];
14	6		foreach( $options as $option => $optionValue ) {
15			if ( in_array( $option, $optionList ) ) {
16			$this->{$option} = $optionValue;
17			}
18	6		}
19	6		}
20
21	6		public function parse( $html, $encoding = 'UTF-8' )
22			{
23	6		if ( !$html ) {
24			return \arc\html\Proxy( null );
25			}
26	6		if ( $html instanceof Proxy ) { // already parsed
27			return $html;
28			}
29	6		$html = (string) $html;
30	6		if ( stripos($html, '<html>')!==false ) {
31	5		return $this->parseFull( $html, $encoding );
32			} else {
33	1		return $this->parsePartial( $html, $encoding );
34			}
35			}
36
37	1		private function parsePartial( $html, $encoding = 'UTF-8' )
38			{
39	1		$result = $this->parseFull( '<div id="ArcPartialHTML">'.$html.'</div>', $encoding );
40	1		if ( $result ) {
41	1		$result = new \arc\html\Proxy( $result->find('#ArcPartialHTML')[0]->children(), $this );
42	1		} else {
43			throw new \arc\Exception('parse error');
44			}
45	1		return $result;
46			}
47
48	6		private function parseFull( $html, $encoding = 'UTF-8')
49			{
50	6		$dom = new \DomDocument('1.0', $encoding);
51	6		$prefix = '';
52	6		if ( isset($encoding) ) {
53			$prefix = <<<EOS
54			<head id='ar_html_parser_encoding_header'>
55			<meta http-equiv="content-type" content="text/html; charset=$encoding">
56	2		</head>
57	2		EOS;
58	2		}
59	6		libxml_disable_entity_loader(); // prevents XXE attacks
60	6		$prevErrorSetting = libxml_use_internal_errors(true);
61	6		if ( $dom->loadHTML( $prefix . $html, $this->options['libxml_options'] ) ) {
62	6		if ( isset($encoding) ) {
63	2		$elm = $dom->getElementById('ar_html_parser_encoding_header');
64	2		if ( isset($elm) ) {
65	2		$elm->parentNode->removeChild($elm);
66	2		}
67	2		}
68	6		libxml_use_internal_errors( $prevErrorSetting );
69	6		return new \arc\html\Proxy( simplexml_import_dom( $dom ), $this );
70			}
71			$errors = libxml_get_errors();
72			libxml_clear_errors();
73			libxml_use_internal_errors( $prevErrorSetting );
74			$message = 'Incorrect html passed.';
75			foreach ( $errors as $error ) {
76			$message .= "\nline: ".$error->line."; column: ".$error->column."; ".$error->message;
77			}
78			throw new \arc\Exception( $message, \arc\exceptions::ILLEGAL_ARGUMENT );
79			}
80
81			}
82

Ariadne-CMS / arc-html

Pull Request — master (#2)

Parser A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like