DotGet::run() - Code Metrics - Archer70/desmond - Measure and Improve Code Quality continuously with Scrutinizer

DotGet::run() A
last analyzed 2018-01-28 00:41 UTC

↳ Parent: DotGet

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	11
ccs	7
cts	7
cp	1
rs	9.4285
cc	3
eloc	7
nc	3
nop	1
crap	3

<?php
namespace Desmond\functions\core;
use Desmond\functions\DesmondFunction;
use Desmond\data_types\HashType;
use Desmond\TypeHelper;
use Desmond\exceptions\ArgumentException;

class DotGet extends DesmondFunction
{
    use TypeHelper;

    public function id()
    {
        return '.get';
    }

    public function run(array $args)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($args[0])) {
            return self::fromPhpType($_GET);
        }
        $index = $args[0]->value();
        if (!isset($_GET[$index])) {
            throw new ArgumentException('".get": Index "' . $index . '" not found.');
        }
        return self::fromPhpType($_GET[$index]);
    }
}


1		<?php
2		namespace Desmond\functions\core;
3		use Desmond\functions\DesmondFunction;
4		use Desmond\data_types\HashType;
5		use Desmond\TypeHelper;
6		use Desmond\exceptions\ArgumentException;
7
8		class DotGet extends DesmondFunction
9		{
10		use TypeHelper;
11
12	334	public function id()
13		{
14	334	return '.get';
15		}
16
17	5	public function run(array $args)
		0 ignored issues – show Coding Style introduced 2017-08-10 21:55 UTC by Report Bug Copy Issue Report `run` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
18		{
19	5	if (!isset($args[0])) {
20	1	return self::fromPhpType($_GET);
21		}
22	4	$index = $args[0]->value();
23	4	if (!isset($_GET[$index])) {
24	1	throw new ArgumentException('".get": Index "' . $index . '" not found.');
25		}
26	3	return self::fromPhpType($_GET[$index]);
27		}
28		}
29

Archer70 / desmond

DotGet::run() A last analyzed 2018-01-28 00:41 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

DotGet::run() A
last analyzed 2018-01-28 00:41 UTC