AraneaDev\Electrum\App\Http\Controllers\Api\HistoryController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	3
Bugs	2	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	3	1
A	__construct()	0	3	1
A	details()	0	3	1
A	index()	0	3	1

<?php

namespace AraneaDev\Electrum\App\Api;

use AraneaDev\Electrum\Electrum;
use App\Http\Controllers\Controller;

The type App\Http\Controllers\Controller was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Class HistoryController.
 */
class HistoryController extends Controller
{
    /** @var Electrum */
    protected $electrum;

    /**
     * HistoryController constructor.
     *
     * @param Electrum $electrum
     */
    public function __construct(Electrum $electrum)
    {
        $this->electrum = $electrum;
    }

    /**
     * Get the wallet history.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function index()
    {
        return response()->json($this->electrum->getHistory());

The method json() does not exist on Symfony\Component\HttpFoundation\Response. It seems like you code against a sub-type of Symfony\Component\HttpFoundation\Response such as Illuminate\Http\RedirectResponse.

    }

    /**
     * Get the history for a specific address.
     *
     * @param $address
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function show($address)
    {
        return response()->json($this->electrum->getAddressHistory($address));
    }

    /**
     * Get transaction details.
     *
     * @param $txid
     *
     * @return object
     */
    public function details($txid)
    {
        return response()->json($this->electrum->getTransaction($txid));

The expression return response()->json($this->electrum->getTransaction($txid)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type object.

    }
}