BWC\Share\Object\DeserializeTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	deserialize()	0	18	5
A	deserializeExtra()	0	1	1

<?php

namespace BWC\Share\Object;


trait DeserializeTrait
{

    /**
     * @param $data
     * @return null|static
     */
    static function deserialize($data) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = null;
        $arr = null;
        if (is_string($data)) {
            $arr = json_decode($data, true);
        } else if (is_array($data)) {
            $arr = $data;
        } else if(is_object($data)){
            $arr = get_object_vars($data);
        }
        if ($arr) {
            /** @var $result DeserializeTrait */
            $result = new static();
            ObjectHelper::copyExistingProperties($arr, $result);
            $result->deserializeExtra($arr);
        }
        return $result;
    }

    function deserializeExtra($arr) { }

The parameter $arr is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

}