BWC\Share\Net\HttpClient\HttpClient

Complexity

Total Complexity

29

Size/Duplication

Total Lines	189
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getTimeoutMS()	0	3	1
A	setTimeoutMS()	0	3	1
A	setCaPath()	0	6	2
A	setCaFile()	0	6	2
A	looseSslCheck()	0	10	2
A	getStatusCode()	0	3	1
A	getErrorText()	0	3	1
A	getHeader()	0	3	1
A	setCredentials()	0	3	1
A	accept()	0	3	1
A	get()	0	5	1
A	post()	0	4	1
A	delete()	0	4	1
C	request()	0	40	12

<?php

namespace BWC\Share\Net\HttpClient;

use BWC\Share\Net\ContentType;


class HttpClient implements HttpClientInterface
{
    private $_curl;

    private $_timeout_ms = 10000;

    protected $_accept;

    private $_header;

    private $_statusCode;

    private $_errorText;


    function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

        $this->_curl = curl_init();
        curl_setopt($this->_curl, CURLOPT_RETURNTRANSFER, true);
    }


    function getTimeoutMS() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->_timeout_ms;
    }

    function setTimeoutMS($milliseconds) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->_timeout_ms = $milliseconds;
    }

    /**
     * @param $path
     * @return void
     */
    public function setCaPath($path)
    {
        if ($path) {
            curl_setopt($this->_curl, CURLOPT_CAPATH, $path);
        }
    }

    /**
     * @param $file
     * @return void
     */
    public function setCaFile($file)
    {
        if ($file) {
            curl_setopt($this->_curl, CURLOPT_CAINFO, $file);
        }
    }

    /**
     * @param bool $value
     * @return void
     */
    public function looseSslCheck($value)
    {
        if ($value) {
            curl_setopt($this->_curl, CURLOPT_SSL_VERIFYPEER, false);
            curl_setopt($this->_curl, CURLOPT_SSL_VERIFYHOST, 0);
        } else {
            curl_setopt($this->_curl, CURLOPT_SSL_VERIFYPEER, true);
            curl_setopt($this->_curl, CURLOPT_SSL_VERIFYHOST, 2);
        }
    }

    /**
     * @return int
     */
    function getStatusCode() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->_statusCode;
    }

    /**
     * @return string
     */
    function getErrorText() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->_errorText;
    }
    /**
     * @return string
     */
    function getHeader() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->_header;
    }



    /**
     * @param string $username
     * @param string $password
     * @return void
     */
    function setCredentials($username, $password) {

It is generally recommended to explicitly declare the visibility for methods.

        curl_setopt($this->_curl, CURLOPT_USERPWD, $username.':'.$password);
    }


    /**
     * @param string $type   mime type for Accept http header, like text/xml or application/json
     * @return void
     */
    function accept($type) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->_accept = $type;
    }



    /**
     * @param string $url
     * @param array $queryData
     * @param array $arrHeaders
     * @return string
     */
    function get($url, array $queryData = array(), array $arrHeaders = null) {

It is generally recommended to explicitly declare the visibility for methods.

        $arrHeaders[] = 'Content-length: 0';
        $result = $this->request($url, 'GET', $queryData, null, null, $arrHeaders);
        return $result;
    }


    function post($url, array $queryData = array(), $postData, $contentType = null, array $arrHeaders = null) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = $this->request($url, 'POST', $queryData, $postData, $contentType, $arrHeaders);

It seems like $postData defined by parameter $postData on line 129 can also be of type object; however, BWC\Share\Net\HttpClient\HttpClient::request() does only seem to accept array|string, maybe add an additional type check?

It seems like $contentType defined by parameter $contentType on line 129 can also be of type string; however, BWC\Share\Net\HttpClient\HttpClient::request() does only seem to accept null, maybe add an additional type check?

        return $result;
    }

    /**
     * @param string $url
     * @param array $queryData
     * @param array $arrHeaders
     * @return string
     */
    function delete($url, array $queryData = array(), array $arrHeaders = null) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = $this->request($url, 'DELETE', $queryData, null, null, $arrHeaders);
        return $result;
    }


    /**
     * @param $url
     * @param $method
     * @param array $queryData
     * @param array|string $postData
     * @param null $contentType
     * @param array $arrHeaders
     * @return string
     */
    function request($url, $method, array $queryData, $postData, $contentType = null, array $arrHeaders = null) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->_header = null;
        $header = $arrHeaders ?: array();
        $header[] = sprintf('Host: %s', parse_url($url, PHP_URL_HOST));
        if ($this->_accept && !isset($header['Accept']))
            $header[] = 'Accept: '.$this->_accept;
        if ($queryData) {

The expression $queryData of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $url = rtrim($url, '?');
            $url .= '?'.http_build_query($queryData);
        }
        if ($contentType) {
            $header[] = 'Content-Type: '.$contentType;
        }
        if ($postData) {
            if (is_array($postData)) {
                $postData = http_build_query($postData);
            } else if (is_object($postData)) {
                $postData = urlencode(json_encode($postData));
            } else if (!$contentType) {
                $postData = urlencode((string)$postData);
            } else {
                $postData = (string)$postData;
            }
            curl_setopt($this->_curl, CURLOPT_POSTFIELDS, $postData);
            $header[] = 'Content-Length: '.strlen($postData);
            $header[] = 'Content-Type: '.($contentType ?: ContentType::FORM_URLENCODED);
        }
        curl_setopt($this->_curl, CURLOPT_URL, $url);
        curl_setopt($this->_curl, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($this->_curl, CURLOPT_HEADER, 1);
        curl_setopt($this->_curl, CURLOPT_HTTPHEADER, $header);
        curl_setopt($this->_curl, CURLOPT_CONNECTTIMEOUT_MS, $this->_timeout_ms ?: 10000);
        $response = curl_exec($this->_curl);
        $header_size = curl_getinfo($this->_curl, CURLINFO_HEADER_SIZE);
        $this->_header = substr($response, 0, $header_size);
        $body = substr($response, $header_size);
        $this->_statusCode = curl_getinfo($this->_curl, CURLINFO_HTTP_CODE);
        $this->_errorText = curl_error($this->_curl);
        return $body;
    }

}