BWC\Share\Data\Sequence\SequenceRepository

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	getTableName()	0	1	?
A	__construct()	0	4	1
A	generate()	0	12	3
A	exists()	0	7	2

<?php

namespace BWC\Share\Data\Sequence;

use Doctrine\DBAL\Connection;

abstract class SequenceRepository implements SequenceRepositoryInterface
{
    const MAX_UNIQUE_LOOPS = 20;

    /** @var \Doctrine\DBAL\Connection */
    private $_con;

    /** @var \BWC\Share\Data\Sequence\SequenceGeneratorInterface */
    private $_generator;



    function __construct(Connection $connection, SequenceGeneratorInterface $generator) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->_con = $connection;
        $this->_generator = $generator;
    }



    abstract function getTableName();

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @param string $name
     * @return string
     */
    function generate($name = 'default') {

It is generally recommended to explicitly declare the visibility for methods.

        $result = null;
        for ($i=0; $i<self::MAX_UNIQUE_LOOPS; $i++) {
            $value = $this->_generator->generate();
            try {
                $this->_con->insert($this->getTableName(), array('name'=>$name, 'value'=>$value));
                $result = $value;
                break;
            } catch (\Exception $ex) { }

Consider adding a comment why this CATCH block is empty.

        }
        return $result;
    }


    /**
     * @param string $value
     * @param string $name
     * @return bool
     */
    function exists($value, $name = 'default') {

It is generally recommended to explicitly declare the visibility for methods.

        $tbl = $this->getTableName();
        $count = $this->_con->fetchColumn("SELECT count(*) FROM `$tbl` WHERE name=:name AND value=:value",
            array(':name'=>$name, ':value'=>$value)
        );
        return $count ? true : false;
    }

}