Async::send() - Code Metrics - Apix/log-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Async::send() A
last analyzed 2019-10-31 22:47 UTC

↳ Parent: Async

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
nc	5
nop	1
dl	0
loc	28
ccs	19
cts	19
cp	1
crap	4
rs	9.472
c	0
b	0
f	0

<?php

namespace Apix\Log\Emitter;

use Psr\Log\InvalidArgumentException;

class Async extends AbstractEmitter
{
    /**
     * Holds the emitter/transporter's command string.
     * The placeholders in order are:
     *      - #1.    (string)    payload
     *      - #2.    (string)    url.
     */
    protected $transporter_cmd = 'curl -X POST -d %1$s \'%2$s\'';

    /**
     * Constructor.
     *
     * @param string $transporter_cmd The tranpsort command string
     */
    public function __construct($transporter_cmd = null)
    {
        $this->transporter_cmd = $transporter_cmd ?: $this->transporter_cmd;
    }

    /**
     * {@inheritdoc}
     */
    public function send($payload)
    {
        if (!is_string($payload)) {
            throw new InvalidArgumentException(sprintf(
                'Expects a string, got: (%s) %s.',
                gettype($payload), json_encode($payload)
            ));
        }

        $cmd = sprintf(
            $this->transporter_cmd,
            escapeshellarg($payload),
            $this->url // urlencode($this->url)
        );

        if (!$this->debug) {
            $cmd .= ' > /dev/null 2>&1 &';
            // $cmd .= ' >&- 2>&- &';
        }

        exec($cmd, $output, $return_var);

        if ($return_var != 0) {

            $this->handleError($return_var, $output);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $return_var == 0;

    }
}


1		<?php
2
3		namespace Apix\Log\Emitter;
4
5		use Psr\Log\InvalidArgumentException;
6
7		class Async extends AbstractEmitter
8		{
9		/**
10		* Holds the emitter/transporter's command string.
11		* The placeholders in order are:
12		* - #1. (string) payload
13		* - #2. (string) url.
14		*/
15		protected $transporter_cmd = 'curl -X POST -d %1$s \'%2$s\'';
16
17		/**
18		* Constructor.
19		*
20		* @param string $transporter_cmd The tranpsort command string
21		*/
22	128	public function __construct($transporter_cmd = null)
23		{
24	128	$this->transporter_cmd = $transporter_cmd ?: $this->transporter_cmd;
25	128	}
26
27		/**
28		* {@inheritdoc}
29		*/
30	40	public function send($payload)
31		{
32	40	if (!is_string($payload)) {
33	4	throw new InvalidArgumentException(sprintf(
34	4	'Expects a string, got: (%s) %s.',
35	3	gettype($payload), json_encode($payload)
36	3	));
37		}
38
39	36	$cmd = sprintf(
40	36	$this->transporter_cmd,
41	27	escapeshellarg($payload),
42	36	$this->url // urlencode($this->url)
43	27	);
44
45	36	if (!$this->debug) {
46	8	$cmd .= ' > /dev/null 2>&1 &';
47		// $cmd .= ' >&- 2>&- &';
48	6	}
49
50	36	exec($cmd, $output, $return_var);
51
52	28	if ($return_var != 0) {
		0 ignored issues – show Bug introduced 2016-10-10 16:31 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$return_var` of type `integer\|null` to `0`; this is ambiguous as not only `0 == 0` is true, but `null == 0` is true, too. Consider using a strict comparison `===`. Loading history...
53	4	$this->handleError($return_var, $output);
		0 ignored issues – show Documentation introduced 2016-10-10 16:31 UTC by Report Bug Copy Issue Report `$output` is of type `null\|array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54	3	}
55
56	28	return $return_var == 0;
		0 ignored issues – show Bug introduced 2016-10-10 16:31 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$return_var` of type `integer\|null` to `0`; this is ambiguous as not only `0 == 0` is true, but `null == 0` is true, too. Consider using a strict comparison `===`. Loading history...
57		}
58		}
59

Apix / log-tracker

Async::send() A last analyzed 2019-10-31 22:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Async::send() A
last analyzed 2019-10-31 22:47 UTC