App\Repositories\AbstractTerm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get_terms()	0	8	2
A	__construct()	0	2	1
A	get_term()	0	6	2

<?php
/**
 * Abstract term.
 *
 * @package App
 */

declare(strict_types=1);

namespace App\Repositories;

use App\Services\Meta\TermInterface as MetaInterface;

/**
 * Abstract term class.
 */
abstract class AbstractTerm {

	/**
	 * Meta.
	 *
	 * @var MetaInterface
	 */
	protected $meta;

	/**
	 * Construct.
	 *
	 * @param MetaInterface $meta Meta.
	 */
	public function __construct( MetaInterface $meta ) {
		$this->meta = $meta;
	}

	/**
	 * Get term.
	 *
	 * @param integer $id Id.
	 * @return \WP_term
	 * @throws \InvalidArgumentException When $id param is empty.
	 */
	protected function get_term( int $id ) {
		if ( empty( $id ) ) {
			throw new \InvalidArgumentException( __( 'Termo vazio.', 'wpsteak' ) );
		}

		return get_term( $id );

The expression return get_term($id) also could return the type WP_Error|array which is incompatible with the documented return type WP_term.

	}

	/**
	 * Get terms.
	 *
	 * @param array $args Args.
	 * @return \WP_Term[]
	 * @throws \InvalidArgumentException When the passed taxonomy does not exists.
	 */
	protected function get_terms( array $args ) : array {
		$terms = get_terms( $args );

		if ( is_wp_error( $terms ) ) {
			throw new \InvalidArgumentException( __( 'Taxonomia não existe', 'wpsteak' ) );
		}

		return $terms;

The expression return $terms could return the type WP_Error which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

	}
}