Inspection of "test" - AnuTiger/F3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (03df00)

by Anu

created 2017-10-07 19:56 UTC

Status

Indentation +119 added lines, -119 removed lines patch added patch discarded remove patch

@@ -1,145 +1,145 @@
 block discarded – undo
 <?php
 
 class App extends Prefab{
-    public $db;
+	public $db;
 	public $app;
-    public $session;
-    public $authenticatedUser;
+	public $session;
+	public $authenticatedUser;
 
 	public function __construct() {
-	    $this->app = $this->app ?: Base::instance();
+		$this->app = $this->app ?: Base::instance();
 	}
 
-    static public function singleton() {
-        if (Registry::exists('APP'))
-            $app = Registry::get('APP');
-        else {
-            $app = new self;
-            Registry::set('APP',$app);
-        }
-        return $app;
-    }
+	static public function singleton() {
+		if (Registry::exists('APP'))
+			$app = Registry::get('APP');
+		else {
+			$app = new self;
+			Registry::set('APP',$app);
+		}
+		return $app;
+	}
 
-    public function db() {
-        return $this->db ?: $this->app->DB;
-    }
+	public function db() {
+		return $this->db ?: $this->app->DB;
+	}
 
-    public function session() {
-        return $this->session ?: $this->app->SESSION;
-    }
+	public function session() {
+		return $this->session ?: $this->app->SESSION;
+	}
 
 	public function user() {
 		return $this->authenticatedUser = $this->app->get('SESSION.USER')?:false;
 	}
 
-    public function initialized($def = null) {
-        return null !== $def ? $this->app->set('INITIALIZED', $def) : $this->app->get('INITIALIZED');
-    }
+	public function initialized($def = null) {
+		return null !== $def ? $this->app->set('INITIALIZED', $def) : $this->app->get('INITIALIZED');
+	}
 
-    public function config($key = null) {
-        return $this->app->get($key?:'CONFIG') ;
-    }
+	public function config($key = null) {
+		return $this->app->get($key?:'CONFIG') ;
+	}
 
-    public function status() {
-        return $this->app->IS_LIVE;
-    }
+	public function status() {
+		return $this->app->IS_LIVE;
+	}
 
-    public function run() {
-        $this->loadConfig();
-        $this->loadRoutes();
-        $this->checkForMaintenance();
-        $this->configureDebug();
-	    $this->configureDB();
-	    $this->configureSession();
-        $this->configureAssets();
+	public function run() {
+		$this->loadConfig();
+		$this->loadRoutes();
+		$this->checkForMaintenance();
+		$this->configureDebug();
+		$this->configureDB();
+		$this->configureSession();
+		$this->configureAssets();
 		$this->registerErrorHandler();
-	    $this->initialized(true);
+		$this->initialized(true);
 		$this->app->run();
-    }
-
-    public function loadRoutes($file = null){
-        $this->_load('routes', $file);
-    }
-
-    public function loadConfig($file = null){
-        $this->_load('config', $file);
-    }
-
-    private function _load($path, $file = null) {
-        if($file) {
-            $this->app->config(base_path("{path}/{$file}"));
-        }else{
-            foreach(glob(base_path("{$path}/*.ini")) as $file) {
-                $this->app->config($file);
-            }
-        }
-    }
+	}
+
+	public function loadRoutes($file = null){
+		$this->_load('routes', $file);
+	}
+
+	public function loadConfig($file = null){
+		$this->_load('config', $file);
+	}
+
+	private function _load($path, $file = null) {
+		if($file) {
+			$this->app->config(base_path("{path}/{$file}"));
+		}else{
+			foreach(glob(base_path("{$path}/*.ini")) as $file) {
+				$this->app->config($file);
+			}
+		}
+	}
 
 	public function checkForMaintenance() {
 		if(!$this->status()) {
-	       	template('maintenance');
-		    exit();
-        }
-	}
-
-    public function configureDebug() {
-	    if(!$this->app->DEV) {
-	        $this->app->set('DEBUG', 0);
-        }
-    }
-
-    public function configureDB() {
-        $type = strtolower($this->app->DB_TYPE);
-
-        if($type == 'jig'){
-            $this->db = new DB\Jig($this->app->DB_PATH, DB\Jig::FORMAT_JSON);
-        }else if($type == 'sql'){
-            $this->db = new DB\SQL($this->app->DB, $this->app->DB_USER, $this->app->DB_PSWD);
-        }else if($type == 'mongo'){
-            $this->db = new DB\Mongo($this->app->DB, $this->app->DB_USER);
-        }
-        $this->app->set('DB', $this->db);
-    }
-
-    public function configureSession() {
-        $type = strtolower($this->app->SESSION);
-
-        if($type) {
-            if($this->app->CSRF && ('jig' == $type || 'sql' == $type || 'mongo' == $type)) {
-                $this->configureCSRF($type);
-            }else if($this->app->CSRF){
-                $this->session = new Session(null, 'CSRF');
-            }else{
-                if($type == 'jig' || $type == 'mongo' || $type == 'sql'){
-                    $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
-                    $this->session = new $session($this->app->DB);
-                }else{
-                    $this->session = new Session();
-                }
-            }
-            $this->app->set('SESSION', $this->session);
-        }
-    }
-
-    public function configureCSRF($type) {
-        $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
-        $this->session = new $session($this->app->DB, 'sessions', null, 'CSRF');
-    }
-
-    private function _getDBType($type) {
-        if($type == 'jig' || $type == 'mongo'){
-            return ucfirst($type);
-        }else if($type == 'sql') {
-            return strtoupper($type);
-        }
-    }
-
-    public function configureAssets() {
-        $assets = Assets::instance();
-        $this->app->set('ASSETS.onFileNotFound',function($file) {
-            echo 'file not found: '.$file;
-        });
-    }
+		   	template('maintenance');
+			exit();
+		}
+	}
+
+	public function configureDebug() {
+		if(!$this->app->DEV) {
+			$this->app->set('DEBUG', 0);
+		}
+	}
+
+	public function configureDB() {
+		$type = strtolower($this->app->DB_TYPE);
+
+		if($type == 'jig'){
+			$this->db = new DB\Jig($this->app->DB_PATH, DB\Jig::FORMAT_JSON);
+		}else if($type == 'sql'){
+			$this->db = new DB\SQL($this->app->DB, $this->app->DB_USER, $this->app->DB_PSWD);
+		}else if($type == 'mongo'){
+			$this->db = new DB\Mongo($this->app->DB, $this->app->DB_USER);
+		}
+		$this->app->set('DB', $this->db);
+	}
+
+	public function configureSession() {
+		$type = strtolower($this->app->SESSION);
+
+		if($type) {
+			if($this->app->CSRF && ('jig' == $type || 'sql' == $type || 'mongo' == $type)) {
+				$this->configureCSRF($type);
+			}else if($this->app->CSRF){
+				$this->session = new Session(null, 'CSRF');
+			}else{
+				if($type == 'jig' || $type == 'mongo' || $type == 'sql'){
+					$session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
+					$this->session = new $session($this->app->DB);
+				}else{
+					$this->session = new Session();
+				}
+			}
+			$this->app->set('SESSION', $this->session);
+		}
+	}
+
+	public function configureCSRF($type) {
+		$session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
+		$this->session = new $session($this->app->DB, 'sessions', null, 'CSRF');
+	}
+
+	private function _getDBType($type) {
+		if($type == 'jig' || $type == 'mongo'){
+			return ucfirst($type);
+		}else if($type == 'sql') {
+			return strtoupper($type);
+		}
+	}
+
+	public function configureAssets() {
+		$assets = Assets::instance();
+		$this->app->set('ASSETS.onFileNotFound',function($file) {
+			echo 'file not found: '.$file;
+		});
+	}
 
 	public function registerErrorHandler() {
 		if($this->app->DEV) {

Please login to merge, or discard this patch.

		@@ -1,145 +1,145 @@
		block discarded – undo
1	1	<?php
2	2
3	3	class App extends Prefab{
4		- public $db;
	4	+ public $db;
5	5	public $app;
6		- public $session;
7		- public $authenticatedUser;
	6	+ public $session;
	7	+ public $authenticatedUser;
8	8
9	9	public function __construct() {
10		- $this->app = $this->app ?: Base::instance();
	10	+ $this->app = $this->app ?: Base::instance();
11	11	}
12	12
13		- static public function singleton() {
14		- if (Registry::exists('APP'))
15		- $app = Registry::get('APP');
16		- else {
17		- $app = new self;
18		- Registry::set('APP',$app);
19		- }
20		- return $app;
21		- }
	13	+ static public function singleton() {
	14	+ if (Registry::exists('APP'))
	15	+ $app = Registry::get('APP');
	16	+ else {
	17	+ $app = new self;
	18	+ Registry::set('APP',$app);
	19	+ }
	20	+ return $app;
	21	+ }
22	22
23		- public function db() {
24		- return $this->db ?: $this->app->DB;
25		- }
	23	+ public function db() {
	24	+ return $this->db ?: $this->app->DB;
	25	+ }
26	26
27		- public function session() {
28		- return $this->session ?: $this->app->SESSION;
29		- }
	27	+ public function session() {
	28	+ return $this->session ?: $this->app->SESSION;
	29	+ }
30	30
31	31	public function user() {
32	32	return $this->authenticatedUser = $this->app->get('SESSION.USER')?:false;
33	33	}
34	34
35		- public function initialized($def = null) {
36		- return null !== $def ? $this->app->set('INITIALIZED', $def) : $this->app->get('INITIALIZED');
37		- }
	35	+ public function initialized($def = null) {
	36	+ return null !== $def ? $this->app->set('INITIALIZED', $def) : $this->app->get('INITIALIZED');
	37	+ }
38	38
39		- public function config($key = null) {
40		- return $this->app->get($key?:'CONFIG') ;
41		- }
	39	+ public function config($key = null) {
	40	+ return $this->app->get($key?:'CONFIG') ;
	41	+ }
42	42
43		- public function status() {
44		- return $this->app->IS_LIVE;
45		- }
	43	+ public function status() {
	44	+ return $this->app->IS_LIVE;
	45	+ }
46	46
47		- public function run() {
48		- $this->loadConfig();
49		- $this->loadRoutes();
50		- $this->checkForMaintenance();
51		- $this->configureDebug();
52		- $this->configureDB();
53		- $this->configureSession();
54		- $this->configureAssets();
	47	+ public function run() {
	48	+ $this->loadConfig();
	49	+ $this->loadRoutes();
	50	+ $this->checkForMaintenance();
	51	+ $this->configureDebug();
	52	+ $this->configureDB();
	53	+ $this->configureSession();
	54	+ $this->configureAssets();
55	55	$this->registerErrorHandler();
56		- $this->initialized(true);
	56	+ $this->initialized(true);
57	57	$this->app->run();
58		- }
59		-
60		- public function loadRoutes($file = null){
61		- $this->_load('routes', $file);
62		- }
63		-
64		- public function loadConfig($file = null){
65		- $this->_load('config', $file);
66		- }
67		-
68		- private function _load($path, $file = null) {
69		- if($file) {
70		- $this->app->config(base_path("{path}/{$file}"));
71		- }else{
72		- foreach(glob(base_path("{$path}/*.ini")) as $file) {
73		- $this->app->config($file);
74		- }
75		- }
76		- }
	58	+ }
	59	+
	60	+ public function loadRoutes($file = null){
	61	+ $this->_load('routes', $file);
	62	+ }
	63	+
	64	+ public function loadConfig($file = null){
	65	+ $this->_load('config', $file);
	66	+ }
	67	+
	68	+ private function _load($path, $file = null) {
	69	+ if($file) {
	70	+ $this->app->config(base_path("{path}/{$file}"));
	71	+ }else{
	72	+ foreach(glob(base_path("{$path}/*.ini")) as $file) {
	73	+ $this->app->config($file);
	74	+ }
	75	+ }
	76	+ }
77	77
78	78	public function checkForMaintenance() {
79	79	if(!$this->status()) {
80		- template('maintenance');
81		- exit();
82		- }
83		- }
84		-
85		- public function configureDebug() {
86		- if(!$this->app->DEV) {
87		- $this->app->set('DEBUG', 0);
88		- }
89		- }
90		-
91		- public function configureDB() {
92		- $type = strtolower($this->app->DB_TYPE);
93		-
94		- if($type == 'jig'){
95		- $this->db = new DB\Jig($this->app->DB_PATH, DB\Jig::FORMAT_JSON);
96		- }else if($type == 'sql'){
97		- $this->db = new DB\SQL($this->app->DB, $this->app->DB_USER, $this->app->DB_PSWD);
98		- }else if($type == 'mongo'){
99		- $this->db = new DB\Mongo($this->app->DB, $this->app->DB_USER);
100		- }
101		- $this->app->set('DB', $this->db);
102		- }
103		-
104		- public function configureSession() {
105		- $type = strtolower($this->app->SESSION);
106		-
107		- if($type) {
108		- if($this->app->CSRF && ('jig' == $type \|\| 'sql' == $type \|\| 'mongo' == $type)) {
109		- $this->configureCSRF($type);
110		- }else if($this->app->CSRF){
111		- $this->session = new Session(null, 'CSRF');
112		- }else{
113		- if($type == 'jig' \|\| $type == 'mongo' \|\| $type == 'sql'){
114		- $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
115		- $this->session = new $session($this->app->DB);
116		- }else{
117		- $this->session = new Session();
118		- }
119		- }
120		- $this->app->set('SESSION', $this->session);
121		- }
122		- }
123		-
124		- public function configureCSRF($type) {
125		- $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
126		- $this->session = new $session($this->app->DB, 'sessions', null, 'CSRF');
127		- }
128		-
129		- private function _getDBType($type) {
130		- if($type == 'jig' \|\| $type == 'mongo'){
131		- return ucfirst($type);
132		- }else if($type == 'sql') {
133		- return strtoupper($type);
134		- }
135		- }
136		-
137		- public function configureAssets() {
138		- $assets = Assets::instance();
139		- $this->app->set('ASSETS.onFileNotFound',function($file) {
140		- echo 'file not found: '.$file;
141		- });
142		- }
	80	+ template('maintenance');
	81	+ exit();
	82	+ }
	83	+ }
	84	+
	85	+ public function configureDebug() {
	86	+ if(!$this->app->DEV) {
	87	+ $this->app->set('DEBUG', 0);
	88	+ }
	89	+ }
	90	+
	91	+ public function configureDB() {
	92	+ $type = strtolower($this->app->DB_TYPE);
	93	+
	94	+ if($type == 'jig'){
	95	+ $this->db = new DB\Jig($this->app->DB_PATH, DB\Jig::FORMAT_JSON);
	96	+ }else if($type == 'sql'){
	97	+ $this->db = new DB\SQL($this->app->DB, $this->app->DB_USER, $this->app->DB_PSWD);
	98	+ }else if($type == 'mongo'){
	99	+ $this->db = new DB\Mongo($this->app->DB, $this->app->DB_USER);
	100	+ }
	101	+ $this->app->set('DB', $this->db);
	102	+ }
	103	+
	104	+ public function configureSession() {
	105	+ $type = strtolower($this->app->SESSION);
	106	+
	107	+ if($type) {
	108	+ if($this->app->CSRF && ('jig' == $type \|\| 'sql' == $type \|\| 'mongo' == $type)) {
	109	+ $this->configureCSRF($type);
	110	+ }else if($this->app->CSRF){
	111	+ $this->session = new Session(null, 'CSRF');
	112	+ }else{
	113	+ if($type == 'jig' \|\| $type == 'mongo' \|\| $type == 'sql'){
	114	+ $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
	115	+ $this->session = new $session($this->app->DB);
	116	+ }else{
	117	+ $this->session = new Session();
	118	+ }
	119	+ }
	120	+ $this->app->set('SESSION', $this->session);
	121	+ }
	122	+ }
	123	+
	124	+ public function configureCSRF($type) {
	125	+ $session = str_ireplace('/', '', 'DB\/'.$this->_getDBType($type).'\Session');
	126	+ $this->session = new $session($this->app->DB, 'sessions', null, 'CSRF');
	127	+ }
	128	+
	129	+ private function _getDBType($type) {
	130	+ if($type == 'jig' \|\| $type == 'mongo'){
	131	+ return ucfirst($type);
	132	+ }else if($type == 'sql') {
	133	+ return strtoupper($type);
	134	+ }
	135	+ }
	136	+
	137	+ public function configureAssets() {
	138	+ $assets = Assets::instance();
	139	+ $this->app->set('ASSETS.onFileNotFound',function($file) {
	140	+ echo 'file not found: '.$file;
	141	+ });
	142	+ }
143	143
144	144	public function registerErrorHandler() {
145	145	if($this->app->DEV) {

AnuTiger / F3

Branch — master (03df00)

Status

Category

Indentation +119 added lines, -119 removed lines patch added patch discarded remove patch