KnockoutFormAction::setDisabledClass() - Code Metrics - Inspection of "Updated Tests, Templates & Documentation for Silve..." - AntonyThorpe/silverstripe-knockout-forms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (e5ff15)

by Antony

created 2018-11-24 22:29 UTC

KnockoutFormAction::setDisabledClass() A

↳ Parent: KnockoutFormAction

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace AntonyThorpe\Knockout;

require_once('Common.php');

/**
 * KnockoutFormAction
 *
 * Wrap HTML in an Knockout if statement to disable the submit key when invalid (as per Knockout Validation)
 */
class KnockoutFormAction extends \SilverStripe\Forms\FormAction
{

    use \AntonyThorpe\Knockout\Common;

    /**
     * $disabledClass
     *
     * @var string a disabledClass
     */
    protected $disabledClass = "FormAction_Disabled";

    /**
     * casting of variables for security purposes
     *
     * @see http://docs.silverstripe.org/en/3.1/developer_guides/security/secure_coding/
     */
    protected $casting = array(
        "DisabledClass" => "Varchar",
        "Observable" => "Varchar",
        "BindingType" => "Varchar",
        "OtherBindings" => "Varchar",
        "HasFocus" => "Boolean"
    );

    /**
     * setDisabledClass
     *
     * @param string $input The CSS class appied to the element upon a falsy observable result
     * @return $this
     */
    public function setDisabledClass($input)
    {
        $this->disabledClass = (string)$input;
        return $this;
    }

    /**
     * getDisabledClass
     *
     * @return boolean
     */
    public function getDisabledClass()
    {
        return $this->disabledClass;

    }
}


1			<?php
2
3			namespace AntonyThorpe\Knockout;
4
5			require_once('Common.php');
6
7			/**
8			* KnockoutFormAction
9			*
10			* Wrap HTML in an Knockout if statement to disable the submit key when invalid (as per Knockout Validation)
11			*/
12			class KnockoutFormAction extends \SilverStripe\Forms\FormAction
13			{
14
15			use \AntonyThorpe\Knockout\Common;
16
17			/**
18			* $disabledClass
19			*
20			* @var string a disabledClass
21			*/
22			protected $disabledClass = "FormAction_Disabled";
23
24			/**
25			* casting of variables for security purposes
26			*
27			* @see http://docs.silverstripe.org/en/3.1/developer_guides/security/secure_coding/
28			*/
29			protected $casting = array(
30			"DisabledClass" => "Varchar",
31			"Observable" => "Varchar",
32			"BindingType" => "Varchar",
33			"OtherBindings" => "Varchar",
34			"HasFocus" => "Boolean"
35			);
36
37			/**
38			* setDisabledClass
39			*
40			* @param string $input The CSS class appied to the element upon a falsy observable result
41			* @return $this
42			*/
43			public function setDisabledClass($input)
44			{
45			$this->disabledClass = (string)$input;
46			return $this;
47			}
48
49			/**
50			* getDisabledClass
51			*
52			* @return boolean
53			*/
54			public function getDisabledClass()
55			{
56			return $this->disabledClass;
			0 ignored issues – show Bug Best Practice introduced 2018-11-24 09:20 UTC by Report Bug Copy Issue Report The expression `return $this->disabledClass` returns the type `string` which is incompatible with the documented return type `boolean`. Loading history...
57			}
58			}
59

AntonyThorpe / silverstripe-knockout-forms

Branch — master (e5ff15)

KnockoutFormAction::setDisabledClass() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like