KnockoutFormTest::testKnockoutForm() - Code Metrics - Inspection of "Updated Tests, Templates & Documentation for Silve..." - AntonyThorpe/silverstripe-knockout-forms - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( bf3235...abf80a )

by Antony
created 2018-11-24 09:17 UTC
KnockoutFormTest::testKnockoutForm() B

↳ Parent: KnockoutFormTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	80
Code Lines	63
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	63
nc	1
nop	0
dl	0
loc	80
rs	8.8072
c	0
b	0
f	0
How to fix Long Method

<?php

namespace AntonyThorpe\Knockout\Tests;

use SilverStripe\Dev\FunctionalTest;
use SilverStripe\Core\Config\Config;
use SilverStripe\Control\Controller;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Dev\TestOnly;
use SilverStripe\Forms\FieldList;
use SilverStripe\View\SSViewer;
use SilverStripe\Forms\Form;
use AntonyThorpe\Knockout\KnockoutForm;
use AntonyThorpe\Knockout\KnockoutTextField;
use AntonyThorpe\Knockout\KnockoutDropdownField;
use AntonyThorpe\Knockout\KnockoutNumericField;
use AntonyThorpe\Knockout\KnockoutEmailField;
use AntonyThorpe\Knockout\KnockoutTextareaField;
use AntonyThorpe\Knockout\KnockoutOptionsetField;
use AntonyThorpe\Knockout\KnockoutConfirmedPasswordField;
use AntonyThorpe\Knockout\KnockoutFormAction;

/**
 * KnockoutFormTest
 *
 * Controller tests
 */
class KnockoutFormTest extends FunctionalTest
{
    protected static $disable_theme = true;

    protected static $extra_controllers = [
        KnockoutFormTest_Controller::class
    ];

    public function setUp()
    {
        parent::setUp();
        Config::inst()->update('SSViewer', 'source_file_comments', true);
        Config::inst()->/** @scrutinizer ignore-call */ update('SSViewer', 'source_file_comments', true);
    }

    public function testKnockoutForm()
    {
        $page = $this->get('KnockoutFormTest_Controller');
        $this->assertEquals(200, $page->getStatusCode(), "a page should load");
        $body = $page->getBody();

        $this->assertContains(
            'data-bind="submit: addToCart2"',
            $body,
            'form element has submit binding to javascript function'
        );
        $this->assertContains(
            '<input data-bind="textInput: spaceship2, hasFocus: true"',
            $body,
            'Databind attribute in input element'
        );
        $this->assertContains(
            "setKnockout:{value:'Enterprise\'s Voyage'}",
            $body,
            'Comma escaped in HTML for javascript'
        );
        $this->assertContains(
            '<select data-bind="value: menu"',
            $body,
            'Databind attribute applied to select element'
        );
        $this->assertContains(
            '<input data-bind="textInput: seatNumber, setKnockout:{value:4}"',
            $body,
            'KnockoutNumericField works'
        );
        $this->assertContains(
            '<input data-bind="enable: canSaveInterGalacticAction, css:{ \'FormAction_Disabled\': !canSaveInterGalacticAction() }" type="submit"',
            $body,
            'Databind attribute in submit button'
        );
        $this->assertContains(
            '<input data-bind="textInput: email, setKnockout:{value:\'[email protected]\'}"',
            $body,
            'Databind attribute applied to input element for email field'
        );
        $this->assertContains(
            'class="email text"',
            $body,
            'KnockoutEmailField has a class of "email text"'
        );
        $this->assertContains(
            '<textarea data-bind="textInput: comments"',
            $body,
            'Databind attribute applied to the textareafield'
        );
        $this->assertContains(
            'class="knockouttextarea textarea"',
            $body,
            'KnockoutTextareaField has a class of "textarea text"'
        );
        $this->assertContains(
            'data-bind="checked: accessories, setKnockout:{value:\'Zero Gravity Pillow\'}, blah: someOtherFunction"',
            $body,
            'Databind attribute applied to the radio buttons'
        );
        $this->assertContains(
            'class="radio"',
            $body,
            'KnockoutOptionsetField has a class of "radio"'
        );
        $this->assertContains(
            'data-bind="enable: canSaveInterGalacticAction',
            $body,
            'KnockoutFormAction has an obserable of "canSaveInterGalacticAction"'
        );
        $this->assertContains(
            'data-bind="textInput: password',
            $body,
            'KnockoutConfirmedPasswordField has a child with an obserable of "password"'
        );
        $this->assertContains(
            'data-bind="textInput: confirmedPassword',
            $body,
            'KnockoutConfirmedPasswordField has a child with an obserable of "confirmedPassword"'
        );
        // add additional tests here after adding to the form below
    }
}


class KnockoutFormTest_Controller extends Controller implements TestOnly
{
    public function __construct()
    {
        parent::__construct();
        if (Controller::has_curr()) {
            $this->setRequest(Controller::curr()->getRequest());
        }
    }

    private static $allowed_actions = array('Form');


    private static $url_handlers = array(

        '$Action//$ID/$OtherID' => "handleAction",
    );

    protected $template = 'BlankPage';

    public function Link($action = null)
    {
        return Controller::join_links(
            'KnockoutFormTest_Controller',
            $this->getRequest()->latestParam('Action'),
            $this->getRequest()->latestParam('ID'),
            $action
        );
    }

    public function Form()
    {
        $form = KnockoutForm::create(
            $this,
            'Form',
            FieldList::create(
                KnockoutTextField::create('Spaceship', 'Spaceship')
                    ->setObservable('spaceship2')
                    ->setHasFocus(true),
                KnockoutTextField::create('FieldWithComma', 'FieldWithComma')
                    ->setObservable('fieldwithcomma')
                    ->setValue("Enterprise's Voyage"),
                KnockoutDropdownField::create(
                    'Menu',
                    'Space Menu',
                    array('1'=>'Light Speed Salad','2'=>'Comet Custard')
                )->setObservable('menu'),
                KnockoutNumericField::create('SeatNumber', 'Seat Number', 4)
                    ->setObservable('seatNumber'),
                KnockoutEmailField::create('Email', 'Email')
                    ->setObservable('email')
                    ->setValue('[email protected]'),
                KnockoutTextareaField::create('Comments', 'Comments')
                    ->setObservable('comments'),
                KnockoutOptionsetField::create(
                    'Accessories',
                    'Accessories',
                    array(
                        'Flying High DVD' => 'Flying High DVD',
                        'Zero Gravity Pillow' => 'Zero Gravity Pillow',
                        'Rocket Replica' => 'Rocket Replica'
                    ),
                    'Zero Gravity Pillow'
                )->setObservable('accessories')
                    ->setOtherBindings("blah: someOtherFunction"),
                KnockoutConfirmedPasswordField::create('Password', 'Password')
                // add any new knockout fields here and assert above
            ),
            FieldList::create(
                KnockoutFormAction::create('doSubmit', 'Submit')
                    ->setObservable('canSaveInterGalacticAction')
            )
        );
        $form->setSubmit('addToCart2');

        return $form;
    }

    public function doSubmit($data, Form $form, HTTPRequest $request)
    public function doSubmit($data, Form $form, /** @scrutinizer ignore-unused */ HTTPRequest $request)
    {
        $form->sessionMessage('Test save was successful', 'good');
        return $this->redirectBack();
    }

    public function getViewer($action = null)
    {
        return new SSViewer('BlankPage');
    }
}

AntonyThorpe / silverstripe-knockout-forms

Push — master ( bf3235...abf80a )

KnockoutFormTest::testKnockoutForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
