SilvershopJsonResponseTest::testRemoveFromCart() - Code Metrics - Inspection of "Update" - AntonyThorpe/silvershop-jsonresponse - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61756c...9c4d64 )

by Antony

created 2016-06-08 09:35 UTC

SilvershopJsonResponseTest::testRemoveFromCart() A

↳ Parent: SilvershopJsonResponseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	67
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	67
rs	9.2815
cc	1
eloc	47
nc	1
nop	0

How to fix Long Method

<?php
/**
 * Functional tests of json responses for shopping cart of Silverstripe Shop
 *
 * @package shop
 * @subpackage tests
 */
class SilvershopJsonResponseTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    protected static $fixture_file = 'silvershop/tests/fixtures/shop.yml';

    public function setUpOnce()
    {
        if (!ShoppingCart_Controller::has_extension('SilvershopJsonResponse')) {
            ShoppingCart_Controller::add_extension('SilvershopJsonResponse');
        }
        if (!VariationForm::has_extension('SilvershopJsonResponse')) {
            VariationForm::add_extension('SilvershopJsonResponse');
        }
        parent::setUpOnce();
    }

    public function setUp()
    {
        parent::setUp();
        ShopTest::setConfiguration(); //reset config
        Order::config()->modifiers = array(
            "FlatTaxModifier"
        );

        $this->mp3player = $this->objFromFixture('Product', 'mp3player');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->socks = $this->objFromFixture('Product', 'socks');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        //publish some product categories and products
        $this->objFromFixture('ProductCategory', 'products')->publish('Stage', 'Live');
        $this->objFromFixture('ProductCategory', 'clothing')->publish('Stage', 'Live');
        $this->objFromFixture('ProductCategory', 'clearance')->publish('Stage', 'Live');

        $this->mp3player->publish('Stage', 'Live');
        $this->socks->publish('Stage', 'Live');

        $this->cart = ShoppingCart::singleton();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->cart->clear();
    }

    public function testAddToCart()
    {
        // test ajax request (Product Category page)
        $response = $this->get(ShoppingCart_Controller::add_item_link($this->mp3player) . "?ajax=1");
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );

        $this->assertContains(
            "addLink",
            $response->getBody(),
            "response contains a link to add additional quantities of an item in the cart"
        );
        $this->assertContains(
            "removeLink",
            $response->getBody(),
            "response contains a link to reduce the quantity of an item in a cart"
        );
        $this->assertContains(
            "removeallLink",
            $response->getBody(),
            "response contains a link to remove all of an item from a cart"
        );
        $this->assertContains(
            "setquantityLink",
            $response->getBody(),
            "response contains a link to set the quantity of an item in a cart"
        );
        $this->assertContains(
            "unitPrice",
            $response->getBody(),
            "response contains the unit price of items in a cart"
        );
        $this->assertContains(
            "subTotal",
            $response->getBody(),
            "response contains a subTotal when include_totals is set to true"
        );

        // See what's in the cart
        $items = ShoppingCart::curr()->Items();
        $this->assertNotNull($items);

        $this->assertEquals(

            $items->Count(),
            1,
            'There is 1 item in the cart'
        );
    }

    public function testRemoveFromCart()
    {

        // add items via url to setup
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));

        ShoppingCart::curr()->calculate();  // recalculate the shopping cart

        $cart = $this->get("shoppingcart/get" . "?ajax=1");
        $this->assertContains(
            '"id":"10"',
            $cart->getBody(),
            "Contains the mp3 player"
        );
        $this->assertContains(
            '"id":"6"',
            $cart->getBody(),
            "Contains the socks"
        );

        // remove the one of the mp3 players via url making the total 4
        $response = $this->get(ShoppingCart_Controller::remove_item_link($this->mp3player) . "?ajax=1");
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );
        $this->assertContains(
            '{"id":"10"', $response->getBody(),
            "Contains json in the body of the response and id of the mp3 player"
        );

        // remove the one of the socks via url making the total NIL so it is fully removed
        $response = $this->get(ShoppingCart_Controller::remove_item_link($this->socks) . "?ajax=1");
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );
        $this->assertFalse(

            $this->cart->get($this->socks),
            "socks completely removed"
        );
        $this->assertContains(
            '{"id":"6"',
            $response->getBody(),
            "id of Socks returned"
        );
    }

    public function testRemoveAllFromCart()
    {
        // add items via url to setup
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));


        // remove items from cart via url
        $response = $this->get(ShoppingCart_Controller::remove_all_item_link($this->mp3player) . "?ajax=1");
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );
        $this->assertContains(
            '{"id":"10"',
            $response->getBody(),
            "Contains json in the body of the response and id of item removed"
        );
        $this->assertFalse(

            $this->cart->get($this->mp3player),
            "Mp3 Players are not in the cart"
        );
    }

    public function testSetQuantityInCart()
    {
        // add items via url to setup
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));


        // set items via url
        $response = $this->get(
            ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 3, 'ajax' => 1))

        );
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );

        $this->assertContains(
            'Quantity has been set',
            $response->getBody(),
            "Contains a confirmation message that the quantity has been set to a new value"
        );
    }

    public function testClearAllItemsFromTheCart()
    {
        // add items via url to setup
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));


        // remove items via url
        $response = $this->get("shoppingcart/clear?ajax=1");
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );

        $this->assertContains(
            'Cart was successfully cleared',
            $response->getBody(),
            "Contains a message that the cart has been cleared"
        );
    }

    public function testVariations()
    {
        $this->loadFixture('silvershop/tests/fixtures/variations.yml');
        $ballRoot = $this->objFromFixture('Product', 'ball');
        
        // add parent for categories in JSON response
        $parent = $this->objFromFixture('ProductCategory', 'products');
        $ballRoot->ParentID = $parent->ID;
        $ballRoot->write();

        $ballRoot->publish('Stage', 'Live');
        $ball1 = $this->objFromFixture('ProductVariation', 'redlarge');
        $ball2 = $this->objFromFixture('ProductVariation', 'redsmall');

        // Add the two variation items
        $response = $this->get(ShoppingCart_Controller::add_item_link($ball1) . "?ajax=1");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals(

            200,
            $response->getStatusCode(),
            "Response status code is 200"
        );
        $this->assertEquals(

            "application/json; charset=utf-8",
            $response->getHeader("Content-Type"),
            "Json response header"
        );
        $this->assertJson(

            $response->getBody(),
            "Contains json in the body of the response"
        );
        $this->assertContains(
            "Size:Large, Color:Red",
            $response->getBody(),
            "Contains json in the body of the cart id"
        );

        $response = $this->get(ShoppingCart_Controller::add_item_link($ball2) . "?ajax=1");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $items = ShoppingCart::curr()->Items();
        $this->assertEquals(

            $items->Count(),
            2,
            "There are 2 items in the cart"
        );

        // Remove one and see what happens
        $response = $this->get(ShoppingCart_Controller::remove_all_item_link($ball1) . "?ajax=1");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals(

            $items->Count(),
            1,
            "There is 1 item in the cart"
        );
        $this->assertFalse(

            $this->cart->get($ball1),
            "first item not in cart"
        );
        $this->assertNotNull(

            $this->cart->get($ball1),
            "second item is in cart"
        );
    }

    public function testGet()
    {
        // add items via url to setup
        $this->get(ShoppingCart_Controller::set_quantity_item_link($this->mp3player, array('quantity' => 5)));

        $this->get(ShoppingCart_Controller::add_item_link($this->socks));

        $shoppingcart = ShoppingCart::curr();
        $shoppingcart->calculate();  // recalculate the shopping cart

        $response = $this->get("shoppingcart/get" . "?ajax=1");

        $this->assertContains(
            'tableTitle',
            $response->getBody(),
            "Json contains tableTitle"
        );
        $this->assertContains(
            'tableValue',
            $response->getBody(),
            "Json contains tableValue"
        );
        $this->assertContains(
            'Tax @ 15.0%',
            $response->getBody(),
            "Contains GST modifier in the response"
        );
        $this->assertContains(
            '"subTotal":1008',
            $response->getBody(),
            "Contains SubTotal of 1008"
        );
        $this->assertContains(
            '"grandTotal":1159.2',
            $response->getBody(),
            "Contains a GrandTotal of 1159.2; the GST amount (the Flat Tax Modifier) is the difference"
        );
    }
}


1			<?php
2			/**
3			* Functional tests of json responses for shopping cart of Silverstripe Shop
4			*
5			* @package shop
6			* @subpackage tests
7			*/
8			class SilvershopJsonResponseTest extends FunctionalTest
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-08 06:37 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			protected static $fixture_file = 'silvershop/tests/fixtures/shop.yml';
11
12			public function setUpOnce()
13			{
14			if (!ShoppingCart_Controller::has_extension('SilvershopJsonResponse')) {
15			ShoppingCart_Controller::add_extension('SilvershopJsonResponse');
16			}
17			if (!VariationForm::has_extension('SilvershopJsonResponse')) {
18			VariationForm::add_extension('SilvershopJsonResponse');
19			}
20			parent::setUpOnce();
21			}
22
23			public function setUp()
24			{
25			parent::setUp();
26			ShopTest::setConfiguration(); //reset config
27			Order::config()->modifiers = array(
28			"FlatTaxModifier"
29			);
30
31			$this->mp3player = $this->objFromFixture('Product', 'mp3player');
			0 ignored issues – show Bug introduced 2016-06-08 06:37 UTC by Report Bug Copy Issue Report The property `mp3player` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			$this->socks = $this->objFromFixture('Product', 'socks');
			0 ignored issues – show Bug introduced 2016-06-08 06:37 UTC by Report Bug Copy Issue Report The property `socks` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33
34			//publish some product categories and products
35			$this->objFromFixture('ProductCategory', 'products')->publish('Stage', 'Live');
36			$this->objFromFixture('ProductCategory', 'clothing')->publish('Stage', 'Live');
37			$this->objFromFixture('ProductCategory', 'clearance')->publish('Stage', 'Live');

AntonyThorpe / silvershop-jsonresponse

Push — master ( 61756c...9c4d64 )

SilvershopJsonResponseTest::testRemoveFromCart() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like