ShopEmailPreviewTask::run() - Code Metrics - Inspection of "Added updated french translations." - AntonyThorpe/silvershop-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 04d955...252859 )

by Antony

created 2016-10-06 18:49 UTC

ShopEmailPreviewTask::run() B

↳ Parent: ShopEmailPreviewTask

Complexity

Conditions	4
Paths	4

Size

Total Lines	27
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	0
cts	18
cp	0
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	17
nc	4
nop	1
crap	20

<?php

/**
 * ShopEmailPreviewTask
 *
 * @author Anselm Christophersen <[email protected]>
 * @date   September 2016
 * @package    shop
 * @subpackage tasks
 */

/**
 * ShopEmailPreviewTask
 *
 */
class ShopEmailPreviewTask extends BuildTask
{
    protected $title       = "Preview Shop Emails";

    protected $description = 'Previews shop emails';

    protected $previewableEmails = array(
        'Confirmation',
        'Receipt',
        'AdminNotification'
    );


    /**
     * @param SS_HTTPRequest $request
     */
    public function run($request)
    {
        $email = $request->remaining();
        $params = $request->allParams();
        $url = "/dev/{$params['Action']}/{$params['TaskName']}";

        echo '<h2>Choose Email</h2>';
        echo '<ul>';
        foreach ($this->previewableEmails as $key => $method) {
            echo '<li><a href="' . $url . '/' . $method . '">' . $method . '</a></li>';
        }
        echo '</ul><hr>';

        if ($email && in_array($email,$this->previewableEmails)) {
            $order = Order::get()->first();
            $notifier = OrderEmailNotifier::create($order)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setDebugMode(true);
            $method = "send$email";
            echo $notifier->$method();

        } else {

        }
        //this is a little hardcore way of ending the party,
        //but as it's only used for styling, it works for now
        die;

    }
}


1			<?php
2
3			/**
4			* ShopEmailPreviewTask
5			*
6			* @author Anselm Christophersen <[email protected]>
7			* @date September 2016
8			* @package shop
9			* @subpackage tasks
10			*/
11
12			/**
13			* ShopEmailPreviewTask
14			*
15			*/
16			class ShopEmailPreviewTask extends BuildTask
17			{
18			protected $title = "Preview Shop Emails";
19
20			protected $description = 'Previews shop emails';
21
22			protected $previewableEmails = array(
23			'Confirmation',
24			'Receipt',
25			'AdminNotification'
26			);
27
28
29			/**
30			* @param SS_HTTPRequest $request
31			*/
32			public function run($request)
33			{
34			$email = $request->remaining();
35			$params = $request->allParams();
36			$url = "/dev/{$params['Action']}/{$params['TaskName']}";
37
38			echo '<h2>Choose Email</h2>';
39			echo '<ul>';
40			foreach ($this->previewableEmails as $key => $method) {
41			echo '<li><a href="' . $url . '/' . $method . '">' . $method . '</a></li>';
42			}
43			echo '</ul><hr>';
44
45			if ($email && in_array($email,$this->previewableEmails)) {
46			$order = Order::get()->first();
47			$notifier = OrderEmailNotifier::create($order)
			0 ignored issues – show Documentation introduced 2016-10-06 19:08 UTC by Report Bug Copy Issue Report `$order` is of type `object<DataObject>\|null`, but the function expects a `object<Order>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			->setDebugMode(true);
49			$method = "send$email";
50			echo $notifier->$method();
51
52			} else {
53
54			}
55			//this is a little hardcore way of ending the party,
56			//but as it's only used for styling, it works for now
57			die;
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-06 19:08 UTC by Report Bug Copy Issue Report The method `run()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
58			}
59			}
60

AntonyThorpe / silvershop-core

Push — master ( 04d955...252859 )

ShopEmailPreviewTask::run() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like