SilverShop\Model\Modifiers\Tax\FlatTax

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	value()	0	9	2

<?php

namespace SilverShop\Model\Modifiers\Tax;

use SilverShop\Model\Order;

/**
 * Handles calculation of sales tax on Orders.
 *
 * @package    shop
 * @subpackage modifiers
 */
class FlatTax extends Base
{
    /**
     * @config
     * @var string
     */
    private static $name            = 'GST';

The private property $name is not used, and could be removed.

    /**
     * @config
     * @var float
     */
    private static $rate            = 0.15;

    /**
     * @config
     * @var bool
     */
    private static $exclusive       = true;

    /**
     * @config
     * @var string
     */
    private static $includedmessage = '%.1f%% %s (inclusive)';

The private property $includedmessage is not used, and could be removed.

    /**
     * @config
     * @var string
     */
    private static $excludedmessage = '%.1f%% %s';

The private property $excludedmessage is not used, and could be removed.

    public function __construct($record = null, $isSingleton = false, $model = null)
    {
        parent::__construct($record, $isSingleton, $model);
        $this->Type = self::config()->exclusive ? 'Chargable' : 'Ignored';

It seems like self::config()->exclusive ? 'Chargable' : 'Ignored' of type string is incompatible with the declared type SilverStripe\ORM\FieldType\DBEnum of property $Type.

    }

    /**
     * Get the tax amount to charge on the order.
     */
    public function value($incoming)
    {
        $this->Rate = self::config()->rate;
        //inclusive tax requires a different calculation
        return self::config()->exclusive
            ?
            $incoming * $this->Rate
            :
            $incoming - round($incoming / (1 + $this->Rate), Order::config()->rounding_precision);
    }
}