Customer::createFromXMLHelper() - Code Metrics - Antidot-be/bpost-api-library - Measure and Improve Code Quality continuously with Scrutinizer

Customer::createFromXMLHelper() C
last analyzed 2016-08-25 18:47 UTC

↳ Parent: Customer

Complexity

Conditions	10
Paths	32

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	10

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	21
cts	21
cp	1
rs	5.2164
c	0
b	0
f	0
cc	10
eloc	14
nc	32
nop	2
crap	10

How to fix Complexity

<?php
namespace Bpost\BpostApiClient\Bpost\Order;

use Bpost\BpostApiClient\Exception\BpostLogicException\BpostInvalidLengthException;

/**
 * bPost Customer class
 *
 * @author Tijs Verkoyen <[email protected]>
 */
class Customer
{
    const TAG_NAME = 'customer';

    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $company;

    /**
     * @var Address
     */
    private $address;

    /**
     * @var string
     */
    private $emailAddress;

    /**
     * @var string
     */
    private $phoneNumber;

    /**
     * @param \Bpost\BpostApiClient\Bpost\Order\Address $address
     */
    public function setAddress($address)
    {
        $this->address = $address;
    }

    /**
     * @return \Bpost\BpostApiClient\Bpost\Order\Address
     */
    public function getAddress()
    {
        return $this->address;
    }

    /**
     * @param string $company
     */
    public function setCompany($company)
    {
        $this->company = $company;
    }

    /**
     * @return string
     */
    public function getCompany()
    {
        return $this->company;
    }

    /**
     * @param string $emailAddress
     * @throws BpostInvalidLengthException
     */
    public function setEmailAddress($emailAddress)

    {
        $length = 50;
        if (mb_strlen($emailAddress) > $length) {
            throw new BpostInvalidLengthException('emailAddress', mb_strlen($emailAddress), $length);
        }
        $this->emailAddress = $emailAddress;
    }

    /**
     * @return string
     */
    public function getEmailAddress()
    {
        return $this->emailAddress;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $phoneNumber
     * @throws BpostInvalidLengthException
     */
    public function setPhoneNumber($phoneNumber)

    {
        $length = 20;
        if (mb_strlen($phoneNumber) > $length) {
            throw new BpostInvalidLengthException('phoneNumber', mb_strlen($phoneNumber), $length);
        }
        $this->phoneNumber = $phoneNumber;
    }

    /**
     * @return string
     */
    public function getPhoneNumber()
    {
        return $this->phoneNumber;
    }

    /**
     * Return the object as an array for usage in the XML
     *
     * @param \DomDocument $document
     * @param  string      $prefix

     * @return \DomElement
     */
    public function toXML(\DomDocument $document, $prefix = null)
    {
        $tagName = static::TAG_NAME;
        if ($prefix !== null) {
            $tagName = $prefix . ':' . $tagName;
        }

        $customer = $document->createElement($tagName);

        if ($this->getName() !== null) {
            $customer->appendChild(
                $document->createElement(
                    'common:name',
                    $this->getName()
                )
            );
        }
        if ($this->getCompany() !== null) {
            $customer->appendChild(
                $document->createElement(
                    'common:company',
                    $this->getCompany()
                )
            );
        }
        if ($this->getAddress() !== null) {
            $customer->appendChild(
                $this->getAddress()->toXML($document)
            );
        }
        if ($this->getEmailAddress() !== null) {
            $customer->appendChild(
                $document->createElement(
                    'common:emailAddress',
                    $this->getEmailAddress()
                )
            );
        }
        if ($this->getPhoneNumber() !== null) {
            $customer->appendChild(
                $document->createElement(
                    'common:phoneNumber',
                    $this->getPhoneNumber()
                )
            );
        }

        return $customer;
    }

    /**
     * @param  \SimpleXMLElement $xml
     * @param  Customer          $instance
     *
     * @return Customer
     * @throws BpostInvalidLengthException
     */
    public static function createFromXMLHelper(\SimpleXMLElement $xml, Customer $instance)
    {
        if (isset($xml->name) && $xml->name != '') {
            $instance->setName((string) $xml->name);
        }
        if (isset($xml->company) && $xml->company != '') {
            $instance->setCompany((string) $xml->company);
        }
        if (isset($xml->address)) {
            $instance->setAddress(
                Address::createFromXML($xml->address)
            );
        }
        if (isset($xml->emailAddress) && $xml->emailAddress != '') {
            $instance->setEmailAddress(
                (string) $xml->emailAddress
            );
        }
        if (isset($xml->phoneNumber) && $xml->phoneNumber != '') {
            $instance->setPhoneNumber((string) $xml->phoneNumber);
        }

        return $instance;
    }
}


1			<?php
2			namespace Bpost\BpostApiClient\Bpost\Order;
3
4			use Bpost\BpostApiClient\Exception\BpostLogicException\BpostInvalidLengthException;
5
6			/**
7			* bPost Customer class
8			*
9			* @author Tijs Verkoyen <[email protected]>
10			*/
11			class Customer
12			{
13			const TAG_NAME = 'customer';
14
15			/**
16			* @var string
17			*/
18			private $name;
19
20			/**
21			* @var string
22			*/
23			private $company;
24
25			/**
26			* @var Address
27			*/
28			private $address;
29
30			/**
31			* @var string
32			*/
33			private $emailAddress;
34
35			/**
36			* @var string
37			*/
38			private $phoneNumber;
39
40			/**
41			* @param \Bpost\BpostApiClient\Bpost\Order\Address $address
42			*/
43	12		public function setAddress($address)
44			{
45	12		$this->address = $address;
46	12		}
47
48			/**
49			* @return \Bpost\BpostApiClient\Bpost\Order\Address
50			*/
51	10		public function getAddress()
52			{
53	10		return $this->address;
54			}
55
56			/**
57			* @param string $company
58			*/
59	12		public function setCompany($company)
60			{
61	12		$this->company = $company;
62	12		}
63
64			/**
65			* @return string
66			*/
67	12		public function getCompany()
68			{
69	12		return $this->company;
70			}
71
72			/**
73			* @param string $emailAddress
74			* @throws BpostInvalidLengthException
75			*/
76	15	View Code Duplication	public function setEmailAddress($emailAddress)
			0 ignored issues – show Duplication introduced 2016-03-24 10:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77			{
78	15		$length = 50;
79	15		if (mb_strlen($emailAddress) > $length) {
80	3		throw new BpostInvalidLengthException('emailAddress', mb_strlen($emailAddress), $length);
81			}
82	12		$this->emailAddress = $emailAddress;
83	12		}
84
85			/**
86			* @return string
87			*/
88	10		public function getEmailAddress()
89			{
90	10		return $this->emailAddress;
91			}
92
93			/**
94			* @param string $name
95			*/
96	12		public function setName($name)
97			{
98	12		$this->name = $name;
99	12		}
100
101			/**
102			* @return string
103			*/
104	10		public function getName()
105			{
106	10		return $this->name;
107			}
108
109			/**
110			* @param string $phoneNumber
111			* @throws BpostInvalidLengthException
112			*/
113	15	View Code Duplication	public function setPhoneNumber($phoneNumber)
			0 ignored issues – show Duplication introduced 2016-03-24 10:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114			{
115	15		$length = 20;
116	15		if (mb_strlen($phoneNumber) > $length) {
117	3		throw new BpostInvalidLengthException('phoneNumber', mb_strlen($phoneNumber), $length);
118			}
119	12		$this->phoneNumber = $phoneNumber;
120	12		}
121
122			/**
123			* @return string
124			*/
125	10		public function getPhoneNumber()
126			{
127	10		return $this->phoneNumber;
128			}
129
130			/**
131			* Return the object as an array for usage in the XML
132			*
133			* @param \DomDocument $document
134			* @param string $prefix
			0 ignored issues – show Documentation introduced 2016-03-24 12:08 UTC by Report Bug Copy Issue Report Should the type for parameter `$prefix` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
135			* @return \DomElement
136			*/
137	9		public function toXML(\DomDocument $document, $prefix = null)
138			{
139	9		$tagName = static::TAG_NAME;
140	9		if ($prefix !== null) {
141	3		$tagName = $prefix . ':' . $tagName;
142	3		}
143
144	9		$customer = $document->createElement($tagName);
145
146	9		if ($this->getName() !== null) {
147	9		$customer->appendChild(
148	9		$document->createElement(
149	9		'common:name',
150	9		$this->getName()
151	9		)
152	9		);
153	9		}
154	9		if ($this->getCompany() !== null) {
155	9		$customer->appendChild(
156	9		$document->createElement(
157	9		'common:company',
158	9		$this->getCompany()
159	9		)
160	9		);
161	9		}
162	9		if ($this->getAddress() !== null) {
163	9		$customer->appendChild(
164	9		$this->getAddress()->toXML($document)
165	9		);
166	9		}
167	9		if ($this->getEmailAddress() !== null) {
168	9		$customer->appendChild(
169	9		$document->createElement(
170	9		'common:emailAddress',
171	9		$this->getEmailAddress()
172	9		)
173	9		);
174	9		}
175	9		if ($this->getPhoneNumber() !== null) {
176	9		$customer->appendChild(
177	9		$document->createElement(
178	9		'common:phoneNumber',
179	9		$this->getPhoneNumber()
180	9		)
181	9		);
182	9		}
183
184	9		return $customer;
185			}
186
187			/**
188			* @param \SimpleXMLElement $xml
189			* @param Customer $instance
190			*
191			* @return Customer
192			* @throws BpostInvalidLengthException
193			*/
194	3		public static function createFromXMLHelper(\SimpleXMLElement $xml, Customer $instance)
195			{
196	3		if (isset($xml->name) && $xml->name != '') {
197	3		$instance->setName((string) $xml->name);
198	3		}
199	3		if (isset($xml->company) && $xml->company != '') {
200	3		$instance->setCompany((string) $xml->company);
201	3		}
202	3		if (isset($xml->address)) {
203	3		$instance->setAddress(
204	3		Address::createFromXML($xml->address)
205	3		);
206	3		}
207	3		if (isset($xml->emailAddress) && $xml->emailAddress != '') {
208	3		$instance->setEmailAddress(
209	3		(string) $xml->emailAddress
210	3		);
211	3		}
212	3		if (isset($xml->phoneNumber) && $xml->phoneNumber != '') {
213	3		$instance->setPhoneNumber((string) $xml->phoneNumber);
214	3		}
215
216	3		return $instance;
217			}
218			}
219

Antidot-be / bpost-api-library

Customer::createFromXMLHelper() C last analyzed 2016-08-25 18:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Customer::createFromXMLHelper() C
last analyzed 2016-08-25 18:47 UTC