Bpost\BpostApiClient\Bpost\Order\Line

Complexity

Total Complexity

18

Size/Duplication

Total Lines	119
Duplicated Lines	10.08 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setNumberOfItems()	0	4	1
A	getNumberOfItems()	0	4	1
A	setText()	0	4	1
A	getText()	0	4	1
A	__construct()	0	9	3
B	toXML()	12	36	6
B	createFromXML()	0	12	5

<?php
namespace Bpost\BpostApiClient\Bpost\Order;

/**
 * bPost Line class
 *
 * @author Tijs Verkoyen <php-bpost@verkoyen.eu>
 */
class Line
{
    /**
     * @var string
     */
    private $text;

    /**
     * @var int
     */
    private $numberOfItems;

    /**
     * @param int $nbOfItems
     */
    public function setNumberOfItems($nbOfItems)
    {
        $this->numberOfItems = $nbOfItems;
    }

    /**
     * @return int
     */
    public function getNumberOfItems()
    {
        return $this->numberOfItems;
    }

    /**
     * @param string $text
     */
    public function setText($text)
    {
        $this->text = $text;
    }

    /**
     * @return string
     */
    public function getText()
    {
        return $this->text;
    }

    /**
     * @param string $text

Should the type for parameter $text not be string|null?

     * @param int    $numberOfItems

Should the type for parameter $numberOfItems not be integer|null?

     */
    public function __construct($text = null, $numberOfItems = null)
    {
        if ($text != null) {

It seems like you are loosely comparing $text of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $this->setText($text);
        }
        if ($numberOfItems != null) {

It seems like you are loosely comparing $numberOfItems of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $this->setNumberOfItems($numberOfItems);
        }
    }

    /**
     * Return the object as an array for usage in the XML
     *
     * @param  \DomDocument $document
     * @param  string       $prefix

Should the type for parameter $prefix not be string|null?

     * @return \DOMElement
     */
    public function toXML(\DomDocument $document, $prefix = null)
    {
        $tagName = 'orderLine';
        if ($prefix !== null) {
            $tagName = $prefix . ':' . $tagName;
        }

        $line = $document->createElement($tagName);

        if ($this->getText() !== null) {

This code seems to be duplicated across your project.

            $tagName = 'text';
            if ($prefix !== null) {
                $tagName = $prefix . ':' . $tagName;
            }
            $line->appendChild(
                $document->createElement(
                    $tagName,
                    $this->getText()
                )
            );
        }
        if ($this->getNumberOfItems() !== null) {
            $tagName = 'nbOfItems';
            if ($prefix !== null) {
                $tagName = $prefix . ':' . $tagName;
            }
            $line->appendChild(
                $document->createElement(
                    $tagName,
                    $this->getNumberOfItems()
                )
            );
        }

        return $line;
    }

    /**
     * @param  \SimpleXMLElement $xml
     * @return Line
     */
    public static function createFromXML(\SimpleXMLElement $xml)
    {
        $line = new Line();
        if (isset($xml->text) && $xml->text != '') {
            $line->setText((string) $xml->text);
        }
        if (isset($xml->nbOfItems) && $xml->nbOfItems != '') {
            $line->setNumberOfItems((int) $xml->nbOfItems);
        }

        return $line;
    }
}