ClientBundle\Controller\SonataAdminClientController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	preCreate()	0	6	1
A	preEdit()	0	6	1
C	updateContacts()	0	55	10

<?php

namespace ClientBundle\Controller;

use Sonata\AdminBundle\Controller\CRUDController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class SonataAdminClientController
 */
class SonataAdminClientController extends CRUDController
{
    /**
     * @param Request $request
     * @param mixed   $object
     * @return null|Response
     */
    protected function preCreate(Request $request, $object)
    {
        parent::preCreate($request, $object);

        return $this->updateContacts($request, $object);
    }

    /**
     * @param Request $request
     * @param mixed   $object
     * @return null|Response
     */
    protected function preEdit(Request $request, $object)
    {
        parent::preEdit($request, $object);

        return $this->updateContacts($request, $object);
    }

    private function updateContacts(Request $request, $object)
    {
        $arr1 = [];
        //шматок гавнокода
        $postData = $request->request->all();
        foreach ($postData as $arr) {
            $arr1 = $arr;
            break;
        }
        $tmpTest = '';

        if ($postData) {

The expression $postData of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $oldContacts = null;

$oldContacts is not used, you could remove the assignment.

            $newContacts = null;

$newContacts is not used, you could remove the assignment.

            $oldContacts = $object->getContacts();
            $em = $this->getDoctrine()->getManager();
            if (array_key_exists('contacts', $arr1)) {
                $newContacts = $arr1['contacts'];

                // Викидуем з массива нових контактів, які прийшли з POST, ті що вже були
                // і видаляем з бази контакти які видалені у клієнта
                foreach ($oldContacts as $contact) {
                    $k = array_search($contact->getId(), $newContacts);
                    if (false === $k) {
                        $object->removeContact($contact);
                        $em->remove($contact);
                    } else {
                        unset($newContacts[$k]);
                    }
                }

                foreach ($newContacts as $contactId) {
                    $contact = $em->getRepository('ClientBundle:Contact')->find($contactId);
                    if (!$contact) {
                        throw $this->createNotFoundException(sprintf('не знайдений об\'єкт з id : %s', $contactId));
                    } else {
                        $object->addContact($contact);
                        $contact->setClient($object);
                    }
                }
            } else {
                // Post прийшов без контактів - видаляем всі контакти клієнта
                foreach ($oldContacts as $contact) {
                    $object->removeContact($contact);
                    $em->remove($contact);
                }
            }
        }

        if ('' === $tmpTest) {
            return null;
        } else {
            return new Response($tmpTest);
        }
    }
}