ClientBundle\Controller\SecurityController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	46
Duplicated Lines	65.22 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	loginAction()	15	15	1
A	checkloginAction()	15	15	1

<?php

namespace ClientBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class SecurityController
 */
class SecurityController extends Controller
{
    /**
     * @param Request $request
     * @Route("/login", name="login")
     * @Method({"GET", "POST"})
     * @return Response
     */
    public function loginAction(Request $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $authenticationUtils = $this->get('security.authentication_utils');

        // get the login error if there is one
        $error = $authenticationUtils->getLastAuthenticationError();

        // last username entered by the user
        $lastUsername = $authenticationUtils->getLastUsername();

        return $this->render('ClientBundle:Security:login.html.twig', array(
            'last_username' => $lastUsername,
            'error'         => $error,
        ));
    }

    /**
     * @param Request $request
     * @Route("/checklogin", name="checklogin")
     * @Method({"GET", "POST"})
     * @return Response
     */
    public function checkloginAction(Request $request)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $authenticationUtils = $this->get('security.authentication_utils');

        // get the login error if there is one
        $error = $authenticationUtils->getLastAuthenticationError();

        // last username entered by the user
        $lastUsername = $authenticationUtils->getLastUsername();

        return $this->render('ClientBundle:Security:login.html.twig', [
            'last_username' => $lastUsername,
            'error'         => $error,
        ]);
    }
}