ClientBundle\Controller\ContactTypeController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	98
Duplicated Lines	45.92 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
C	showAction()	27	27	8
A	homeAction()	0	7	1
A	addAction()	18	18	4
A	delAction()	0	20	3

<?php

namespace ClientBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use ClientBundle\Entity\ContactType;
use ClientBundle\Form\Type\ContactTypeForm;

/**
 * Class ContactTypeController
 */
class ContactTypeController extends Controller
{
    /**
     * @param int     $id
     * @param Request $request
     * @Method({"GET", "POST"})
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function showAction($id, Request $request)

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();
        $contactType = $em->getRepository('ClientBundle:ContactType')->find($id);
        if (!$contactType) {
            throw $this->createNotFoundException(sprintf('не знайдений об\'єкт з id : %s', $id));
        } else {
            $form = $this->createForm(ContactTypeForm::class, $contactType);
            if ($this->isGranted('ROLE_ADMIN')) {
                $form->add('delete', SubmitType::class);
            }

            $form->handleRequest($request);

            if ($request->isMethod('POST') && $form->isSubmitted() && $form->isValid()) {
                $contactType = $form->getData();
                if ($this->isGranted('ROLE_ADMIN') && $form->get('delete')->isClicked()) {

The method isClicked() does not seem to exist on object<Symfony\Component\Form\Form>.

                    return $this->redirectToRoute('contacttype_del', array('id' => $contactType->getId()));
                }
                $em->flush();

                return $this->redirectToRoute('contacttype_home');
            }

            return $this->render('ClientBundle:ContactType:edit.html.twig', ['form' => $form->createView(), 'contactType' => $contactType]);
        }
    }

    /**
     * @Method("GET")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function homeAction()
    {
        $em = $this->getDoctrine()->getManager();
        $contactType = $em->getRepository('ClientBundle:ContactType')->findAll();

        return $this->render('ClientBundle:ContactType:home.html.twig', ['contactTypes' => $contactType]);
    }

    /**
     * @param Request $request
     * @Method({"GET", "POST"})
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function addAction(Request $request)

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();
        $contactType = new ContactType();
        $form = $this->createForm(ContactTypeForm::class, $contactType);

        $form->handleRequest($request);

        if ($request->isMethod('POST') && $form->isSubmitted() && $form->isValid()) {
            $contactType = $form->getData();
            $em->persist($contactType);
            $em->flush();

            return $this->redirectToRoute('contacttype_home');
        }

        return $this->render('ClientBundle:ContactType:edit.html.twig', ['form' => $form->createView(), 'contactType' => $contactType]);
    }

    /**
     * @param int $id
     * @Method({"GET", "POST"})
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function delAction($id)
    {
        $em = $this->getDoctrine()->getManager();
        $contactType = $em->getRepository('ClientBundle:ContactType')->find($id);
        if (!$contactType) {
            throw $this->createNotFoundException(sprintf('не знайдений об\'єкт з id : %s', $id));
        } else {
            $em = $this->getDoctrine()->getManager();
            $contacts = $em->getRepository('ClientBundle:Contact')->findBy(['type' => $id]);
            foreach ($contacts as $contact) {
                $client = $contact->getClient();
                $client->removeContact($contact);
                $em->remove($contact);
            }
            $em->remove($contactType);
            $em->flush();
        }

        return $this->redirectToRoute('contacttype_home');
    }
}