AndrewCarterUK\NoMoreLeaksBundle\Resetter\MonologResetter::resetHandler()

Complexity

Conditions	7
Paths	13

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	7

Importance

Changes

0

<?php
    private function resetHandler(HandlerInterface $handler)
    {
        $class = get_class($handler);

        $prefix = 'Monolog\\Handler\\';

        if (substr($class, 0, strlen($prefix)) == $prefix) {
            $handlerName = substr($class, strlen($prefix));

            if ('FingersCrossedHandler' == $handlerName) {
                $handler->clear();

It seems like you code against a concrete implementation and not the interface Monolog\Handler\HandlerInterface as the method clear() does only exist in the following implementations of said interface: Monolog\Handler\BufferHandler, Monolog\Handler\DeduplicationHandler, Monolog\Handler\ExceptionTestHandler, Monolog\Handler\FingersCrossedHandler, Monolog\Handler\TestHandler.

            } elseif ('BufferHandler' == $handlerName || 'StreamHandler' == $handlerName) {
                $handler->close();

It seems like you code against a concrete implementation and not the interface Monolog\Handler\HandlerInterface as the method close() does only exist in the following implementations of said interface: Monolog\Handler\AbstractHandler, Monolog\Handler\AbstractProcessingHandler, Monolog\Handler\AbstractSyslogHandler, Monolog\Handler\AmqpHandler, Monolog\Handler\BrowserConsoleHandler, Monolog\Handler\BufferHandler, Monolog\Handler\ChromePHPHandler, Monolog\Handler\CouchDBHandler, Monolog\Handler\CubeHandler, Monolog\Handler\DeduplicationHandler, Monolog\Handler\DoctrineCouchDBHandler, Monolog\Handler\DynamoDbHandler, Monolog\Handler\ElasticSearchHandler, Monolog\Handler\ErrorLogHandler, Monolog\Handler\ExceptionTestHandler, Monolog\Handler\FilterHandler, Monolog\Handler\FingersCrossedHandler, Monolog\Handler\FirePHPHandler, Monolog\Handler\FleepHookHandler, Monolog\Handler\FlowdockHandler, Monolog\Handler\GelfHandler, Monolog\Handler\GroupHandler, Monolog\Handler\HipChatHandler, Monolog\Handler\IFTTTHandler, Monolog\Handler\LogEntriesHandler, Monolog\Handler\LogglyHandler, Monolog\Handler\MailHandler, Monolog\Handler\MandrillHandler, Monolog\Handler\MongoDBHandler, Monolog\Handler\NativeMailerHandler, Monolog\Handler\NewRelicHandler, Monolog\Handler\NullHandler, Monolog\Handler\PHPConsoleHandler, Monolog\Handler\PsrHandler, Monolog\Handler\PushoverHandler, Monolog\Handler\RavenHandler, Monolog\Handler\RedisHandler, Monolog\Handler\RollbarHandler, Monolog\Handler\RotatingFileHandler, Monolog\Handler\SamplingHandler, Monolog\Handler\SlackHandler, Monolog\Handler\SlackWebhookHandler, Monolog\Handler\SlackbotHandler, Monolog\Handler\SocketHandler, Monolog\Handler\StreamHandler, Monolog\Handler\StubNewRelicHandler, Monolog\Handler\StubNewRelicHandlerWithoutExtension, Monolog\Handler\SwiftMailerHandler, Monolog\Handler\SyslogHandler, Monolog\Handler\SyslogUdpHandler, Monolog\Handler\TestChromePHPHandler, Monolog\Handler\TestFirePHPHandler, Monolog\Handler\TestHandler, Monolog\Handler\WhatFailureGroupHandler, Monolog\Handler\ZendMonitorHandler.

            }

            if (property_exists($handler, 'handler')) {
                $subHandler = Util::readProperty($handler, 'handler');
                $this->resetHandler($subHandler);
            }

            if (property_exists($handler, 'handlers')) {
                $subHandlers = Util::readProperty($handler, 'handlers');
                $this->resetHandlers($subHandlers);
            }
        }
    }
}