AmsTaFFix / extjs-bundle

Generator/RestControllerGenerator.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Tpg\ExtjsBundle\Generator;
 
-use Doctrine\ORM\Mapping\Driver\SimplifiedYamlDriver;
 use Sensio\Bundle\GeneratorBundle\Generator\ControllerGenerator;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\Yaml\Yaml;

Spacing +3 added lines, -3 removed lines

@@ -64,11 +64,11 @@
             'trait'      => $this->trait,
             'namespace'  => $bundle->getNamespace(),
             'bundle'     => $bundle->getName(),
-            "manager"    => ($this->mongo===true)?"doctrine_mongodb.odm.default_document_manager":"doctrine.orm.default_entity_manager",
-            'serializer' => ($this->mongo===true)?"tpg_extjs.odm_serializer":"tpg_extjs.orm_serializer",
+            "manager"    => ($this->mongo === true) ? "doctrine_mongodb.odm.default_document_manager" : "doctrine.orm.default_entity_manager",
+            'serializer' => ($this->mongo === true) ? "tpg_extjs.odm_serializer" : "tpg_extjs.orm_serializer",
             'controller'        => $controller,
             'entity_class'      => $entityClass,
-            'entity_name'       => str_replace(array("/","\\"), "_", $this->entityName),
+            'entity_name'       => str_replace(array("/", "\\"), "_", $this->entityName),
             'entity_bundle'     => $this->entityBundle->getName(),
             'entity'            => array_pop($tmpEntity),
             'route_name_prefix' => strtolower(preg_replace('/([A-Z])/', '_\\1', $bundle->getName().'_api_'))

Tests/Command/BaseTestGeneratedRestController.php

Unused Use Statements -7 removed lines

@@ -3,16 +3,9 @@
 
 include_once(__DIR__ . '/../app/AppKernel.php');
 
-use Doctrine\Bundle\MongoDBBundle\Command\CreateSchemaDoctrineODMCommand;
-use Doctrine\Bundle\MongoDBBundle\Command\DropSchemaDoctrineODMCommand;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
-use Doctrine\Bundle\DoctrineBundle\Command\CreateDatabaseDoctrineCommand;
-use Doctrine\Bundle\DoctrineBundle\Command\DropDatabaseDoctrineCommand;
-use Doctrine\Bundle\DoctrineBundle\Command\Proxy\CreateSchemaDoctrineCommand;
-
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Tester\CommandTester;
-use Symfony\Component\Routing\Router;
 use Tpg\ExtjsBundle\Command\GenerateRestControllerCommand;
 
 class BaseTestGeneratedRestController extends WebTestCase {

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 namespace Tpg\ExtjsBundle\Tests\Command;
 
-include_once(__DIR__ . '/../app/AppKernel.php');
+include_once(__DIR__.'/../app/AppKernel.php');
 
 use Doctrine\Bundle\MongoDBBundle\Command\CreateSchemaDoctrineODMCommand;
 use Doctrine\Bundle\MongoDBBundle\Command\DropSchemaDoctrineODMCommand;

Controller/GeneratorController.php

Spacing +9 added lines, -9 removed lines

@@ -20,26 +20,26 @@ 
         $kernel = $this->get('kernel');
         if ($models === null) {
             $list = $this->container->getParameter("tpg_extjs.entities");
-            return new StreamedResponse(function () use($list, $generator, $kernel) {
+            return new StreamedResponse(function() use($list, $generator, $kernel) {
                 foreach ($list as $configEntityLine) {
                     list($bundleName, $path) = explode("/", substr($configEntityLine, 1), 2);
                     /** @var Bundle $bundle */
                     $bundle = $kernel->getBundle($bundleName, true);
 
                     /** Entity end with backslash, it is a directory */
-                    $loadAllEntitiesFromDir = ($configEntityLine[strlen($configEntityLine)-1] == "/");
+                    $loadAllEntitiesFromDir = ($configEntityLine[strlen($configEntityLine) - 1] == "/");
 
-                    if ( $loadAllEntitiesFromDir ) {
+                    if ($loadAllEntitiesFromDir) {
                         $bundleRef = new \ReflectionClass($bundle);
                         $dir = new Finder();
                         $dir->files()->depth('== 0')->in(dirname($bundleRef->getFileName()).'/'.$path)->name('/.*\.php$/');
-                        foreach($dir as $file) {
+                        foreach ($dir as $file) {
                             /** @var SplFileInfo $file*/
-                            $entityClassname = $bundleRef->getNamespaceName() . "\\" . str_replace("/", "\\", $path) . substr($file->getFilename(), 0, -4);
+                            $entityClassname = $bundleRef->getNamespaceName()."\\".str_replace("/", "\\", $path).substr($file->getFilename(), 0, -4);
                             echo $generator->generateMarkupForEntity($entityClassname);
                         }
-                    } else  {
-                        $entityClassname = $bundle->getNamespace() . "\\" . str_replace("/", "\\", $path);
+                    } else {
+                        $entityClassname = $bundle->getNamespace()."\\".str_replace("/", "\\", $path);
                         echo $generator->generateMarkupForEntity($entityClassname);
                     }
                 }
@@ -51,7 +51,7 @@ 
             if (!is_array($models)) {
                 $models = array($models);
             }
-            return new StreamedResponse(function () use($models, $generator) {
+            return new StreamedResponse(function() use($models, $generator) {
                 foreach ($models as $model) {
                     $model = str_replace(".", "\\", $model);
                     echo $generator->generateMarkupForEntity($model);
@@ -102,7 +102,7 @@ 
         } else {
             $requestData = array();
             $i = 0;
-            foreach($actionparams as $parameter) {
+            foreach ($actionparams as $parameter) {
                 $requestData[$parameter->getName()] = $data[$i++];
             }
         }

Tests/Service/GeneratorServiceTest.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         $this->twigEngine = new TwigEngineMokcup();
         $this->service->setTwigEngine($this->twigEngine);
         $this->service->setModelFieldsParameters(array(
-          "date" => array( "format" => "d-m-y")
+          "date" => array("format" => "d-m-y")
         ));
     }
 

Tests/Command/ORM/GeneratedRestControllerTest.php

Spacing +2 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
 
     public function testGetsActionWithFilterOnName() {
         $filter = json_encode(array(
-            array('property'=>'name','value'=>'Ford')
+            array('property'=>'name', 'value'=>'Ford')
         ));
         $this->client->request('GET', '/cars.json?filter='.$filter);
         $content = json_decode($this->client->getResponse()->getContent(), true);
@@ -26,7 +26,7 @@ 
 
     public function testGetsActionWithFilterOnPlateNumner() {
         $filter = json_encode(array(
-            array('property'=>'plateNumber','value'=>'BB243')
+            array('property'=>'plateNumber', 'value'=>'BB243')
         ));
         $this->client->request('GET', '/cars.json?filter='.$filter);
         $content = json_decode($this->client->getResponse()->getContent(), true);

Tests/Command/ORM/GeneratedRestControllerAssociationTest.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
         $manager = $this->client->getContainer()->get("doctrine.orm.default_entity_manager");
         $owner = new CarOwner();
         $owner->setName("james");
-        foreach($this->records as $record) {
+        foreach ($this->records as $record) {
             $owner->addCar($record);
         }
         $manager->persist($owner);
@@ -44,7 +44,7 @@ 
 
     public function testGetWithAssociation() {
         $filter = json_encode(array(
-            array('property'=>'name','value'=>'Ford')
+            array('property'=>'name', 'value'=>'Ford')
         ));
         $this->client->request('GET', '/cars.json?filter='.$filter);
         $content = json_decode($this->client->getResponse()->getContent(), true);

Tests/Command/ODM/GenerateRestControllerCommandTest.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 namespace Tpg\ExtjsBundle\Tests\Command\ODM;
 
-include_once(__DIR__ . '/../../app/AppKernel.php');
+include_once(__DIR__.'/../../app/AppKernel.php');
 
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Tester\CommandTester;

Tests/Command/ODM/GeneratedRestControllerEmbeddedAssociationTest.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 
     public function testGetWithAssociation() {
         $filter = json_encode(array(
-            array('property'=>'name','value'=>'Invoice 1')
+            array('property'=>'name', 'value'=>'Invoice 1')
         ));
         $this->client->request('GET', '/orders.json?filter='.$filter);
         $content = json_decode($this->client->getResponse()->getContent(), true);

Tests/app_test.php

Spacing +2 added lines, -2 removed lines

@@ -5,8 +5,8 @@
     exit(0);
 }
 
-$loader = require_once __DIR__ . '/bootstrap.php';
-require_once __DIR__ . '/app/AppKernel.php';
+$loader = require_once __DIR__.'/bootstrap.php';
+require_once __DIR__.'/app/AppKernel.php';
 use Symfony\Component\HttpFoundation\Request;
 
 $kernel = new AppKernel('test', true);