AmsTaFFix / extjs-bundle

Generator/RestControllerGenerator.php

Doc Comments +17 added lines

@@ -18,6 +18,9 @@ 
      */
     protected $entityBundle;
 
+    /**
+     * @param string $name
+     */
     public function setEntityName($name) {
         $this->entityName = $name;
     }
@@ -25,18 +28,32 @@ 
         $this->entityBundle = $bundle;
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setUseTrait($flag) {
         $this->trait = $flag;
     }
 
+    /**
+     * @param string $file
+     */
     public function setTemplateFile($file) {
         $this->template = $file;
     }
 
+    /**
+     * @param boolean $mongo
+     */
     public function setMongo($mongo) {
         $this->mongo = $mongo;
     }
 
+    /**
+     * @param string $controller
+     * @param string $routeFormat
+     * @param string $templateFormat
+     */
     public function generate(BundleInterface $bundle, $controller, $routeFormat, $templateFormat, array $actions = array())
     {
         $dir = $bundle->getPath();

Service/GeneratorService.php

Doc Comments +13 added lines, -4 removed lines

@@ -27,10 +27,16 @@ 
     protected $remotingBundles = array();
     protected $fieldsParams = array();
 
+    /**
+     * @param AnnotationReader $reader
+     */
     public function setAnnotationReader($reader) {
         $this->annoReader = $reader;
     }
 
+    /**
+     * @param \Test\TestBundle\Mockup\TwigEngineMokcup $engine
+     */
     public function setTwigEngine($engine) {
         $this->twig = $engine;
     }
@@ -127,6 +133,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function convertNaming($name) {
         return $name;
     }
@@ -351,9 +360,9 @@ 
 
     /**
      * Get Annotation
-     * @param $entity
-     * @param $property
-     * @param $annotation
+     * @param string $entity
+     * @param string $property
+     * @param string $annotation
      * @return Annotation|null
      */
     protected function getAnnotation($entity, $property, $annotation) {
@@ -367,7 +376,7 @@ 
      * Get Column Type of a model.
      *
      * @param $entity string Class name of the entity
-     * @param $property string
+     * @param string $property string
      * @return string
      */
     public function getEntityColumnType($entity, $property) {

Braces +14 added lines, -6 removed lines

@@ -98,8 +98,12 @@ 
                 $structure['proxy'] = array(
                     'type'=>$classModelProxyAnnotation->name,
                 ) + $classModelProxyAnnotation->option;
-                if ($classModelProxyAnnotation->reader != array()) $structure['proxy']['reader'] = $classModelProxyAnnotation->reader;
-                if ($classModelProxyAnnotation->writer != array()) $structure['proxy']['writer'] = $classModelProxyAnnotation->writer;
+                if ($classModelProxyAnnotation->reader != array()) {
+                    $structure['proxy']['reader'] = $classModelProxyAnnotation->reader;
+                }
+                if ($classModelProxyAnnotation->writer != array()) {
+                    $structure['proxy']['writer'] = $classModelProxyAnnotation->writer;
+                }
             }
             /** @var $classExclusionPolicy ExclusionPolicy */
             $classExclusionPolicy = $this->annoReader->getClassAnnotation($classRef, 'JMS\Serializer\Annotation\ExclusionPolicy');
@@ -222,8 +226,9 @@ 
                     $association['name'] = $property->getName();
                     $association['model'] = $this->getModelName($annotation->targetEntity);
                     $association['entity'] = $annotation->targetEntity;
-                    if (!isset($association['key']) || empty($association['key']))
-                        $association['key'] = $this->tryToGetJoinColumnNameOfMappedBy($annotation);
+                    if (!isset($association['key']) || empty($association['key'])) {
+                                            $association['key'] = $this->tryToGetJoinColumnNameOfMappedBy($annotation);
+                    }
                     break;
                 case 'Doctrine\ORM\Mapping\OneToMany':
                     $association['type'] = substr(get_class($annotation), 21);
@@ -358,8 +363,11 @@ 
     protected function getAnnotation($entity, $property, $annotation) {
         $classRef = new \ReflectionClass($entity);
         $propertyRef = $classRef->getProperty($property);
-        if ($propertyRef) return $this->annoReader->getPropertyAnnotation($propertyRef, $annotation);
-        else return null;
+        if ($propertyRef) {
+            return $this->annoReader->getPropertyAnnotation($propertyRef, $annotation);
+        } else {
+            return null;
+        }
     }
 
     /**

Tests/Fixtures/Test/TestBundle/Document/Client.php

Doc Comments +3 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
     /**
      * Add orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      *
      * @return $this
      */
@@ -109,7 +109,7 @@ 
     /**
      * Remove orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      */
     public function removeOrder(\Test\TestBundle\Document\Order $orders)
     {
@@ -120,7 +120,7 @@ 
     /**
      * Get orders
      *
-     * @return Doctrine\Common\Collections\Collection $orders
+     * @return \Doctrine\Common\Collections\ArrayCollection $orders
      */
     public function getOrders()
     {

Twig/ExtjsExtension.php

Doc Comments -2 removed lines

@@ -48,8 +48,6 @@
     /**
      * Inject ExtJs Model into the DOM.
      *
-     * @param boolean $injection Produce ExtJS model code on the page directly?
-     * @param string $model Model Name.
      */
     public function injectModel() {
         $params = func_get_args();

TpgExtjsBundle.php

Braces +12 added lines, -8 removed lines

@@ -17,18 +17,22 @@
 
         $builder->addCompilerPass(new LazyServiceMapPass('tpg_extjs.serialization_visitor', 'format',
             function(ContainerBuilder $container, Definition $def) {
-                if ($container->hasDefinition("tpg_extjs.orm_serializer"))
-                    $container->getDefinition('tpg_extjs.orm_serializer')->replaceArgument(3, $def);
-                if ($container->hasDefinition("tpg_extjs.odm_serializer"))
-                    $container->getDefinition('tpg_extjs.odm_serializer')->replaceArgument(3, $def);
+                if ($container->hasDefinition("tpg_extjs.orm_serializer")) {
+                                    $container->getDefinition('tpg_extjs.orm_serializer')->replaceArgument(3, $def);
+                }
+                if ($container->hasDefinition("tpg_extjs.odm_serializer")) {
+                                    $container->getDefinition('tpg_extjs.odm_serializer')->replaceArgument(3, $def);
+                }
             }
         ));
         $builder->addCompilerPass(new LazyServiceMapPass('tpg_extjs.deserialization_visitor', 'format',
             function(ContainerBuilder $container, Definition $def) {
-                if ($container->hasDefinition("tpg_extjs.orm_serializer"))
-                    $container->getDefinition('tpg_extjs.orm_serializer')->replaceArgument(4, $def);
-                if ($container->hasDefinition("tpg_extjs.odm_serializer"))
-                    $container->getDefinition('tpg_extjs.odm_serializer')->replaceArgument(4, $def);
+                if ($container->hasDefinition("tpg_extjs.orm_serializer")) {
+                                    $container->getDefinition('tpg_extjs.orm_serializer')->replaceArgument(4, $def);
+                }
+                if ($container->hasDefinition("tpg_extjs.odm_serializer")) {
+                                    $container->getDefinition('tpg_extjs.odm_serializer')->replaceArgument(4, $def);
+                }
             }
         ));
 

Listener/DeserializationAssociateRelationship.php

Braces +3 added lines, -1 removed lines

@@ -27,7 +27,9 @@
         $classMetadata = $e->getContext()->getMetadataFactory()->getMetadataForClass($className);
         /** @var PropertyMetadata $propertyMetadata */
         foreach ($classMetadata->propertyMetadata as $propertyMetadata) {
-            if ($propertyMetadata->reflection === null) continue;
+            if ($propertyMetadata->reflection === null) {
+                continue;
+            }
             /** @var JoinColumn $joinColumnAnnotation */
             $joinColumnAnnotation = $this->reader->getPropertyAnnotation(
                 $propertyMetadata->reflection,