AmsTaFFix / extjs-bundle

Generator/RestControllerGenerator.php

Doc Comments +17 added lines

@@ -18,6 +18,9 @@ 
      */
     protected $entityBundle;
 
+    /**
+     * @param string $name
+     */
     public function setEntityName($name) {
         $this->entityName = $name;
     }
@@ -25,18 +28,32 @@ 
         $this->entityBundle = $bundle;
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setUseTrait($flag) {
         $this->trait = $flag;
     }
 
+    /**
+     * @param string $file
+     */
     public function setTemplateFile($file) {
         $this->template = $file;
     }
 
+    /**
+     * @param boolean $mongo
+     */
     public function setMongo($mongo) {
         $this->mongo = $mongo;
     }
 
+    /**
+     * @param string $controller
+     * @param string $routeFormat
+     * @param string $templateFormat
+     */
     public function generate(BundleInterface $bundle, $controller, $routeFormat, $templateFormat, array $actions = array())
     {
         $dir = $bundle->getPath();

Service/GeneratorService.php

Doc Comments +13 added lines, -4 removed lines

@@ -27,10 +27,16 @@ 
     protected $remotingBundles = array();
     protected $fieldsParams = array();
 
+    /**
+     * @param AnnotationReader $reader
+     */
     public function setAnnotationReader($reader) {
         $this->annoReader = $reader;
     }
 
+    /**
+     * @param \Test\TestBundle\Mockup\TwigEngineMokcup $engine
+     */
     public function setTwigEngine($engine) {
         $this->twig = $engine;
     }
@@ -127,6 +133,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function convertNaming($name) {
         return $name;
     }
@@ -351,9 +360,9 @@ 
 
     /**
      * Get Annotation
-     * @param $entity
-     * @param $property
-     * @param $annotation
+     * @param string $entity
+     * @param string $property
+     * @param string $annotation
      * @return Annotation|null
      */
     protected function getAnnotation($entity, $property, $annotation) {
@@ -367,7 +376,7 @@ 
      * Get Column Type of a model.
      *
      * @param $entity string Class name of the entity
-     * @param $property string
+     * @param string $property string
      * @return string
      */
     public function getEntityColumnType($entity, $property) {

Indentation +2 added lines, -2 removed lines

@@ -260,7 +260,7 @@ 
                     break;
                 case 'Doctrine\ORM\Mapping\JoinColumns':
                     if (count($annotation->value) > 1) {
-                      throw new \Exception('Multiple foreign key is not supported');
+                        throw new \Exception('Multiple foreign key is not supported');
                     }
                     $saveField = true;
                     $field['name'] = $this->convertNaming($annotation->value[0]->name);
@@ -284,7 +284,7 @@ 
 
         /** Add the ability to override field parameter */
         if (isset($this->fieldsParams[$field['type']])) {
-          $field = array_merge($field, $this->fieldsParams[$field['type']]);
+            $field = array_merge($field, $this->fieldsParams[$field['type']]);
         }
 
         if (!empty($association)) {

Tests/Fixtures/Test/TestBundle/Document/Client.php

Doc Comments +3 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
     /**
      * Add orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      *
      * @return $this
      */
@@ -109,7 +109,7 @@ 
     /**
      * Remove orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      */
     public function removeOrder(\Test\TestBundle\Document\Order $orders)
     {
@@ -120,7 +120,7 @@ 
     /**
      * Get orders
      *
-     * @return Doctrine\Common\Collections\Collection $orders
+     * @return \Doctrine\Common\Collections\ArrayCollection $orders
      */
     public function getOrders()
     {

Twig/ExtjsExtension.php

Doc Comments -2 removed lines

@@ -48,8 +48,6 @@
     /**
      * Inject ExtJs Model into the DOM.
      *
-     * @param boolean $injection Produce ExtJS model code on the page directly?
-     * @param string $model Model Name.
      */
     public function injectModel() {
         $params = func_get_args();

Tests/Service/GeneratorServiceTest.php

Indentation +7 added lines, -7 removed lines

@@ -21,19 +21,19 @@
         $this->twigEngine = new TwigEngineMokcup();
         $this->service->setTwigEngine($this->twigEngine);
         $this->service->setModelFieldsParameters(array(
-          "date" => array( "format" => "d-m-y")
+            "date" => array( "format" => "d-m-y")
         ));
     }
 
     public function testCustomFieldParameters() {
-      $this->service->generateMarkupForEntity('Test\TestBundle\Model\Person');
-      $fieldsType = array();
-      foreach ($this->twigEngine->renderParameters['fields'] as $field) {
+        $this->service->generateMarkupForEntity('Test\TestBundle\Model\Person');
+        $fieldsType = array();
+        foreach ($this->twigEngine->renderParameters['fields'] as $field) {
         if (isset($field['format'])) {
-          $fieldsType[$field['name']] = $field['format'];
+            $fieldsType[$field['name']] = $field['format'];
+        }
         }
-      }
-      $this->assertEquals("d-m-y", $fieldsType['createdAt']);
+        $this->assertEquals("d-m-y", $fieldsType['createdAt']);
     }
 
     public function testEntityProperty() {