AmsTaFFix / extjs-bundle

Generator/RestControllerGenerator.php

Doc Comments +17 added lines

@@ -18,6 +18,9 @@ 
      */
     protected $entityBundle;
 
+    /**
+     * @param string $name
+     */
     public function setEntityName($name) {
         $this->entityName = $name;
     }
@@ -25,18 +28,32 @@ 
         $this->entityBundle = $bundle;
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setUseTrait($flag) {
         $this->trait = $flag;
     }
 
+    /**
+     * @param string $file
+     */
     public function setTemplateFile($file) {
         $this->template = $file;
     }
 
+    /**
+     * @param boolean $mongo
+     */
     public function setMongo($mongo) {
         $this->mongo = $mongo;
     }
 
+    /**
+     * @param string $controller
+     * @param string $routeFormat
+     * @param string $templateFormat
+     */
     public function generate(BundleInterface $bundle, $controller, $routeFormat, $templateFormat, array $actions = array())
     {
         $dir = $bundle->getPath();

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Tpg\ExtjsBundle\Generator;
 
-use Doctrine\ORM\Mapping\Driver\SimplifiedYamlDriver;
 use Sensio\Bundle\GeneratorBundle\Generator\ControllerGenerator;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\Yaml\Yaml;

Service/GeneratorService.php

Doc Comments +13 added lines, -4 removed lines

@@ -27,10 +27,16 @@ 
     protected $remotingBundles = array();
     protected $fieldsParams = array();
 
+    /**
+     * @param AnnotationReader $reader
+     */
     public function setAnnotationReader($reader) {
         $this->annoReader = $reader;
     }
 
+    /**
+     * @param \Test\TestBundle\Mockup\TwigEngineMokcup $engine
+     */
     public function setTwigEngine($engine) {
         $this->twig = $engine;
     }
@@ -127,6 +133,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function convertNaming($name) {
         return $name;
     }
@@ -351,9 +360,9 @@ 
 
     /**
      * Get Annotation
-     * @param $entity
-     * @param $property
-     * @param $annotation
+     * @param string $entity
+     * @param string $property
+     * @param string $annotation
      * @return Annotation|null
      */
     protected function getAnnotation($entity, $property, $annotation) {
@@ -367,7 +376,7 @@ 
      * Get Column Type of a model.
      *
      * @param $entity string Class name of the entity
-     * @param $property string
+     * @param string $property string
      * @return string
      */
     public function getEntityColumnType($entity, $property) {

Tests/Command/BaseTestGeneratedRestController.php

Unused Use Statements -7 removed lines

@@ -3,16 +3,9 @@
 
 include_once(__DIR__ . '/../app/AppKernel.php');
 
-use Doctrine\Bundle\MongoDBBundle\Command\CreateSchemaDoctrineODMCommand;
-use Doctrine\Bundle\MongoDBBundle\Command\DropSchemaDoctrineODMCommand;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
-use Doctrine\Bundle\DoctrineBundle\Command\CreateDatabaseDoctrineCommand;
-use Doctrine\Bundle\DoctrineBundle\Command\DropDatabaseDoctrineCommand;
-use Doctrine\Bundle\DoctrineBundle\Command\Proxy\CreateSchemaDoctrineCommand;
-
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Tester\CommandTester;
-use Symfony\Component\Routing\Router;
 use Tpg\ExtjsBundle\Command\GenerateRestControllerCommand;
 
 class BaseTestGeneratedRestController extends WebTestCase {

Tests/Fixtures/Test/TestBundle/Document/Client.php

Doc Comments +3 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
     /**
      * Add orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      *
      * @return $this
      */
@@ -109,7 +109,7 @@ 
     /**
      * Remove orders
      *
-     * @param Test\TestBundle\Document\Order $orders
+     * @param Order $orders
      */
     public function removeOrder(\Test\TestBundle\Document\Order $orders)
     {
@@ -120,7 +120,7 @@ 
     /**
      * Get orders
      *
-     * @return Doctrine\Common\Collections\Collection $orders
+     * @return \Doctrine\Common\Collections\ArrayCollection $orders
      */
     public function getOrders()
     {

Twig/ExtjsExtension.php

Doc Comments -2 removed lines

@@ -48,8 +48,6 @@
     /**
      * Inject ExtJs Model into the DOM.
      *
-     * @param boolean $injection Produce ExtJS model code on the page directly?
-     * @param string $model Model Name.
      */
     public function injectModel() {
         $params = func_get_args();