Environment::getEnv() - Code Metrics - Inspection of "gulp process updated, webpack removed for now unti..." - AmitT/podium - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f31715...0e6aca )

by Amit

created 2018-01-06 15:06 UTC

Environment::getEnv() A

↳ Parent: Environment

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php


class Environment
namespace YourVendor;

class YourClass { }
{
    /**
     * @var mixed
     */
    private $env;

    public function __construct()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Set host name
        $host = $_SERVER['SERVER_NAME'];

        // List of our development domains
        $dev_domains = [
            'localhost',
        ];

        if (in_array($host, $dev_domains)) {

            $this->env = 'development';

            // Set development ENV
            if (!defined('WP_ENV')) {
                define('WP_ENV', 'development');
            }

            // Enable strict error reporting
            error_reporting(E_ALL | E_STRICT);
            @ini_set('display_errors', 1);

            if (!defined('WP_DEBUG')) {
                define('WP_DEBUG', true);
            }

        } else {

            $this->env = 'production';

            // Set production ENV
            if (!defined('WP_ENV')) {
                define('WP_ENV', 'production');
            }

            // Limit post revisions to 5.
            if (!defined('WP_POST_REVISIONS')) {
                define('WP_POST_REVISIONS', 5);
            }

            // disallow wp files editor.
            if (!defined('DISALLOW_FILE_EDIT')) {
                define('DISALLOW_FILE_EDIT', true);
            }

            if (!defined('WP_DEBUG')) {
                define('WP_DEBUG', false);
            }

        }

        if (!defined('WP_ENV')) {

            // Fallback if WP_ENV isn't defined
            // Used to check for 'development' or 'production'
            if (!defined('WP_ENV')) {
                define('WP_ENV', 'production');
            }

        }

    }

    /**
     * @return null
     */
    public function getEnv()
    {

        return $this->env;

    }

}

function set_environment()
{

    $env = new Environment();
    return $env;

}

add_action('init', 'set_environment', 2);


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-06 15:08 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 3 and the first side effect is on line 94. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			class Environment
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-06 15:08 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			/**
6			* @var mixed
7			*/
8			private $env;
9
10			public function __construct()
			0 ignored issues – show Coding Style introduced 2018-01-06 15:08 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
11			{
12			// Set host name
13			$host = $_SERVER['SERVER_NAME'];
14
15			// List of our development domains
16			$dev_domains = [
17			'localhost',
18			];
19
20			if (in_array($host, $dev_domains)) {
21
22			$this->env = 'development';
23
24			// Set development ENV
25			if (!defined('WP_ENV')) {
26			define('WP_ENV', 'development');
27			}
28
29			// Enable strict error reporting
30			error_reporting(E_ALL \| E_STRICT);
31			@ini_set('display_errors', 1);
32
33			if (!defined('WP_DEBUG')) {
34			define('WP_DEBUG', true);
35			}
36
37			} else {
38
39			$this->env = 'production';
40
41			// Set production ENV
42			if (!defined('WP_ENV')) {
43			define('WP_ENV', 'production');
44			}
45
46			// Limit post revisions to 5.
47			if (!defined('WP_POST_REVISIONS')) {
48			define('WP_POST_REVISIONS', 5);
49			}
50
51			// disallow wp files editor.
52			if (!defined('DISALLOW_FILE_EDIT')) {
53			define('DISALLOW_FILE_EDIT', true);
54			}
55
56			if (!defined('WP_DEBUG')) {
57			define('WP_DEBUG', false);
58			}
59
60			}
61
62			if (!defined('WP_ENV')) {
63
64			// Fallback if WP_ENV isn't defined
65			// Used to check for 'development' or 'production'
66			if (!defined('WP_ENV')) {
67			define('WP_ENV', 'production');
68			}
69
70			}
71
72			}
73
74			/**
75			* @return null
76			*/
77			public function getEnv()
78			{
79
80			return $this->env;
81
82			}
83
84			}
85
86			function set_environment()
87			{
88
89			$env = new Environment();
90			return $env;
91
92			}
93
94			add_action('init', 'set_environment', 2);
95

AmitT / podium

Push — master ( f31715...0e6aca )

Environment::getEnv() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like