App\Http\Controllers\TaskController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	117
Duplicated Lines	10.26 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	11
Bugs	0	Features	7

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	8	1
A	create()	0	4	1
A	store()	0	12	4
A	show()	12	12	2
A	edit()	0	4	1
A	update()	0	14	2
A	destroy()	0	4	1

<?php

namespace App\Http\Controllers;

use Acme\Transformers\TaskTransformer;
use App\Task;
use Illuminate\Http\Request;
use Illuminate\Http\Response as IlluminateResponse;
use Illuminate\Support\Facades\Input;

class TaskController extends ApiController
{
    protected $taskTransformer;
    /**
     * TaskController constructor.
     * @param $taskTransformer
     */
    public function __construct(TaskTransformer $taskTransformer)
    {
        $this->taskTransformer = $taskTransformer;

    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //1. No és retorna: paginació
        //return Task::all();

63% of this comment could be valid code. Did you maybe forget this after debugging?

        $task = Task::all();
        return $this->respond($this->taskTransformer->transformCollection($task->all()));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *  @return \Illuminate\Http\Response
     */
    public function store()
    {
        if (!Input::get('name') or !Input::get('done') or !Input::get('priority'))

Using logical operators such as or instead of || is generally not recommended.

        {
            return $this->setStatusCode(IlluminateResponse::HTTP_UNPROCESSABLE_ENTITY)
                        ->respondWithError('Parameters failed validation for a task.');
        }

        Task::create(Input::all());

        return $this->respondCreated('Task successfully created.');
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $task = Task::find($id);

        if (!$task) {
            return $this->respondNotFound('Task does not exsist');
        }

        return $this->respond([
            'data' => $this->taskTransformer->transform($task)
        ]);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $task = Task::find($id);

        if (!$task)
        {
            return $this->respondNotFound('Task does not exist!!');
        }

        $task->name = $request->name;

The property name does not seem to exist in Illuminate\Http\Request.

        $task->priority = $request->priority;

The property priority does not seem to exist in Illuminate\Http\Request.

        $task->done = $request->done;

The property done does not seem to exist in Illuminate\Http\Request.

        $task->save();
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Task::destroy($id);
    }
}