App\Http\Controllers\TagController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	124
Duplicated Lines	9.68 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	5
Bugs	0	Features	4

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	8	1
A	create()	0	4	1
A	store()	0	12	2
A	show()	12	12	2
A	edit()	0	4	1
A	update()	0	10	2
A	destroy()	0	4	1
A	getTags()	0	4	2

<?php

namespace App\Http\Controllers;

use Acme\Transformers\TagTransformer;
use App\Tag;
use App\Task;
use Illuminate\Http\Request;
use Illuminate\Http\Response as IlluminateResponse;
use Illuminate\Support\Facades\Input;

/**
 * Class TagController
 * @package App\Http\Controllers
 */
class TagController extends ApiController
{
    /**
     * @var TagTransformer
     */
    protected $tagTransformer;
    /**
     * TagController constructor.
     * @param $tagTransformer
     */
    public function __construct(TagTransformer $tagTransformer)
    {
        $this->tagTransformer = $tagTransformer;
    }

    /**
     * Display a listing of the resource.
     * @param null $taskId
     * @return \Illuminate\Http\Response
     */
    public function index($taskId = null)
    {
        //1. No és retorna: paginació
        //return Tag::all();

63% of this comment could be valid code. Did you maybe forget this after debugging?

        $tag = $this->getTags($taskId);
        return $this->respond($this->tagTransformer->transformCollection($tag->all()));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *  @return \Illuminate\Http\Response
     */
    public function store()
    {
        if (!Input::get('title'))
        {
            return $this->setStatusCode(IlluminateResponse::HTTP_UNPROCESSABLE_ENTITY)
                ->respondWithError('Parameters failed validation for a task.');
        }

        Tag::create(Input::all());

        return $this->respondCreated('Task successfully created.');
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $tag = Tag::find($id);

        if (!$tag) {
            return $this->respondNotFound('Tag does not exsist');
        }

        return $this->respond([
            'data' => $this->tagTransformer->transform($tag)
        ]);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $tag = Tag::find($id);
        if (!$tag)
        {
            return $this->respondNotFound('Tag does not exist!');
        }
        $tag->title = $request->title;

The property title does not seem to exist in Illuminate\Http\Request.

        $tag->save();
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Tag::destroy($id);
    }

    /**
    * @param $taskId
    * @return \Illuminate\Database\Eloquent\Collection|static[]
    */
    public function getTags($taskId)
     {
         return $taskId ? Task::findOrFail($taskId)->tags : Tag::all();
     }
}