Request::makeRequest() - Code Metrics - Inspection of "Moved Request class to a trait" - AlphaRecon19/Cloudflare-PHP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e081a1...30c51d )

by Chris

created 2016-05-16 23:11 UTC

Request::makeRequest() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	1
eloc	9
nc	1
nop	2

<?php
/**
 * @author Chris Hilsdon <[email protected]>
 */
namespace Cloudflare\Traits;

use GuzzleHttp\Client;

trait Request
{
    protected $request;
    protected $response;

    public function makeRequest($request = "", $type = "GET")
    {
        $client = new Client();
        $this->request = $client->request($type, $this->CF->Endpoint . $request, [
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'headers' => [
                'X-Auth-Key' => $this->CF->APIKEY,
                'X-Auth-Email' => $this->CF->Email
            ]
        ]);

        $response = (string) $this->request->getBody();
        $this->response = @json_decode($response);

        return $this;
    }

    public function getResponse()
    {
        return $this->response;
    }
}


1			<?php
2			/**
3			* @author Chris Hilsdon <[email protected]>
4			*/
5			namespace Cloudflare\Traits;
6
7			use GuzzleHttp\Client;
8
9			trait Request
10			{
11			protected $request;
12			protected $response;
13
14			public function makeRequest($request = "", $type = "GET")
15			{
16			$client = new Client();
17			$this->request = $client->request($type, $this->CF->Endpoint . $request, [
			0 ignored issues – show Bug introduced 2016-05-16 23:13 UTC by Report Bug Copy Issue Report The property `CF` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			'headers' => [
19			'X-Auth-Key' => $this->CF->APIKEY,
20			'X-Auth-Email' => $this->CF->Email
21			]
22			]);
23
24			$response = (string) $this->request->getBody();
25			$this->response = @json_decode($response);
26
27			return $this;
28			}
29
30			public function getResponse()
31			{
32			return $this->response;
33			}
34			}
35

AlphaRecon19 / Cloudflare-PHP

Push — develop ( e081a1...30c51d )

Request::makeRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like